block/blkdebug: fix memory leak

[PATCH] block/blkdebug: fix memory leak

Elena Afanasova posted 1 patch 5 years, 1 month ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1e903f928eb3da332cc95e2a6f87243bd9fe66e4.camel@gmail.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

block/blkdebug.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] block/blkdebug: fix memory leak

Posted by Elena Afanasova 5 years, 1 month ago

Spotted by PVS-Studio

Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
---
 block/blkdebug.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/block/blkdebug.c b/block/blkdebug.c
index eecbf3e5c4..54da719dd1 100644
--- a/block/blkdebug.c
+++ b/block/blkdebug.c
@@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp)
                                  BLKDEBUG_IO_TYPE__MAX, &local_error);
         if (local_error) {
             error_propagate(errp, local_error);
+            g_free(rule);
             return -1;
         }
         if (iotype != BLKDEBUG_IO_TYPE__MAX) {
-- 
2.25.1

Re: [PATCH] block/blkdebug: fix memory leak

Posted by Eric Blake 5 years, 1 month ago

On 10/9/20 2:09 PM, Elena Afanasova wrote:
> Spotted by PVS-Studio
> 
> Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
> ---
>  block/blkdebug.c | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Eric Blake <eblake@redhat.com>

> 
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index eecbf3e5c4..54da719dd1 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp)
>                                   BLKDEBUG_IO_TYPE__MAX, &local_error);
>          if (local_error) {
>              error_propagate(errp, local_error);
> +            g_free(rule);
>              return -1;
>          }
>          if (iotype != BLKDEBUG_IO_TYPE__MAX) {
> 

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

Re: [PATCH] block/blkdebug: fix memory leak

Posted by Laurent Vivier 5 years, 1 month ago

Le 09/10/2020 à 21:09, Elena Afanasova a écrit :
> Spotted by PVS-Studio
> 
> Signed-off-by: Elena Afanasova <eafanasova@gmail.com>
> ---
>  block/blkdebug.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/block/blkdebug.c b/block/blkdebug.c
> index eecbf3e5c4..54da719dd1 100644
> --- a/block/blkdebug.c
> +++ b/block/blkdebug.c
> @@ -215,6 +215,7 @@ static int add_rule(void *opaque, QemuOpts *opts, Error **errp)
>                                   BLKDEBUG_IO_TYPE__MAX, &local_error);
>          if (local_error) {
>              error_propagate(errp, local_error);
> +            g_free(rule);
>              return -1;
>          }
>          if (iotype != BLKDEBUG_IO_TYPE__MAX) {
> 

Applied to my trivial-patches branch.

Thanks,
Laurent