[PATCH 0/9] more audio fixes and improvements

Volker Rümelin posted 9 patches 4 years, 3 months ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch passed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1e29e1d3-b59b-fcd6-cdff-a680bcdbffa4@t-online.de
Maintainers: Gerd Hoffmann <kraxel@redhat.com>
audio/alsaaudio.c |  1 +
audio/audio.c     | 77 ++++++++++++++++++++++++++-----------------------------
audio/audio_int.h |  4 +--
audio/coreaudio.c |  7 +++--
audio/noaudio.c   |  1 +
audio/ossaudio.c  | 28 ++++++++++++--------
audio/paaudio.c   |  6 ++---
audio/sdlaudio.c  |  7 +++--
audio/wavaudio.c  |  1 +
9 files changed, 71 insertions(+), 61 deletions(-)
[PATCH 0/9] more audio fixes and improvements
Posted by Volker Rümelin 4 years, 3 months ago
The first two patches "audio: fix audio_generic_write" and
"audio: fix audio_generic_read" are only compile tested. The
code is only reachable from the DirectSound backend with the
mixing-engine off. I don't know if it is reachable at all.
I can't test because I don't have a Windows computer.

Volker Rümelin (9):
  audio: fix audio_generic_write
  audio: fix audio_generic_read
  paaudio: remove unused variables
  audio: prevent SIGSEGV in AUD_get_buffer_size_out
  audio: fix bug 1858488
  ossaudio: prevent SIGSEGV in oss_enable_out
  ossaudio: prevent SIGPFE in oss_write
  ossaudio: disable poll mode can't be reached
  audio: audio_generic_get_buffer_in should honor *size

 audio/alsaaudio.c |  1 +
 audio/audio.c     | 77 ++++++++++++++++++++++++++-----------------------------
 audio/audio_int.h |  4 +--
 audio/coreaudio.c |  7 +++--
 audio/noaudio.c   |  1 +
 audio/ossaudio.c  | 28 ++++++++++++--------
 audio/paaudio.c   |  6 ++---
 audio/sdlaudio.c  |  7 +++--
 audio/wavaudio.c  |  1 +
 9 files changed, 71 insertions(+), 61 deletions(-)

-- 
2.16.4


Re: [PATCH 0/9] more audio fixes and improvements
Posted by Mark Cave-Ayland 4 years, 3 months ago
On 23/01/2020 07:41, Volker Rümelin wrote:

> The first two patches "audio: fix audio_generic_write" and
> "audio: fix audio_generic_read" are only compile tested. The
> code is only reachable from the DirectSound backend with the
> mixing-engine off. I don't know if it is reachable at all.
> I can't test because I don't have a Windows computer.
> 
> Volker Rümelin (9):
>   audio: fix audio_generic_write
>   audio: fix audio_generic_read
>   paaudio: remove unused variables
>   audio: prevent SIGSEGV in AUD_get_buffer_size_out
>   audio: fix bug 1858488
>   ossaudio: prevent SIGSEGV in oss_enable_out
>   ossaudio: prevent SIGPFE in oss_write
>   ossaudio: disable poll mode can't be reached
>   audio: audio_generic_get_buffer_in should honor *size
> 
>  audio/alsaaudio.c |  1 +
>  audio/audio.c     | 77 ++++++++++++++++++++++++++-----------------------------
>  audio/audio_int.h |  4 +--
>  audio/coreaudio.c |  7 +++--
>  audio/noaudio.c   |  1 +
>  audio/ossaudio.c  | 28 ++++++++++++--------
>  audio/paaudio.c   |  6 ++---
>  audio/sdlaudio.c  |  7 +++--
>  audio/wavaudio.c  |  1 +
>  9 files changed, 71 insertions(+), 61 deletions(-)

Thanks for your patches! I've had reports from some of the PPC emulation guys that
the switch to the new audio API broke the coreaudio backend on Macs (see
https://bugs.launchpad.net/qemu/+bug/1859916) and I've pointed them towards this
patchset, but sadly it still doesn't appear to fix the issue.

Have you seen any issues with the coreaudio backend during your testing?


ATB,

Mark.

Re: [PATCH 0/9] more audio fixes and improvements
Posted by Volker Rümelin 4 years, 3 months ago
> On 23/01/2020 07:41, Volker Rümelin wrote:
>
>> The first two patches "audio: fix audio_generic_write" and
>> "audio: fix audio_generic_read" are only compile tested. The
>> code is only reachable from the DirectSound backend with the
>> mixing-engine off. I don't know if it is reachable at all.
>> I can't test because I don't have a Windows computer.
>>
>> Volker Rümelin (9):
>>   audio: fix audio_generic_write
>>   audio: fix audio_generic_read
>>   paaudio: remove unused variables
>>   audio: prevent SIGSEGV in AUD_get_buffer_size_out
>>   audio: fix bug 1858488
>>   ossaudio: prevent SIGSEGV in oss_enable_out
>>   ossaudio: prevent SIGPFE in oss_write
>>   ossaudio: disable poll mode can't be reached
>>   audio: audio_generic_get_buffer_in should honor *size
>>
>>  audio/alsaaudio.c |  1 +
>>  audio/audio.c     | 77 ++++++++++++++++++++++++++-----------------------------
>>  audio/audio_int.h |  4 +--
>>  audio/coreaudio.c |  7 +++--
>>  audio/noaudio.c   |  1 +
>>  audio/ossaudio.c  | 28 ++++++++++++--------
>>  audio/paaudio.c   |  6 ++---
>>  audio/sdlaudio.c  |  7 +++--
>>  audio/wavaudio.c  |  1 +
>>  9 files changed, 71 insertions(+), 61 deletions(-)
> Thanks for your patches! I've had reports from some of the PPC emulation guys that
> the switch to the new audio API broke the coreaudio backend on Macs (see
> https://bugs.launchpad.net/qemu/+bug/1859916) and I've pointed them towards this
> patchset, but sadly it still doesn't appear to fix the issue.
>
> Have you seen any issues with the coreaudio backend during your testing?

Hi Mark,

I didn't test coreaudio. I don't have a Mac. One of my patches changes coreaudio.c 
because I renamed a function.

With best regards,
Volker

> ATB,
>
> Mark.