Migration of a guest in the suspended runstate is broken. The incoming
migration code automatically tries to wake the guest, which is wrong;
the guest should end migration in the same runstate it started. Further,
for a restored snapshot, the automatic wakeup fails. The runstate is
RUNNING, but the guest is not. See the commit messages for the details.
Changes in V2:
* simplify "start on wakeup request"
* fix postcopy, snapshot, and background migration
* refactor fixes for each type of migration
* explicitly handled suspended events and runstate in tests
* add test for postcopy and background migration
Changes in V3:
* rebase to tip
* fix hang in new function migrate_wait_for_dirty_mem
Steve Sistare (10):
vl: start on wakeup request
migration: preserve suspended runstate
migration: add runstate function
migration: preserve suspended for snapshot
migration: preserve suspended for bg_migration
tests/qtest: migration events
tests/qtest: option to suspend during migration
tests/qtest: precopy migration with suspend
tests/qtest: postcopy migration with suspend
tests/qtest: background migration with suspend
include/sysemu/runstate.h | 1 +
migration/migration.c | 28 ++++--
migration/migration.h | 1 +
migration/savevm.c | 9 +-
softmmu/cpus.c | 12 +++
softmmu/runstate.c | 5 +-
tests/migration/i386/Makefile | 5 +-
tests/migration/i386/a-b-bootblock.S | 51 +++++++++-
tests/migration/i386/a-b-bootblock.h | 22 +++--
tests/qtest/migration-helpers.c | 27 ++----
tests/qtest/migration-helpers.h | 9 +-
tests/qtest/migration-test.c | 177 +++++++++++++++++++++++++++--------
12 files changed, 258 insertions(+), 89 deletions(-)
--
1.8.3.1