hw/tpm/tpm_crb.c | 22 ++++++++++++++++++++-- hw/vfio/common.c | 15 ++++++++++++++- hw/vfio/trace-events | 1 + 3 files changed, 35 insertions(+), 3 deletions(-)
The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
are available in the Git repository at:
git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
----------------------------------------------------------------
VFIO fixes 2022-02-03
* Fix alignment warnings when using TPM CRB with vfio-pci devices
(Eric Auger & Philippe Mathieu-Daudé)
----------------------------------------------------------------
Eric Auger (2):
tpm: CRB: Use ram_device for "tpm-crb-cmd" region
hw/vfio/common: Silence ram device offset alignment error traces
hw/tpm/tpm_crb.c | 22 ++++++++++++++++++++--
hw/vfio/common.c | 15 ++++++++++++++-
hw/vfio/trace-events | 1 +
3 files changed, 35 insertions(+), 3 deletions(-)
On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
>
> The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
>
> Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
>
> are available in the Git repository at:
>
> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
>
> for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
>
> hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
>
> ----------------------------------------------------------------
> VFIO fixes 2022-02-03
>
> * Fix alignment warnings when using TPM CRB with vfio-pci devices
> (Eric Auger & Philippe Mathieu-Daudé)
Hi; this has a format-string issue that means it doesn't build
on 32-bit systems:
https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
../hw/vfio/common.c: In function 'vfio_listener_region_add':
../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
'int'} [-Werror=format=]
error_report("%s received unaligned region %s iova=0x%"PRIx64
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../hw/vfio/common.c:899:26:
qemu_real_host_page_mask);
~~~~~~~~~~~~~~~~~~~~~~~~
For intptr_t you want PRIxPTR.
thanks
-- PMM
On 5/2/22 11:49, Peter Maydell wrote:
> On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
>>
>> The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
>>
>> Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
>>
>> are available in the Git repository at:
>>
>> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
>>
>> for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
>>
>> hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
>>
>> ----------------------------------------------------------------
>> VFIO fixes 2022-02-03
>>
>> * Fix alignment warnings when using TPM CRB with vfio-pci devices
>> (Eric Auger & Philippe Mathieu-Daudé)
>
> Hi; this has a format-string issue that means it doesn't build
> on 32-bit systems:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>
> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> 'int'} [-Werror=format=]
> error_report("%s received unaligned region %s iova=0x%"PRIx64
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../hw/vfio/common.c:899:26:
> qemu_real_host_page_mask);
> ~~~~~~~~~~~~~~~~~~~~~~~~
>
> For intptr_t you want PRIxPTR.
Thanks Peter.
Eric, can you follow up on this series, looking at Igor comments wrt
migration state?
Phil.
Hi
On 2/5/22 12:19 PM, Philippe Mathieu-Daudé wrote:
> On 5/2/22 11:49, Peter Maydell wrote:
>> On Thu, 3 Feb 2022 at 22:38, Alex Williamson
>> <alex.williamson@redhat.com> wrote:
>>>
>>> The following changes since commit
>>> 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
>>>
>>> Merge remote-tracking branch
>>> 'remotes/hdeller/tags/hppa-updates-pull-request' into staging
>>> (2022-02-02 19:54:30 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
>>>
>>> for you to fetch changes up to
>>> 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
>>>
>>> hw/vfio/common: Silence ram device offset alignment error traces
>>> (2022-02-03 15:05:05 -0700)
>>>
>>> ----------------------------------------------------------------
>>> VFIO fixes 2022-02-03
>>>
>>> * Fix alignment warnings when using TPM CRB with vfio-pci devices
>>> (Eric Auger & Philippe Mathieu-Daudé)
>>
>> Hi; this has a format-string issue that means it doesn't build
>> on 32-bit systems:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>>
>> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
>> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
>> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
>> 'int'} [-Werror=format=]
>> error_report("%s received unaligned region %s iova=0x%"PRIx64
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../hw/vfio/common.c:899:26:
>> qemu_real_host_page_mask);
>> ~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> For intptr_t you want PRIxPTR.
>
> Thanks Peter.
>
> Eric, can you follow up on this series, looking at Igor comments wrt
> migration state?
Sure I will.
Eric
>
> Phil.
>
On Sat, 5 Feb 2022 10:49:35 +0000
Peter Maydell <peter.maydell@linaro.org> wrote:
> On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
> >
> > The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
> >
> > Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
> >
> > are available in the Git repository at:
> >
> > git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
> >
> > for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
> >
> > hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
> >
> > ----------------------------------------------------------------
> > VFIO fixes 2022-02-03
> >
> > * Fix alignment warnings when using TPM CRB with vfio-pci devices
> > (Eric Auger & Philippe Mathieu-Daudé)
>
> Hi; this has a format-string issue that means it doesn't build
> on 32-bit systems:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>
> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> 'int'} [-Werror=format=]
> error_report("%s received unaligned region %s iova=0x%"PRIx64
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../hw/vfio/common.c:899:26:
> qemu_real_host_page_mask);
> ~~~~~~~~~~~~~~~~~~~~~~~~
>
> For intptr_t you want PRIxPTR.
Darn. Well, let me use this opportunity to ask, how are folks doing
32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
purpose, but I was eventually no longer able to maintain the build
dependencies. Looks like this failed on a mipsel cross build, but I
don't see such a cross compiler in Fedora. I do mingw32/64 cross
builds, but they leave a lot to be desired for code coverage. Thanks,
Alex
On 7/2/22 16:50, Alex Williamson wrote:
> On Sat, 5 Feb 2022 10:49:35 +0000
> Peter Maydell <peter.maydell@linaro.org> wrote:
>> Hi; this has a format-string issue that means it doesn't build
>> on 32-bit systems:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>>
>> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
>> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
>> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
>> 'int'} [-Werror=format=]
>> error_report("%s received unaligned region %s iova=0x%"PRIx64
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../hw/vfio/common.c:899:26:
>> qemu_real_host_page_mask);
>> ~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> For intptr_t you want PRIxPTR.
>
> Darn. Well, let me use this opportunity to ask, how are folks doing
> 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
> purpose, but I was eventually no longer able to maintain the build
> dependencies. Looks like this failed on a mipsel cross build, but I
> don't see such a cross compiler in Fedora. I do mingw32/64 cross
> builds, but they leave a lot to be desired for code coverage. Thanks,
You can use docker images:
https://wiki.qemu.org/Testing/DockerBuild
On Mon, 7 Feb 2022 17:08:01 +0100
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> On 7/2/22 16:50, Alex Williamson wrote:
> > On Sat, 5 Feb 2022 10:49:35 +0000
> > Peter Maydell <peter.maydell@linaro.org> wrote:
>
> >> Hi; this has a format-string issue that means it doesn't build
> >> on 32-bit systems:
> >>
> >> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
> >>
> >> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> >> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> >> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> >> 'int'} [-Werror=format=]
> >> error_report("%s received unaligned region %s iova=0x%"PRIx64
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> ../hw/vfio/common.c:899:26:
> >> qemu_real_host_page_mask);
> >> ~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> For intptr_t you want PRIxPTR.
> >
> > Darn. Well, let me use this opportunity to ask, how are folks doing
> > 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
> > purpose, but I was eventually no longer able to maintain the build
> > dependencies. Looks like this failed on a mipsel cross build, but I
> > don't see such a cross compiler in Fedora. I do mingw32/64 cross
> > builds, but they leave a lot to be desired for code coverage. Thanks,
>
> You can use docker images:
> https://wiki.qemu.org/Testing/DockerBuild
Hmm, not ideal...
Clean git clone, HEAD 55ef0b702bc2 ("Merge remote-tracking branch 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging")
$ make docker-test-quick@debian-mips64el-cross J=16
...
1/1 qemu:block / qemu-iotests qcow2 RUNNING
>>> PYTHON=/usr/bin/python3 MALLOC_PERTURB_=188 /bin/sh /tmp/qemu-test/build/../src/tests/qemu-iotests/../check-block.sh qcow2
1/1 qemu:block / qemu-iotests qcow2 ERROR 0.18s exit status 1
Summary of Failures:
1/1 qemu:block / qemu-iotests qcow2 ERROR 0.18s exit status 1
Ok: 0
Expected Fail: 0
Fail: 1
Unexpected Pass: 0
Skipped: 0
Timeout: 0
Full log written to /tmp/qemu-test/build/meson-logs/iotestslog.txt
make: *** [/tmp/qemu-test/src/tests/Makefile.include:160: check-block] Error 1
make: *** Waiting for unfinished jobs....
130/131 qemu:qapi-schema+qapi-frontend / QAPI schema regression tests OK 0.20s
131/131 qemu:decodetree / decodetree OK 1.75s
Ok: 3
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 128
Timeout: 0
Full log written to /tmp/qemu-test/build/meson-logs/testlog.txt
Traceback (most recent call last):
File "/tmp/qemu.git/./tests/docker/docker.py", line 758, in <module>
sys.exit(main())
File "/tmp/qemu.git/./tests/docker/docker.py", line 754, in main
return args.cmdobj.run(args, argv)
File "/tmp/qemu.git/./tests/docker/docker.py", line 430, in run
return Docker().run(argv, args.keep, quiet=args.quiet,
File "/tmp/qemu.git/./tests/docker/docker.py", line 388, in run
ret = self._do_check(["run", "--rm", "--label",
File "/tmp/qemu.git/./tests/docker/docker.py", line 252, in _do_check
return subprocess.check_call(self._command + cmd, **kwargs)
File "/usr/lib64/python3.9/subprocess.py", line 373, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['podman', 'run', '--rm', '--label', 'com.qemu.instance.uuid=560d8331a06b4fd9bbb74910f3a2b436', '--userns=keep-id', '-u', '1000', '--security-opt', 'seccomp=unconfined', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=16', '-e', 'DEBUG=', '-e', 'SHOW_ENV=', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/home/alwillia/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/tmp/qemu.git/docker-src.2022-02-07-09.45.59.2258561:/var/tmp/qemu:z,ro', 'qemu/debian-mips64el-cross', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 2.
filter=--filter=label=com.qemu.instance.uuid=560d8331a06b4fd9bbb74910f3a2b436
make[1]: *** [tests/docker/Makefile.include:306: docker-run] Error 1
make[1]: Leaving directory '/tmp/qemu.git'
make: *** [tests/docker/Makefile.include:339: docker-run-test-quick@debian-mips64el-cross] Error 2
On Mon, 7 Feb 2022 09:54:59 -0700
Alex Williamson <alex.williamson@redhat.com> wrote:
> On Mon, 7 Feb 2022 17:08:01 +0100
> Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> > On 7/2/22 16:50, Alex Williamson wrote:
> > > On Sat, 5 Feb 2022 10:49:35 +0000
> > > Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> > >> Hi; this has a format-string issue that means it doesn't build
> > >> on 32-bit systems:
> > >>
> > >> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
> > >>
> > >> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> > >> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> > >> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> > >> 'int'} [-Werror=format=]
> > >> error_report("%s received unaligned region %s iova=0x%"PRIx64
> > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> ../hw/vfio/common.c:899:26:
> > >> qemu_real_host_page_mask);
> > >> ~~~~~~~~~~~~~~~~~~~~~~~~
> > >>
> > >> For intptr_t you want PRIxPTR.
> > >
> > > Darn. Well, let me use this opportunity to ask, how are folks doing
> > > 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
> > > purpose, but I was eventually no longer able to maintain the build
> > > dependencies. Looks like this failed on a mipsel cross build, but I
> > > don't see such a cross compiler in Fedora. I do mingw32/64 cross
> > > builds, but they leave a lot to be desired for code coverage. Thanks,
> >
> > You can use docker images:
> > https://wiki.qemu.org/Testing/DockerBuild
>
> Hmm, not ideal...
>
> Clean git clone, HEAD 55ef0b702bc2 ("Merge remote-tracking branch 'remotes/lvivier-gitlab/tags/linux-user-for-7.0-pull-request' into staging")
>
> $ make docker-test-quick@debian-mips64el-cross J=16
Accidentally selected the mips64el, but tests failing seems to be
common. I can reproduce the build issue with either the mipsel or
fedora-i386-cross, so I'll include some flavor of the test-build in my
build script. Thanks,
Alex
On 07/02/2022 16.50, Alex Williamson wrote:
> On Sat, 5 Feb 2022 10:49:35 +0000
> Peter Maydell <peter.maydell@linaro.org> wrote:
>
>> On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
>>>
>>> The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
>>>
>>> Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
>>>
>>> for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
>>>
>>> hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
>>>
>>> ----------------------------------------------------------------
>>> VFIO fixes 2022-02-03
>>>
>>> * Fix alignment warnings when using TPM CRB with vfio-pci devices
>>> (Eric Auger & Philippe Mathieu-Daudé)
>>
>> Hi; this has a format-string issue that means it doesn't build
>> on 32-bit systems:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
>>
>> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
>> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
>> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
>> 'int'} [-Werror=format=]
>> error_report("%s received unaligned region %s iova=0x%"PRIx64
>> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> ../hw/vfio/common.c:899:26:
>> qemu_real_host_page_mask);
>> ~~~~~~~~~~~~~~~~~~~~~~~~
>>
>> For intptr_t you want PRIxPTR.
>
> Darn. Well, let me use this opportunity to ask, how are folks doing
> 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
> purpose, but I was eventually no longer able to maintain the build
> dependencies. Looks like this failed on a mipsel cross build, but I
> don't see such a cross compiler in Fedora. I do mingw32/64 cross
> builds, but they leave a lot to be desired for code coverage. Thanks,
The easiest way for getting more test coverage is likely to move your qemu
repository from github to gitlab - then you get most of the CI for free,
which should catch such issues before sending pull requests.
Thomas
On Mon, 7 Feb 2022 17:20:02 +0100
Thomas Huth <thuth@redhat.com> wrote:
> On 07/02/2022 16.50, Alex Williamson wrote:
> > On Sat, 5 Feb 2022 10:49:35 +0000
> > Peter Maydell <peter.maydell@linaro.org> wrote:
> >
> >> On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
> >>>
> >>> The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
> >>>
> >>> Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
> >>>
> >>> are available in the Git repository at:
> >>>
> >>> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
> >>>
> >>> for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
> >>>
> >>> hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
> >>>
> >>> ----------------------------------------------------------------
> >>> VFIO fixes 2022-02-03
> >>>
> >>> * Fix alignment warnings when using TPM CRB with vfio-pci devices
> >>> (Eric Auger & Philippe Mathieu-Daudé)
> >>
> >> Hi; this has a format-string issue that means it doesn't build
> >> on 32-bit systems:
> >>
> >> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
> >>
> >> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> >> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> >> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> >> 'int'} [-Werror=format=]
> >> error_report("%s received unaligned region %s iova=0x%"PRIx64
> >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> >> ../hw/vfio/common.c:899:26:
> >> qemu_real_host_page_mask);
> >> ~~~~~~~~~~~~~~~~~~~~~~~~
> >>
> >> For intptr_t you want PRIxPTR.
> >
> > Darn. Well, let me use this opportunity to ask, how are folks doing
> > 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
> > purpose, but I was eventually no longer able to maintain the build
> > dependencies. Looks like this failed on a mipsel cross build, but I
> > don't see such a cross compiler in Fedora. I do mingw32/64 cross
> > builds, but they leave a lot to be desired for code coverage. Thanks,
>
> The easiest way for getting more test coverage is likely to move your qemu
> repository from github to gitlab - then you get most of the CI for free,
> which should catch such issues before sending pull requests.
Well, it worked for a few months, but now pushing a tag to gitlab runs
a whole 4 jobs vs the 124 jobs that it previously ran, so that's
useless now :( Thanks,
Alex
On Thu, 2 Jun 2022 15:31:38 -0600
Alex Williamson <alex.williamson@redhat.com> wrote:
> On Mon, 7 Feb 2022 17:20:02 +0100
> Thomas Huth <thuth@redhat.com> wrote:
>
> > On 07/02/2022 16.50, Alex Williamson wrote:
> > > On Sat, 5 Feb 2022 10:49:35 +0000
> > > Peter Maydell <peter.maydell@linaro.org> wrote:
> > >
> > >> On Thu, 3 Feb 2022 at 22:38, Alex Williamson <alex.williamson@redhat.com> wrote:
> > >>>
> > >>> The following changes since commit 8f3e5ce773c62bb5c4a847f3a9a5c98bbb3b359f:
> > >>>
> > >>> Merge remote-tracking branch 'remotes/hdeller/tags/hppa-updates-pull-request' into staging (2022-02-02 19:54:30 +0000)
> > >>>
> > >>> are available in the Git repository at:
> > >>>
> > >>> git://github.com/awilliam/qemu-vfio.git tags/vfio-fixes-20220203.0
> > >>>
> > >>> for you to fetch changes up to 36fe5d5836c8d5d928ef6d34e999d6991a2f732e:
> > >>>
> > >>> hw/vfio/common: Silence ram device offset alignment error traces (2022-02-03 15:05:05 -0700)
> > >>>
> > >>> ----------------------------------------------------------------
> > >>> VFIO fixes 2022-02-03
> > >>>
> > >>> * Fix alignment warnings when using TPM CRB with vfio-pci devices
> > >>> (Eric Auger & Philippe Mathieu-Daudé)
> > >>
> > >> Hi; this has a format-string issue that means it doesn't build
> > >> on 32-bit systems:
> > >>
> > >> https://gitlab.com/qemu-project/qemu/-/jobs/2057116569
> > >>
> > >> ../hw/vfio/common.c: In function 'vfio_listener_region_add':
> > >> ../hw/vfio/common.c:893:26: error: format '%llx' expects argument of
> > >> type 'long long unsigned int', but argument 6 has type 'intptr_t' {aka
> > >> 'int'} [-Werror=format=]
> > >> error_report("%s received unaligned region %s iova=0x%"PRIx64
> > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > >> ../hw/vfio/common.c:899:26:
> > >> qemu_real_host_page_mask);
> > >> ~~~~~~~~~~~~~~~~~~~~~~~~
> > >>
> > >> For intptr_t you want PRIxPTR.
> > >
> > > Darn. Well, let me use this opportunity to ask, how are folks doing
> > > 32-bit cross builds on Fedora? I used to keep an i686 PAE VM for this
> > > purpose, but I was eventually no longer able to maintain the build
> > > dependencies. Looks like this failed on a mipsel cross build, but I
> > > don't see such a cross compiler in Fedora. I do mingw32/64 cross
> > > builds, but they leave a lot to be desired for code coverage. Thanks,
> >
> > The easiest way for getting more test coverage is likely to move your qemu
> > repository from github to gitlab - then you get most of the CI for free,
> > which should catch such issues before sending pull requests.
>
> Well, it worked for a few months, but now pushing a tag to gitlab runs
> a whole 4 jobs vs the 124 jobs that it previously ran, so that's
> useless now :( Thanks,
And Richard has now sent me the link to your announcement, including
the git push variables to get things back to normal:
https://lists.nongnu.org/archive/html/qemu-devel/2022-06/msg00256.html
Thanks,
Alex
© 2016 - 2026 Red Hat, Inc.