1. Patchew
  2. QEMU
  3. [PATCH v2 0/3] Move target_signal.h generic definitions to generic/signal.h
  4. View patch

[PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ

Song Gao posted 3 patches 4 years, 2 months ago
Maintainers: Taylor Simpson <tsimpson@quicinc.com>, Laurent Vivier <laurent@vivier.eu>
There is a newer version of this series
[PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ
Posted by Song Gao 4 years, 2 months ago 
TARGET_SIGSTKSZ is not used, we should remove it.

Signed-off-by: Song Gao <gaosong@loongson.cn>
---
 linux-user/alpha/target_signal.h  | 1 -
 linux-user/generic/signal.h       | 1 -
 linux-user/hppa/target_signal.h   | 1 -
 linux-user/mips/target_signal.h   | 1 -
 linux-user/mips64/target_signal.h | 1 -
 linux-user/sparc/target_signal.h  | 1 -
 6 files changed, 6 deletions(-)

diff --git a/linux-user/alpha/target_signal.h b/linux-user/alpha/target_signal.h
index 0b6a39d..bbb06e5 100644
--- a/linux-user/alpha/target_signal.h
+++ b/linux-user/alpha/target_signal.h
@@ -62,7 +62,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_SIGINFO       0x00000040
 
 #define TARGET_MINSIGSTKSZ	4096
-#define TARGET_SIGSTKSZ		16384
 
 /* From <asm/gentrap.h>.  */
 #define TARGET_GEN_INTOVF      -1      /* integer overflow */
diff --git a/linux-user/generic/signal.h b/linux-user/generic/signal.h
index ceaf8a8..6fd05b7 100644
--- a/linux-user/generic/signal.h
+++ b/linux-user/generic/signal.h
@@ -69,7 +69,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SS_DISABLE 2
 
 #define TARGET_MINSIGSTKSZ     2048
-#define TARGET_SIGSTKSZ        8192
 
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h
index d558119..af6c2fc 100644
--- a/linux-user/hppa/target_signal.h
+++ b/linux-user/hppa/target_signal.h
@@ -64,7 +64,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_NOCLDWAIT     0x00000080
 
 #define TARGET_MINSIGSTKSZ	2048
-#define TARGET_SIGSTKSZ		8192
 
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
diff --git a/linux-user/mips/target_signal.h b/linux-user/mips/target_signal.h
index 780a4dd..fa542c1 100644
--- a/linux-user/mips/target_signal.h
+++ b/linux-user/mips/target_signal.h
@@ -67,7 +67,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_RESTORER      0x04000000      /* Only for O32 */
 
 #define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
 
 #if defined(TARGET_ABI_MIPSO32)
 /* compare linux/arch/mips/kernel/signal.c:setup_frame() */
diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h
index 275e9b7..b05098f 100644
--- a/linux-user/mips64/target_signal.h
+++ b/linux-user/mips64/target_signal.h
@@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
 #define TARGET_SA_RESETHAND     0x80000000
 
 #define TARGET_MINSIGSTKSZ    2048
-#define TARGET_SIGSTKSZ       8192
 
 /* bit-flags */
 #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
diff --git a/linux-user/sparc/target_signal.h b/linux-user/sparc/target_signal.h
index e661ddd..87757f0 100644
--- a/linux-user/sparc/target_signal.h
+++ b/linux-user/sparc/target_signal.h
@@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
 #define TARGET_ARCH_HAS_KA_RESTORER 1
 
 #define TARGET_MINSIGSTKSZ	4096
-#define TARGET_SIGSTKSZ		16384
 
 #ifdef TARGET_ABI32
 #define TARGET_ARCH_HAS_SETUP_FRAME
-- 
1.8.3.1
Re: [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ
Posted by Laurent Vivier 4 years, 1 month ago 
Le 26/11/2021 à 03:23, Song Gao a écrit :
> TARGET_SIGSTKSZ is not used, we should remove it.
> 
> Signed-off-by: Song Gao <gaosong@loongson.cn>
> ---
>   linux-user/alpha/target_signal.h  | 1 -
>   linux-user/generic/signal.h       | 1 -
>   linux-user/hppa/target_signal.h   | 1 -
>   linux-user/mips/target_signal.h   | 1 -
>   linux-user/mips64/target_signal.h | 1 -
>   linux-user/sparc/target_signal.h  | 1 -
>   6 files changed, 6 deletions(-)
> 
> diff --git a/linux-user/alpha/target_signal.h b/linux-user/alpha/target_signal.h
> index 0b6a39d..bbb06e5 100644
> --- a/linux-user/alpha/target_signal.h
> +++ b/linux-user/alpha/target_signal.h
> @@ -62,7 +62,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_SIGINFO       0x00000040
>   
>   #define TARGET_MINSIGSTKSZ	4096
> -#define TARGET_SIGSTKSZ		16384
>   
>   /* From <asm/gentrap.h>.  */
>   #define TARGET_GEN_INTOVF      -1      /* integer overflow */
> diff --git a/linux-user/generic/signal.h b/linux-user/generic/signal.h
> index ceaf8a8..6fd05b7 100644
> --- a/linux-user/generic/signal.h
> +++ b/linux-user/generic/signal.h
> @@ -69,7 +69,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SS_DISABLE 2
>   
>   #define TARGET_MINSIGSTKSZ     2048
> -#define TARGET_SIGSTKSZ        8192
>   
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
> diff --git a/linux-user/hppa/target_signal.h b/linux-user/hppa/target_signal.h
> index d558119..af6c2fc 100644
> --- a/linux-user/hppa/target_signal.h
> +++ b/linux-user/hppa/target_signal.h
> @@ -64,7 +64,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_NOCLDWAIT     0x00000080
>   
>   #define TARGET_MINSIGSTKSZ	2048
> -#define TARGET_SIGSTKSZ		8192
>   
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
> diff --git a/linux-user/mips/target_signal.h b/linux-user/mips/target_signal.h
> index 780a4dd..fa542c1 100644
> --- a/linux-user/mips/target_signal.h
> +++ b/linux-user/mips/target_signal.h
> @@ -67,7 +67,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_RESTORER      0x04000000      /* Only for O32 */
>   
>   #define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
>   
>   #if defined(TARGET_ABI_MIPSO32)
>   /* compare linux/arch/mips/kernel/signal.c:setup_frame() */
> diff --git a/linux-user/mips64/target_signal.h b/linux-user/mips64/target_signal.h
> index 275e9b7..b05098f 100644
> --- a/linux-user/mips64/target_signal.h
> +++ b/linux-user/mips64/target_signal.h
> @@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_SA_RESETHAND     0x80000000
>   
>   #define TARGET_MINSIGSTKSZ    2048
> -#define TARGET_SIGSTKSZ       8192
>   
>   /* bit-flags */
>   #define TARGET_SS_AUTODISARM (1U << 31) /* disable sas during sighandling */
> diff --git a/linux-user/sparc/target_signal.h b/linux-user/sparc/target_signal.h
> index e661ddd..87757f0 100644
> --- a/linux-user/sparc/target_signal.h
> +++ b/linux-user/sparc/target_signal.h
> @@ -65,7 +65,6 @@ typedef struct target_sigaltstack {
>   #define TARGET_ARCH_HAS_KA_RESTORER 1
>   
>   #define TARGET_MINSIGSTKSZ	4096
> -#define TARGET_SIGSTKSZ		16384
>   
>   #ifdef TARGET_ABI32
>   #define TARGET_ARCH_HAS_SETUP_FRAME

Applied to my linux-user-for-7.0 branch.

Thanks,
Laurent
Re: [PATCH v2 3/3] linux-user: Remove TARGET_SIGSTKSZ
Posted by Richard Henderson 4 years, 2 months ago 
On 11/26/21 3:23 AM, Song Gao wrote:
> TARGET_SIGSTKSZ is not used, we should remove it.
> 
> Signed-off-by: Song Gao<gaosong@loongson.cn>
> ---
>   linux-user/alpha/target_signal.h  | 1 -
>   linux-user/generic/signal.h       | 1 -
>   linux-user/hppa/target_signal.h   | 1 -
>   linux-user/mips/target_signal.h   | 1 -
>   linux-user/mips64/target_signal.h | 1 -
>   linux-user/sparc/target_signal.h  | 1 -
>   6 files changed, 6 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Patchew 2.1-devel-b67e4c2

© 2016 - 2026 Red Hat, Inc.