The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75:

  Merge remote-tracking branch 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 09:54:42 +0100)

are available in the git repository at:

  https://github.com/quic/qemu tags/pull-hex-20210618

for you to fetch changes up to 13ce2ae03000137e1de8d40ff7ceae46fcb34cd5:

  Hexagon (target/hexagon) remove unused TCG variables (2021-06-18 13:26:07 -0500)

----------------------------------------------------------------
Fixes for bugs found by inspection and internal testing
Tests added to tests/tcg/hexagon/misc.c

----------------------------------------------------------------
Taylor Simpson (4):
      Hexagon (target/hexagon) fix bug in fLSBNEW*
      Hexagon (target/hexagon) fix l2fetch instructions
      Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions
      Hexagon (target/hexagon) remove unused TCG variables

 target/hexagon/gen_tcg.h              | 15 +++++++++--
 target/hexagon/macros.h               | 29 ++++++++-------------
 target/hexagon/genptr.c               | 16 +++---------
 target/hexagon/op_helper.c            |  5 ----
 target/hexagon/translate.c            | 11 ++------
 tests/tcg/hexagon/misc.c              | 48 ++++++++++++++++++++++++++++++++++-
 target/hexagon/imported/encode_pp.def |  3 +++
 7 files changed, 80 insertions(+), 47 deletions(-)

Adding Peter to the CC list ...

> -----Original Message-----
> From: Taylor Simpson <tsimpson@quicinc.com>
> Sent: Friday, June 18, 2021 1:07 PM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimpson@quicinc.com>; richard.henderson@linaro.org;
> philmd@redhat.com; ale@rev.ng; Brian Cain <bcain@quicinc.com>
> Subject: [PULL 0/4] Hexagon (target/hexagon) bug fixes
> 
> The following changes since commit
> 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75:
> 
>   Merge remote-tracking branch 'remotes/kraxel/tags/audio-20210617-pull-
> request' into staging (2021-06-18 09:54:42 +0100)
> 
> are available in the git repository at:
> 
>   https://github.com/quic/qemu tags/pull-hex-20210618
> 
> for you to fetch changes up to 13ce2ae03000137e1de8d40ff7ceae46fcb34cd5:
> 
>   Hexagon (target/hexagon) remove unused TCG variables (2021-06-18
> 13:26:07 -0500)
> 
> ----------------------------------------------------------------
> Fixes for bugs found by inspection and internal testing Tests added to
> tests/tcg/hexagon/misc.c
> 
> ----------------------------------------------------------------
> Taylor Simpson (4):
>       Hexagon (target/hexagon) fix bug in fLSBNEW*
>       Hexagon (target/hexagon) fix l2fetch instructions
>       Hexagon (target/hexagon) cleanup gen_store_conditional[48] functions
>       Hexagon (target/hexagon) remove unused TCG variables
> 
>  target/hexagon/gen_tcg.h              | 15 +++++++++--
>  target/hexagon/macros.h               | 29 ++++++++-------------
>  target/hexagon/genptr.c               | 16 +++---------
>  target/hexagon/op_helper.c            |  5 ----
>  target/hexagon/translate.c            | 11 ++------
>  tests/tcg/hexagon/misc.c              | 48
> ++++++++++++++++++++++++++++++++++-
>  target/hexagon/imported/encode_pp.def |  3 +++
>  7 files changed, 80 insertions(+), 47 deletions(-)

On Wed, 23 Jun 2021 at 15:31, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> Adding Peter to the CC list ...

This is on my to-process list (I catch pull requests by
looking for particular text in the email), but it's from
a git repository I haven't dealt with before, so it went
onto my "deal with when I have some time spare" list.

-- PMM

On Fri, 18 Jun 2021 at 20:08, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 09:54:42 +0100)
>
> are available in the git repository at:
>
>   https://github.com/quic/qemu tags/pull-hex-20210618
>
> for you to fetch changes up to 13ce2ae03000137e1de8d40ff7ceae46fcb34cd5:
>
>   Hexagon (target/hexagon) remove unused TCG variables (2021-06-18 13:26:07 -0500)
>
> ----------------------------------------------------------------
> Fixes for bugs found by inspection and internal testing
> Tests added to tests/tcg/hexagon/misc.c
>

Could you upload the key you used to sign this to
keyserver.ubuntu.com, please ? (The gpg keyserver
infra seems to be having a problem currently since
keys.gnupg.net has been taken down, but the Ubuntu
keyserver works...)

thanks
-- PMM

On Fri, 18 Jun 2021 at 20:08, Taylor Simpson <tsimpson@quicinc.com> wrote:
>
> The following changes since commit 3ccf6cd0e3e1dfd663814640b3b18b55715d7a75:
>
>   Merge remote-tracking branch 'remotes/kraxel/tags/audio-20210617-pull-request' into staging (2021-06-18 09:54:42 +0100)
>
> are available in the git repository at:
>
>   https://github.com/quic/qemu tags/pull-hex-20210618
>
> for you to fetch changes up to 13ce2ae03000137e1de8d40ff7ceae46fcb34cd5:
>
>   Hexagon (target/hexagon) remove unused TCG variables (2021-06-18 13:26:07 -0500)
>
> ----------------------------------------------------------------
> Fixes for bugs found by inspection and internal testing
> Tests added to tests/tcg/hexagon/misc.c
>

(Philippe kindly reuploaded your gpg key to a keyserver that I could
download it from, so that part is now sorted).

This fails the "clang-user" job on gitlab CI:
https://gitlab.com/qemu-project/qemu/-/jobs/1385267038


../target/hexagon/genptr.c:30:20: error: unused function
'gen_read_preg' [-Werror,-Wunused-function]
static inline TCGv gen_read_preg(TCGv pred, uint8_t num)
^

(Clang is pickier than gcc about not having unused static inline functions.)

thanks
-- PMM

> -----Original Message-----
> From: Peter Maydell <peter.maydell@linaro.org>
> Sent: Tuesday, June 29, 2021 6:18 AM
> To: Taylor Simpson <tsimpson@quicinc.com>
> Cc: QEMU Developers <qemu-devel@nongnu.org>; Alessandro Di Federico
> <ale@rev.ng>; Philippe Mathieu-Daudé <philmd@redhat.com>; Richard
> Henderson <richard.henderson@linaro.org>; Brian Cain
> <bcain@quicinc.com>
> Subject: Re: [PULL 0/4] Hexagon (target/hexagon) bug fixes
> 
> 
> (Philippe kindly reuploaded your gpg key to a keyserver that I could
> download it from, so that part is now sorted).

Thanks Philippe!!

> This fails the "clang-user" job on gitlab CI:
> https://gitlab.com/qemu-project/qemu/-/jobs/1385267038
> 
> ../target/hexagon/genptr.c:30:20: error: unused function 'gen_read_preg' [-
> Werror,-Wunused-function] static inline TCGv gen_read_preg(TCGv pred,
> uint8_t num) ^
> 
> (Clang is pickier than gcc about not having unused static inline functions.)

I will fix this and resubmit the pull request.

Thanks,
Taylor