replay: fix event queue flush for qemu shutdown

[PATCH] replay: fix event queue flush for qemu shutdown

Pavel Dovgalyuk posted 1 patch 3 years ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/162125673369.1252743.1121827086025789296.stgit@pasha-ThinkPad-X280

Maintainers: Paolo Bonzini <pbonzini@redhat.com>, Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>

replay/replay.c |    3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

Expand all Fold all

[PATCH] replay: fix event queue flush for qemu shutdown

Posted by Pavel Dovgalyuk 3 years ago

This patch fixes event queue flush in the case of emulator
shutdown. replay_finish_events should be called when replay_mode
is not cleared.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
 replay/replay.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/replay/replay.c b/replay/replay.c
index 6df2abc18c..2d3607998a 100644
--- a/replay/replay.c
+++ b/replay/replay.c
@@ -387,9 +387,8 @@ void replay_finish(void)
     g_free(replay_snapshot);
     replay_snapshot = NULL;
 
-    replay_mode = REPLAY_MODE_NONE;
-
     replay_finish_events();
+    replay_mode = REPLAY_MODE_NONE;
 }
 
 void replay_add_blocker(Error *reason)

Re: [PATCH] replay: fix event queue flush for qemu shutdown

Posted by Pavel Dovgalyuk 2 years, 11 months ago

ping

On 17.05.2021 16:05, Pavel Dovgalyuk wrote:
> This patch fixes event queue flush in the case of emulator
> shutdown. replay_finish_events should be called when replay_mode
> is not cleared.
> 
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
>   replay/replay.c |    3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/replay/replay.c b/replay/replay.c
> index 6df2abc18c..2d3607998a 100644
> --- a/replay/replay.c
> +++ b/replay/replay.c
> @@ -387,9 +387,8 @@ void replay_finish(void)
>       g_free(replay_snapshot);
>       replay_snapshot = NULL;
>   
> -    replay_mode = REPLAY_MODE_NONE;
> -
>       replay_finish_events();
> +    replay_mode = REPLAY_MODE_NONE;
>   }
>   
>   void replay_add_blocker(Error *reason)
>