[v1] Fix typo in CFI build documentation

[PATCH] Fix typo in CFI build documentation

Serge Guelton posted 1 patch 3 years ago

Diff against v1 v2
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1619080415-4888-1-git-send-email-sguelton@redhat.com

There is a newer version of this series

docs/devel/control-flow-integrity.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] Fix typo in CFI build documentation

Posted by Serge Guelton 3 years ago

From: serge-sans-paille <sguelton@redhat.com>

Signed-off-by: Serge Guelton <sguelton@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 docs/devel/control-flow-integrity.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/docs/devel/control-flow-integrity.rst b/docs/devel/control-flow-integrity.rst
index d89d707..e6b73a4 100644
--- a/docs/devel/control-flow-integrity.rst
+++ b/docs/devel/control-flow-integrity.rst
@@ -39,7 +39,7 @@ later).
 Given the use of LTO, a version of AR that supports LLVM IR is required.
 The easies way of doing this is by selecting the AR provided by LLVM::
 
- AR=llvm-ar-9 CC=clang-9 CXX=lang++-9 /path/to/configure --enable-cfi
+ AR=llvm-ar-9 CC=clang-9 CXX=clang++-9 /path/to/configure --enable-cfi
 
 CFI is enabled on every binary produced.
 
@@ -131,7 +131,7 @@ lld with version 11+.
 In other words, to compile with fuzzing and CFI, clang 11+ is required, and
 lld needs to be used as a linker::
 
- AR=llvm-ar-11 CC=clang-11 CXX=lang++-11 /path/to/configure --enable-cfi \
+ AR=llvm-ar-11 CC=clang-11 CXX=clang++-11 /path/to/configure --enable-cfi \
                            -enable-fuzzing --extra-ldflags="-fuse-ld=lld"
 
 and then, compile the fuzzers as usual.
-- 
1.8.3.1

Re: [PATCH] Fix typo in CFI build documentation

Posted by Laurent Vivier 3 years ago

Le 22/04/2021 à 10:33, Serge Guelton a écrit :
> From: serge-sans-paille <sguelton@redhat.com>
> 
> Signed-off-by: Serge Guelton <sguelton@redhat.com>

"If you wrote the patch, make sure your "From:" and "Signed-off-by:" lines use the same spelling."

https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line

Please fix this.

Thanks,
Laurent