[v1] s390x: css: report errors from ccw_dstream_read/write

[PATCH v1 0/1] s390x: css: report errors from ccw_dstream_read/write

Pierre Morel posted 1 patch 3 years ago

Diff against v2
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1617695053-7328-1-git-send-email-pmorel@linux.ibm.com

Maintainers: David Hildenbrand <david@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Thomas Huth <thuth@redhat.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Halil Pasic <pasic@linux.ibm.com>

There is a newer version of this series

hw/char/terminal3270.c | 11 +++++--
hw/s390x/3270-ccw.c    |  3 ++
hw/s390x/css.c         | 16 +++++-----
hw/s390x/virtio-ccw.c  | 66 ++++++++++++++++++++++++++++++------------
4 files changed, 69 insertions(+), 27 deletions(-)

Expand all Fold all

[PATCH v1 0/1] s390x: css: report errors from ccw_dstream_read/write

Posted by Pierre Morel 3 years ago

By checking the results of errors on SSCH in the kvm-unit-tests
We noticed that no error was reported when a SSCH is started
to access addresses not existing in the guest.
For exemple accessing 3G on a guest with 1G memory.

If we look at QEMU ccw_dstream_write/write functions we see that they
are often not checked for error in various places.
  
It follows that accessing an invalid address does not trigger a
subchannel status program check to the guest as it should.

Regards,
Pierre
 

Pierre Morel (1):
  s390x: css: report errors from ccw_dstream_read/write

 hw/char/terminal3270.c | 11 +++++--
 hw/s390x/3270-ccw.c    |  3 ++
 hw/s390x/css.c         | 16 +++++-----
 hw/s390x/virtio-ccw.c  | 66 ++++++++++++++++++++++++++++++------------
 4 files changed, 69 insertions(+), 27 deletions(-)

-- 
2.17.1