Hexagon (target/hexagon) remove unnecessary semicolons

[PATCH] Hexagon (target/hexagon) remove unnecessary semicolons

Posted by Taylor Simpson 3 years, 1 month ago

Address feedback from Richard Henderson <<richard.henderson@linaro.org>

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
 target/hexagon/gen_tcg.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
index e044dea..a30048e 100644
--- a/target/hexagon/gen_tcg.h
+++ b/target/hexagon/gen_tcg.h
@@ -83,9 +83,9 @@
 #define fGEN_TCG_L2_loadrub_pr(SHORTCODE)      SHORTCODE
 #define fGEN_TCG_L2_loadrub_pi(SHORTCODE)      SHORTCODE
 #define fGEN_TCG_L2_loadrb_pr(SHORTCODE)       SHORTCODE
-#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE;
+#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE
 #define fGEN_TCG_L2_loadruh_pr(SHORTCODE)      SHORTCODE
-#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE;
+#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE
 #define fGEN_TCG_L2_loadrh_pr(SHORTCODE)       SHORTCODE
 #define fGEN_TCG_L2_loadrh_pi(SHORTCODE)       SHORTCODE
 #define fGEN_TCG_L2_loadri_pr(SHORTCODE)       SHORTCODE
-- 
2.7.4

Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons

Posted by Philippe Mathieu-Daudé 3 years, 1 month ago

On 3/15/21 5:55 AM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
> 

Reported-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
>  target/hexagon/gen_tcg.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
> index e044dea..a30048e 100644
> --- a/target/hexagon/gen_tcg.h
> +++ b/target/hexagon/gen_tcg.h
> @@ -83,9 +83,9 @@
>  #define fGEN_TCG_L2_loadrub_pr(SHORTCODE)      SHORTCODE
>  #define fGEN_TCG_L2_loadrub_pi(SHORTCODE)      SHORTCODE
>  #define fGEN_TCG_L2_loadrb_pr(SHORTCODE)       SHORTCODE
> -#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE;
> +#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE
>  #define fGEN_TCG_L2_loadruh_pr(SHORTCODE)      SHORTCODE
> -#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE;
> +#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE
>  #define fGEN_TCG_L2_loadrh_pr(SHORTCODE)       SHORTCODE
>  #define fGEN_TCG_L2_loadrh_pi(SHORTCODE)       SHORTCODE
>  #define fGEN_TCG_L2_loadri_pr(SHORTCODE)       SHORTCODE
>

Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons

Posted by Laurent Vivier 3 years ago

Le 15/03/2021 à 10:43, Philippe Mathieu-Daudé a écrit :
> On 3/15/21 5:55 AM, Taylor Simpson wrote:
>> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
>>
> 
> Reported-by: Richard Henderson <richard.henderson@linaro.org>
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 
>> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
>> ---
>>  target/hexagon/gen_tcg.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/target/hexagon/gen_tcg.h b/target/hexagon/gen_tcg.h
>> index e044dea..a30048e 100644
>> --- a/target/hexagon/gen_tcg.h
>> +++ b/target/hexagon/gen_tcg.h
>> @@ -83,9 +83,9 @@
>>  #define fGEN_TCG_L2_loadrub_pr(SHORTCODE)      SHORTCODE
>>  #define fGEN_TCG_L2_loadrub_pi(SHORTCODE)      SHORTCODE
>>  #define fGEN_TCG_L2_loadrb_pr(SHORTCODE)       SHORTCODE
>> -#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE;
>> +#define fGEN_TCG_L2_loadrb_pi(SHORTCODE)       SHORTCODE
>>  #define fGEN_TCG_L2_loadruh_pr(SHORTCODE)      SHORTCODE
>> -#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE;
>> +#define fGEN_TCG_L2_loadruh_pi(SHORTCODE)      SHORTCODE
>>  #define fGEN_TCG_L2_loadrh_pr(SHORTCODE)       SHORTCODE
>>  #define fGEN_TCG_L2_loadrh_pi(SHORTCODE)       SHORTCODE
>>  #define fGEN_TCG_L2_loadri_pr(SHORTCODE)       SHORTCODE
>>
> 
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [PATCH] Hexagon (target/hexagon) remove unnecessary semicolons

Posted by Richard Henderson 3 years, 1 month ago

On 3/14/21 10:55 PM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
> 
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
>   target/hexagon/gen_tcg.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Queued.


r~