Hexagon (target/hexagon) change DECODE_MAPPED_REG operand name to OPNUM

[PATCH] Hexagon (target/hexagon) change DECODE_MAPPED_REG operand name to OPNUM

Taylor Simpson posted 1 patch 3 years, 1 month ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1615784049-26215-1-git-send-email-tsimpson@quicinc.com

Maintainers: Taylor Simpson <tsimpson@quicinc.com>

target/hexagon/decode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Expand all Fold all

[PATCH] Hexagon (target/hexagon) change DECODE_MAPPED_REG operand name to OPNUM

Posted by Taylor Simpson 3 years, 1 month ago

Address feedback from Richard Henderson <<richard.henderson@linaro.org>

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
 target/hexagon/decode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/hexagon/decode.c b/target/hexagon/decode.c
index c9bacaa..1c9c074 100644
--- a/target/hexagon/decode.c
+++ b/target/hexagon/decode.c
@@ -48,8 +48,8 @@ enum {
 DEF_REGMAP(R_16,  16, 0, 1, 2, 3, 4, 5, 6, 7, 16, 17, 18, 19, 20, 21, 22, 23)
 DEF_REGMAP(R__8,  8,  0, 2, 4, 6, 16, 18, 20, 22)
 
-#define DECODE_MAPPED_REG(REGNO, NAME) \
-    insn->regno[REGNO] = DECODE_REGISTER_##NAME[insn->regno[REGNO]];
+#define DECODE_MAPPED_REG(OPNUM, NAME) \
+    insn->regno[OPNUM] = DECODE_REGISTER_##NAME[insn->regno[OPNUM]];
 
 typedef struct {
     const struct DectreeTable *table_link;
-- 
2.7.4

Re: [PATCH] Hexagon (target/hexagon) change DECODE_MAPPED_REG operand name to OPNUM

Posted by Richard Henderson 3 years, 1 month ago

On 3/14/21 10:54 PM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
> 
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
>   target/hexagon/decode.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)

Queued.


r~