Hexagon (target/hexagon) remove unnecessary checks in find_iclass_slots

[PATCH] Hexagon (target/hexagon) remove unnecessary checks in find_iclass_slots

Taylor Simpson posted 1 patch 3 years, 1 month ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1615784037-26129-1-git-send-email-tsimpson@quicinc.com

Maintainers: Taylor Simpson <tsimpson@quicinc.com>

target/hexagon/iclass.c | 4 ----
1 file changed, 4 deletions(-)

Expand all Fold all

[PATCH] Hexagon (target/hexagon) remove unnecessary checks in find_iclass_slots

Posted by Taylor Simpson 3 years, 1 month ago

Address feedback from Richard Henderson <<richard.henderson@linaro.org>

Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
---
 target/hexagon/iclass.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/target/hexagon/iclass.c b/target/hexagon/iclass.c
index 378d8a6..6091286 100644
--- a/target/hexagon/iclass.c
+++ b/target/hexagon/iclass.c
@@ -53,10 +53,6 @@ SlotMask find_iclass_slots(Opcode opcode, int itype)
                (opcode == Y2_isync) ||
                (opcode == J2_pause) || (opcode == J4_hintjumpr)) {
         return SLOTS_2;
-    } else if ((itype == ICLASS_V2LDST) && (GET_ATTRIB(opcode, A_STORE))) {
-        return SLOTS_01;
-    } else if ((itype == ICLASS_V2LDST) && (!GET_ATTRIB(opcode, A_STORE))) {
-        return SLOTS_01;
     } else if (GET_ATTRIB(opcode, A_CRSLOT23)) {
         return SLOTS_23;
     } else if (GET_ATTRIB(opcode, A_RESTRICT_PREFERSLOT0)) {
-- 
2.7.4

Re: [PATCH] Hexagon (target/hexagon) remove unnecessary checks in find_iclass_slots

Posted by Richard Henderson 3 years, 1 month ago

On 3/14/21 10:53 PM, Taylor Simpson wrote:
> Address feedback from Richard Henderson <<richard.henderson@linaro.org>
> 
> Signed-off-by: Taylor Simpson<tsimpson@quicinc.com>
> ---
>   target/hexagon/iclass.c | 4 ----
>   1 file changed, 4 deletions(-)

Queued.


r~