[v1] net: Fix build error when DEBUG_NET is on

[PATCH] net: Fix build error when DEBUG_NET is on

Bin Meng posted 1 patch 4 years, 8 months ago

Diff against v1
Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1614326161-65017-1-git-send-email-bmeng.cn@gmail.com

Maintainers: Jason Wang <jasowang@redhat.com>

There is a newer version of this series

net/net.c | 1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[PATCH] net: Fix build error when DEBUG_NET is on

Posted by Bin Meng 4 years, 8 months ago

From: Bin Meng <bin.meng@windriver.com>

"qemu-common.h" should be included to provide the forward declaration
of qemu_hexdump() when DEBUG_NET is on.

Signed-off-by: Bin Meng <bin.meng@windriver.com>
---

 net/net.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/net.c b/net/net.c
index fb7b7dc..32d71c1 100644
--- a/net/net.c
+++ b/net/net.c
@@ -23,6 +23,7 @@
  */
 
 #include "qemu/osdep.h"
+#include "qemu-common.h"
 
 #include "net/net.h"
 #include "clients.h"
-- 
2.7.4

Re: [PATCH] net: Fix build error when DEBUG_NET is on

Posted by Philippe Mathieu-Daudé 4 years, 8 months ago

On 2/26/21 8:56 AM, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
> 
> "qemu-common.h" should be included to provide the forward declaration
> of qemu_hexdump() when DEBUG_NET is on.
> 
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
> 
>  net/net.c | 1 +
>  1 file changed, 1 insertion(+)

Similarly:
- hw/net/fsl_etsec/etsec.c
- hw/net/fsl_etsec/rings.c

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>