[v2] css: SCHIB measurement block origin must be aligned

[PATCH v2 0/1] css: SCHIB measurement block origin must be aligned

Pierre Morel posted 1 patch 3 years, 2 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1613741973-3711-1-git-send-email-pmorel@linux.ibm.com

Maintainers: Halil Pasic <pasic@linux.ibm.com>, Christian Borntraeger <borntraeger@de.ibm.com>, David Hildenbrand <david@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Richard Henderson <richard.henderson@linaro.org>, Thomas Huth <thuth@redhat.com>

target/s390x/ioinst.c | 6 ++++++
1 file changed, 6 insertions(+)

Expand all Fold all

[PATCH v2 0/1] css: SCHIB measurement block origin must be aligned

Posted by Pierre Morel 3 years, 2 months ago

Hi,

By testing Measurement with KVM unit tests I fall on this:
we forgot to test the alignment of the MBO for measurement format 1.

The last 6 bits of the MBO must be null, i.e. an aligned on 64 bytes
of the MBO, otherwise an operand exception is recognized when issuing
a msch instruction.

Regards,
Pierre


Pierre Morel (1):
  css: SCHIB measurement block origin must be aligned

 target/s390x/ioinst.c | 6 ++++++
 1 file changed, 6 insertions(+)

-- 
2.25.1

Re: [PATCH v2 0/1] css: SCHIB measurement block origin must be aligned

Posted by Cornelia Huck 3 years, 2 months ago

On Fri, 19 Feb 2021 14:39:32 +0100
Pierre Morel <pmorel@linux.ibm.com> wrote:

> Hi,
> 
> By testing Measurement with KVM unit tests I fall on this:
> we forgot to test the alignment of the MBO for measurement format 1.
> 
> The last 6 bits of the MBO must be null, i.e. an aligned on 64 bytes
> of the MBO, otherwise an operand exception is recognized when issuing
> a msch instruction.
> 
> Regards,
> Pierre
> 
> 
> Pierre Morel (1):
>   css: SCHIB measurement block origin must be aligned
> 
>  target/s390x/ioinst.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 

Thanks, applied.