replay: rng-builtin support

[PATCH] replay: rng-builtin support

Pavel Dovgalyuk posted 1 patch 3 years, 3 months ago

Download mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/161233201286.170686.7858208964037376305.stgit@pasha-ThinkPad-X280

Maintainers: Amit Shah <amit@kernel.org>, Laurent Vivier <lvivier@redhat.com>

backends/rng-builtin.c |    3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

Expand all Fold all

[PATCH] replay: rng-builtin support

Posted by Pavel Dovgalyuk 3 years, 3 months ago

This patch enables using rng-builtin with record/replay
by making the callbacks deterministic.

Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
---
 backends/rng-builtin.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c
index f38dff117d..f367eb665c 100644
--- a/backends/rng-builtin.c
+++ b/backends/rng-builtin.c
@@ -10,6 +10,7 @@
 #include "qemu/main-loop.h"
 #include "qemu/guest-random.h"
 #include "qom/object.h"
+#include "sysemu/replay.h"
 
 OBJECT_DECLARE_SIMPLE_TYPE(RngBuiltin, RNG_BUILTIN)
 
@@ -37,7 +38,7 @@ static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req)
 {
     RngBuiltin *s = RNG_BUILTIN(b);
 
-    qemu_bh_schedule(s->bh);
+    replay_bh_schedule_event(s->bh);
 }
 
 static void rng_builtin_init(Object *obj)

Re: [PATCH] replay: rng-builtin support

Posted by Paolo Bonzini 3 years, 3 months ago

On 03/02/21 07:00, Pavel Dovgalyuk wrote:
> This patch enables using rng-builtin with record/replay
> by making the callbacks deterministic.
> 
> Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgalyuk@ispras.ru>
> ---
>   backends/rng-builtin.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/backends/rng-builtin.c b/backends/rng-builtin.c
> index f38dff117d..f367eb665c 100644
> --- a/backends/rng-builtin.c
> +++ b/backends/rng-builtin.c
> @@ -10,6 +10,7 @@
>   #include "qemu/main-loop.h"
>   #include "qemu/guest-random.h"
>   #include "qom/object.h"
> +#include "sysemu/replay.h"
>   
>   OBJECT_DECLARE_SIMPLE_TYPE(RngBuiltin, RNG_BUILTIN)
>   
> @@ -37,7 +38,7 @@ static void rng_builtin_request_entropy(RngBackend *b, RngRequest *req)
>   {
>       RngBuiltin *s = RNG_BUILTIN(b);
>   
> -    qemu_bh_schedule(s->bh);
> +    replay_bh_schedule_event(s->bh);
>   }
>   
>   static void rng_builtin_init(Object *obj)
> 

Queued, thanks.

Paolo