[PATCH v12 0/4] Introduce Xilinx ZynqMP CAN controller

Vikram Garhwal posted 4 patches 3 years, 5 months ago
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1605728926-352690-1-git-send-email-fnu.vikram@xilinx.com
Maintainers: Vikram Garhwal <fnu.vikram@xilinx.com>, Alistair Francis <alistair@alistair23.me>, Jason Wang <jasowang@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Pavel Pisa <pisa@cmp.felk.cvut.cz>
meson.build                      |    1 +
hw/net/can/trace.h               |    1 +
include/hw/arm/xlnx-zynqmp.h     |    8 +
include/hw/net/xlnx-zynqmp-can.h |   78 +++
hw/arm/xlnx-zcu102.c             |   20 +
hw/arm/xlnx-zynqmp.c             |   34 ++
hw/net/can/xlnx-zynqmp-can.c     | 1161 ++++++++++++++++++++++++++++++++++++++
tests/qtest/xlnx-can-test.c      |  360 ++++++++++++
MAINTAINERS                      |    8 +
hw/Kconfig                       |    1 +
hw/net/can/meson.build           |    1 +
hw/net/can/trace-events          |    9 +
tests/qtest/meson.build          |    1 +
13 files changed, 1683 insertions(+)
create mode 100644 hw/net/can/trace.h
create mode 100644 include/hw/net/xlnx-zynqmp-can.h
create mode 100644 hw/net/can/xlnx-zynqmp-can.c
create mode 100644 tests/qtest/xlnx-can-test.c
create mode 100644 hw/net/can/trace-events
[PATCH v12 0/4] Introduce Xilinx ZynqMP CAN controller
Posted by Vikram Garhwal 3 years, 5 months ago
Changelog:

v11 -> v12:
    Change/add new trace events with relevant debug info.
    Rename val64 to val wherever appropriate.
    Added new error logs.
    Corrected xlnx_zynqmp_can_receive function checks.

v10 -> v11:
    Resending the series with correct cc.
    Replace DB_PRINTS with trace-events.
    Removed unnecessary local variables.
    Added const with tx/rx buffers in qtest.
    Added reviewed-by tags for qtest.

v9 -> v10:
    Rebase the series with the new meson build system.

v8 -> v9:
    Use g_autofree to do automatic cleanup the object_get_canonical_path() used.

v7 -> v8:
    Change CAN controller to keep one canbus per controller.
    Add canbus connections at machine level.
    Remove ctrl_idx from CAN controller.

v6 -> v7:
    Remove '-m 4G' option from xlnx-can-test. This option causes the fail of
    docker-quick@centos7 build test.

v5 -> v6:
    Add ptimer based counter for time stamping on RX messages.
    Fix reset issues.
    Rebase the patches with master latest changes.
    Added reference clock property for CAN ptimer.

v4 -> v5:
    Add XlnxZynqMPCAN controller id to debug messages.
    Drop parameter errp of object_property_add().
    Add formatting related suggestions.

v3 -> v4:
    Correct formatting issues.

v2 -> v3:
    Rectify the build issue.
    Rearrange the patch order.

v1 -> v2:
    Rename the CAN device state and address code style issues.
    Connect the CAN device to Xlnx-ZCU102 board.
    Add maintainer entry.
    Add QTEST for the CAN device.


Vikram Garhwal (4):
  hw/net/can: Introduce Xilinx ZynqMP CAN controller
  xlnx-zynqmp: Connect Xilinx ZynqMP CAN controllers
  tests/qtest: Introduce tests for Xilinx ZynqMP CAN controller
  MAINTAINERS: Add maintainer entry for Xilinx ZynqMP CAN controller

 meson.build                      |    1 +
 hw/net/can/trace.h               |    1 +
 include/hw/arm/xlnx-zynqmp.h     |    8 +
 include/hw/net/xlnx-zynqmp-can.h |   78 +++
 hw/arm/xlnx-zcu102.c             |   20 +
 hw/arm/xlnx-zynqmp.c             |   34 ++
 hw/net/can/xlnx-zynqmp-can.c     | 1161 ++++++++++++++++++++++++++++++++++++++
 tests/qtest/xlnx-can-test.c      |  360 ++++++++++++
 MAINTAINERS                      |    8 +
 hw/Kconfig                       |    1 +
 hw/net/can/meson.build           |    1 +
 hw/net/can/trace-events          |    9 +
 tests/qtest/meson.build          |    1 +
 13 files changed, 1683 insertions(+)
 create mode 100644 hw/net/can/trace.h
 create mode 100644 include/hw/net/xlnx-zynqmp-can.h
 create mode 100644 hw/net/can/xlnx-zynqmp-can.c
 create mode 100644 tests/qtest/xlnx-can-test.c
 create mode 100644 hw/net/can/trace-events

--
2.7.4


Re: [PATCH v12 0/4] Introduce Xilinx ZynqMP CAN controller
Posted by Peter Maydell 3 years, 4 months ago
On Wed, 18 Nov 2020 at 19:48, Vikram Garhwal <fnu.vikram@xilinx.com> wrote:
>
> Changelog:
>
> v11 -> v12:
>     Change/add new trace events with relevant debug info.
>     Rename val64 to val wherever appropriate.
>     Added new error logs.
>     Corrected xlnx_zynqmp_can_receive function checks.

Applied to target-arm.next for 6.0, thanks.

-- PMM