This series adds support for the Hexagon processor with Linux user support

See patch 02/33 Hexagon README for detailed information.

This patch assumes int128_or() is implemented.
https://lists.nongnu.org/archive/html/qemu-devel/2020-10/msg06004.html


Once the series is applied, the Hexagon port will pass "make check-tcg".
The series also includes Hexagon-specific tests in tcg/tests/hexagon.

The series is also available at https://github.com/quic/qemu on branch
small_series_v5.

The final patch in the series adds docker files.  Thanks to Alessandro
Di Federico <ale@rev.ng> and Brian Cain <bcain@quicinc.com> for helping.
The container files will build a Hexagon toolchain from source.
Alternatively, this command will get a pre-built container
    docker pull revng/qemu:debian-hexagon-cross
Ultimately, we'll need someone to install the Hexagon container in the
qemu repository.  In the interim, here are the commands I use.  You'll
have to adjust for your directory location four times.
    cd /home/taylor/qemu
    mkdir build
    cd build
    ../configure --target-list=hexagon-linux-user
    make
    docker run -u $(id -u ${USER}):$(id -g ${USER}) -ti \
        -v /home/taylor:/home/taylor \
        revng/qemu:debian-hexagon-cross
    cd /home/taylor/qemu/build
    make check-tcg CROSS_CC_GUEST=hexagon-unknown-linux-musl-clang


*** Known checkpatch issues ***

The following are known checkpatch errors in the series
    target/hexagon/reg_fields.h         Complex macro
    target/hexagon/attribs.h            Complex macro
    target/hexagon/decode.c             Complex macro
    target/hexagon/q6v_decode.c         Macro needs do - while
    target/hexagon/printinsn.c          Macro needs do - while
    target/hexagon/gen_semantics.c      Suspicious ; after while (0)
    target/hexagon/gen_dectree_import.c Complex macro
    target/hexagon/gen_dectree_import.c Suspicious ; after while (0)
    target/hexagon/opcodes.c            Complex macro
    target/hexagon/iclass.h             Complex macro
    configure.sh                        Line over 90 characters
    scripts/qemu-binfmt-conf.sh         Line over 90 characters

The following are known checkpatch warnings in the series
    target/hexagon/fma_emu.c            Comments inside macro definition
    target/hexagon/gen_tcg_funcs.py     Line over 80 characters
    scripts/qemu-binfmt-conf.sh         Line over 80 characters

*** Changes in v5 ***
Bug fixes
    Properly implement circular addressing
        memw(r1++I:circ(m0)) = r2
    Make gen_cmpnd_cmp_jmp execute in 2 parts

Address remaining blocker items from Richard Henderson's review.
    Use qemu softfloat
    Use const where appropriate
    Break tcg_funcs_generated.h into two files - functions and table
    Change struct and enum type names to CamelCase
    Include packet in raw bytes in assembly
    Use DEF_HELPER_FLAGS where possible
    Fix merge_bytes endianness and overlap test by doing the store before load
    Use bitmask instead of string in decoding
    Add comments to decoder
    Use qemu/int128.h
    Use qemu/bitops.h for instruction attributes
    Add bitmask for ctx->reg_log
        Note we still have the array/idx for iteration during gen_commit_packet
    Change opcode_syntax to be created at compile time in gen_dectree_import.c
    Remove unused tmp variables
    Isolate hex_arch_types to imported files
    Fix git am whitespace warnings

Address items from Philippe Mathieu-Daud�'s review
    Split utility functions patch into 3 digestable patches
    Fixed type "definition"
    Change all exit codes to be either 0 or 1
    Validated build with gcc 4.8, 5.5, and *****
    Removed qemu/osdep.h and qemu/host-utils.h from macros.h

Address items from Laurent Vivier's review
    Don't filter out __NR_syscalls
    Remove syscall_nr_generators from linux-user/hexagon/meson.build
    Remove subdir('hexagon') from linux-user/meson.build
    Generate syscall_nr.h from 5.5 Linux kernel
    

*** Changes in v4 ***
Convert target/hexagon/Makefile.objs to meson.build

Address portions of feedback from Richard Henderson.  Here is the table
of items from Richard's review.
Patch   Item                                                 Blocker Status
        Use qemu softfloat                                   Yes
        Use qemu decodetree.py                               No
Several Use const when appropriate                           Yes
Several Remove anything after g_assert_not_reached           Yes     DONE
Several Fix log_store32/64 add/remove/add in patch series    Yes     DONE
Several Follow naming guidelines for structs and enums       Yes
4       Move decls to cpu-param.h                            Yes     DONE
4       Remove CONFIG_USER_ONLY ifdef's                      Yes     DONE
4       Remove DEBUG_HEXAGON                                 Yes     Partially
4       Remove stack pointer modification hack               Yes     DONE
4       Add property x-lldb-compat to control output         Yes     DONE
6       Include instruction and raw bytes in disassembly     Yes
7       Use DEF_HELPER_FLAGS                                 No
07, 26  Endianness of merge_bytes                            Yes
7       Fix overlap test                                     Yes
7       Remove HELPER(debug_value)/HELPER(debug_value_i64)   Yes     DONE
9       Include "qemu/osdep.h" instead of <stdint.h>         Yes     DONE
Several Stick with stdint.h types except in imported files   Yes     DONE
11      Remove description from reg field definitions        Yes     DONE
13      Move regmap.h into decode.c                          Yes     DONE
14, 27  Use bit mask instead of strings in decoding          No
14      Add comments to decoder                              Yes
16      Use qemu/int128.h                                    No
17      Squash patches dealing with imported files           Yes     DONE
24      Use qemu/bitops.h for instruction attributes         No
24      Fix initialization of opcode_short_semantics         Yes     DONE
24      Change if (p == NULL) { g_assert_not_reached(); }
        to assert(p != NULL)                                 No      DONE
25      Expand DECL/READ/WRITE/FREE macros in generator      Yes     DONE
26      Rewrite fINSERT*, fEXTRACT*, f?XTN macros            Yes     DONE
26      Investigate fRND macro                               No      DONE
26      Change REG = REG to (VOID)REG to suppress warning    Yes     DONE
27      Remove multiple includes of imported/iclass.def      Yes     DONE
28      Move genptr_helpers.h into genptr.c                  Yes     DONE
28      Remove unneeded temps                                No      DONE
28      Use tcg_gen_deposit_tl and tcg_gen_extract_tl
        when dealing with p3_0                               No      DONE
29      Size opcode_genptr[] properly and initialize
        with [TAG] = generate_##TAG                          Yes     DONE
30      Don't generate helpers for overridden instructions   Yes     DONE
        Don't include "gen_tcg.h" in helper.h                Yes     DONE
31      Use bitmask for ctx->reg_log instead of an array     Yes
31      Use tcg_gen_extract_i32 for gen_slot_cancelled_check Yes     DONE
31      Properly deal with reading instructions across
        a page boundary and too many instructions before
        finding end-of-packet                                Yes     DONE
31      Don't set PC at the beginning of every packet        No
31      Don't set slot_cancelled unless needed               No
31      Don't set hex_pred_written unless needed             No
31      Change cancelled variable to not local               Yes     DONE
31      Remove unnecessary temp                              Yes     DONE
31      Let tcg_gen_addi_tl check for zero                   Yes     DONE
31      Move gen_exec_counters to end of TB                  No
31      Move end of TB handling to hexagon_tr_tb_stop        Yes     DONE
        Generate two lists for TCG functions instead of
        the DEF_TCG_FUNC macro                               Yes     DONE


*** Changes in v3 ***
Remove substantial portions of the code to facilitate review
- Plan to submit subsequent patches
- Hexagon Vector eXtensions (HVX)
- Circular and bit-reverse addressiong
- Add/sub-with-carry
- Unused insn_t and pkt_t fields
- Unused instruction attributes
- All TCG overrides except instructions with multiple definitions
- Unused macros
- Unused reg fields
- COUNT_HEX_HELPERS
Use Laurent's gensyscall.sh script to generate linux-user/hexagon/syscall_nr.h
Handle mem_noshuf
Remove "RsV = RsV" per review feedback
Simplify include file structure
Add directed tests in <qemu>/tests/tcg/hexagon
Change fWRAP_* macros to fGEN_TCG_*

*** Changes in v2 ***
- Use scripts/git.orderfile
- Create a README with the code overview in patch 0001
- Change #define's in hex_regs.h to an enum
- Replace hard coded disassembly buffer length (1028) with #define
- Move Hexagon architecture types patch earlier in series
- Replace #include standard header files with #include "qemu/osdep.h"
- Prefix all header file #ifndef's with HEXAGON_
- Update python version to python3
- #include "tcg/tcg.h" in genptr_helpers.h
- Change target/hexagon/Makefile.objs to support out-of-tree build
- Updated copyright to include year 2020
- Bug fixes
    Fix some problems with HEX_DEBUG output
    Fix bug in circular addressing
- Optimizations to reduce the amount of TCG code generated
    Change pred_written from an array to a bit mask


Taylor Simpson (33):
  Hexagon Update MAINTAINERS file
  Hexagon (target/hexagon) README
  Hexagon (include/elf.h) ELF machine definition
  Hexagon (target/hexagon) scalar core definition
  Hexagon (disas) disassembler
  Hexagon (target/hexagon) register names
  Hexagon (target/hexagon) scalar core helpers
  Hexagon (target/hexagon) GDB Stub
  Hexagon (target/hexagon) architecture types
  Hexagon (target/hexagon) instruction and packet types
  Hexagon (target/hexagon) register fields
  Hexagon (target/hexagon) instruction attributes
  Hexagon (target/hexagon) instruction/packet decode
  Hexagon (target/hexagon) instruction printing
  Hexagon (target/hexagon/arch.[ch]) utility functions
  Hexagon (target/hexagon/conv_emu.[ch]) utility functions
  Hexagon (target/hexagon/fma_emu.[ch]) utility functions
  Hexagon (target/hexagon/imported) arch import
  Hexagon (target/hexagon) generator phase 1 - C preprocessor for
    semantics
  Hexagon (target/hexagon) generator phase 2 - generate header files
  Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode
    tree
  Hexagon (target/hexagon) generater phase 4 - decode tree
  Hexagon (target/hexagon) opcode data structures
  Hexagon (target/hexagon) macros
  Hexagon (target/hexagon) instruction classes
  Hexagon (target/hexagon) TCG generation
  Hexagon (target/hexagon) TCG for instructions with multiple
    definitions
  Hexagon (target/hexagon) TCG for floating point instructions
  Hexagon (target/hexagon) translation
  Hexagon (linux-user/hexagon) Linux user emulation
  Hexagon (tests/tcg/hexagon) TCG tests
  Hexagon build infrastructure
  Add Dockerfile for hexagon

 default-configs/targets/hexagon-linux-user.mak     |    1 +
 meson.build                                        |    1 +
 include/disas/dis-asm.h                            |    1 +
 include/elf.h                                      |    1 +
 linux-user/hexagon/sockbits.h                      |   18 +
 linux-user/hexagon/syscall_nr.h                    |  322 +++
 linux-user/hexagon/target_cpu.h                    |   44 +
 linux-user/hexagon/target_elf.h                    |   40 +
 linux-user/hexagon/target_fcntl.h                  |   18 +
 linux-user/hexagon/target_signal.h                 |   34 +
 linux-user/hexagon/target_structs.h                |   46 +
 linux-user/hexagon/target_syscall.h                |   36 +
 linux-user/hexagon/termbits.h                      |   18 +
 linux-user/qemu.h                                  |    2 +
 linux-user/syscall_defs.h                          |   33 +
 target/hexagon/arch.h                              |   35 +
 target/hexagon/attribs.h                           |   30 +
 target/hexagon/attribs_def.h                       |   97 +
 target/hexagon/conv_emu.h                          |   31 +
 target/hexagon/cpu-param.h                         |   29 +
 target/hexagon/cpu.h                               |  159 ++
 target/hexagon/cpu_bits.h                          |   59 +
 target/hexagon/decode.h                            |   32 +
 target/hexagon/fma_emu.h                           |   32 +
 target/hexagon/gen_tcg.h                           |  319 +++
 target/hexagon/genptr.h                            |   25 +
 target/hexagon/helper.h                            |   85 +
 target/hexagon/hex_arch_types.h                    |   38 +
 target/hexagon/hex_regs.h                          |   83 +
 target/hexagon/iclass.h                            |   50 +
 target/hexagon/insn.h                              |   74 +
 target/hexagon/internal.h                          |   39 +
 target/hexagon/macros.h                            |  591 ++++++
 target/hexagon/opcodes.h                           |   63 +
 target/hexagon/printinsn.h                         |   28 +
 target/hexagon/reg_fields.h                        |   36 +
 target/hexagon/reg_fields_def.h                    |   41 +
 target/hexagon/translate.h                         |   85 +
 disas/hexagon.c                                    |   68 +
 linux-user/elfload.c                               |   16 +
 linux-user/hexagon/cpu_loop.c                      |   99 +
 linux-user/hexagon/signal.c                        |  276 +++
 target/hexagon/arch.c                              |  294 +++
 target/hexagon/conv_emu.c                          |  177 ++
 target/hexagon/cpu.c                               |  314 +++
 target/hexagon/decode.c                            |  581 ++++++
 target/hexagon/fma_emu.c                           |  706 +++++++
 target/hexagon/gdbstub.c                           |   47 +
 target/hexagon/gen_dectree_import.c                |  187 ++
 target/hexagon/gen_semantics.c                     |   88 +
 target/hexagon/genptr.c                            |  234 +++
 target/hexagon/iclass.c                            |   73 +
 target/hexagon/op_helper.c                         |  971 +++++++++
 target/hexagon/opcodes.c                           |  142 ++
 target/hexagon/printinsn.c                         |  158 ++
 target/hexagon/q6v_decode.c                        |  385 ++++
 target/hexagon/reg_fields.c                        |   27 +
 target/hexagon/translate.c                         |  687 +++++++
 tests/tcg/hexagon/atomics.c                        |  122 ++
 tests/tcg/hexagon/clrtnew.c                        |   56 +
 tests/tcg/hexagon/dual_stores.c                    |   60 +
 tests/tcg/hexagon/mem_noshuf.c                     |  291 +++
 tests/tcg/hexagon/misc.c                           |  293 +++
 tests/tcg/hexagon/preg_alias.c                     |  106 +
 tests/tcg/hexagon/pthread_cancel.c                 |   43 +
 tests/tcg/hexagon/sfminmax.c                       |   62 +
 MAINTAINERS                                        |    8 +
 disas/meson.build                                  |    1 +
 scripts/gensyscalls.sh                             |    1 +
 scripts/qemu-binfmt-conf.sh                        |    6 +-
 target/hexagon/README                              |  235 +++
 target/hexagon/dectree.py                          |  352 ++++
 target/hexagon/gen_helper_funcs.py                 |  229 +++
 target/hexagon/gen_helper_protos.py                |  158 ++
 target/hexagon/gen_op_attribs.py                   |   46 +
 target/hexagon/gen_op_regs.py                      |  119 ++
 target/hexagon/gen_opcodes_def.py                  |   43 +
 target/hexagon/gen_printinsn.py                    |  185 ++
 target/hexagon/gen_shortcode.py                    |   71 +
 target/hexagon/gen_tcg_func_table.py               |   66 +
 target/hexagon/gen_tcg_funcs.py                    |  538 +++++
 target/hexagon/hex_common.py                       |  216 ++
 target/hexagon/imported/allidefs.def               |   30 +
 target/hexagon/imported/alu.idef                   | 1258 ++++++++++++
 target/hexagon/imported/branch.idef                |  326 +++
 target/hexagon/imported/compare.idef               |  619 ++++++
 target/hexagon/imported/encode.def                 |  124 ++
 target/hexagon/imported/encode_pp.def              | 2110 ++++++++++++++++++++
 target/hexagon/imported/encode_subinsn.def         |  149 ++
 target/hexagon/imported/float.idef                 |  312 +++
 target/hexagon/imported/iclass.def                 |   51 +
 target/hexagon/imported/ldst.idef                  |  286 +++
 target/hexagon/imported/macros.def                 | 1526 ++++++++++++++
 target/hexagon/imported/mpy.idef                   | 1208 +++++++++++
 target/hexagon/imported/shift.idef                 | 1066 ++++++++++
 target/hexagon/imported/subinsns.idef              |  149 ++
 target/hexagon/imported/system.idef                |   65 +
 target/hexagon/meson.build                         |  178 ++
 target/meson.build                                 |    1 +
 .../debian-hexagon-cross.build-toolchain.sh        |  141 ++
 .../docker/dockerfiles/debian-hexagon-cross.docker |   18 +
 tests/tcg/configure.sh                             |    4 +-
 tests/tcg/hexagon/Makefile.target                  |   48 +
 tests/tcg/hexagon/first.S                          |   56 +
 tests/tcg/hexagon/float_convs.ref                  |  748 +++++++
 tests/tcg/hexagon/float_madds.ref                  |  768 +++++++
 106 files changed, 22752 insertions(+), 2 deletions(-)
 create mode 100644 default-configs/targets/hexagon-linux-user.mak
 create mode 100644 linux-user/hexagon/sockbits.h
 create mode 100644 linux-user/hexagon/syscall_nr.h
 create mode 100644 linux-user/hexagon/target_cpu.h
 create mode 100644 linux-user/hexagon/target_elf.h
 create mode 100644 linux-user/hexagon/target_fcntl.h
 create mode 100644 linux-user/hexagon/target_signal.h
 create mode 100644 linux-user/hexagon/target_structs.h
 create mode 100644 linux-user/hexagon/target_syscall.h
 create mode 100644 linux-user/hexagon/termbits.h
 create mode 100644 target/hexagon/arch.h
 create mode 100644 target/hexagon/attribs.h
 create mode 100644 target/hexagon/attribs_def.h
 create mode 100644 target/hexagon/conv_emu.h
 create mode 100644 target/hexagon/cpu-param.h
 create mode 100644 target/hexagon/cpu.h
 create mode 100644 target/hexagon/cpu_bits.h
 create mode 100644 target/hexagon/decode.h
 create mode 100644 target/hexagon/fma_emu.h
 create mode 100644 target/hexagon/gen_tcg.h
 create mode 100644 target/hexagon/genptr.h
 create mode 100644 target/hexagon/helper.h
 create mode 100644 target/hexagon/hex_arch_types.h
 create mode 100644 target/hexagon/hex_regs.h
 create mode 100644 target/hexagon/iclass.h
 create mode 100644 target/hexagon/insn.h
 create mode 100644 target/hexagon/internal.h
 create mode 100644 target/hexagon/macros.h
 create mode 100644 target/hexagon/opcodes.h
 create mode 100644 target/hexagon/printinsn.h
 create mode 100644 target/hexagon/reg_fields.h
 create mode 100644 target/hexagon/reg_fields_def.h
 create mode 100644 target/hexagon/translate.h
 create mode 100644 disas/hexagon.c
 create mode 100644 linux-user/hexagon/cpu_loop.c
 create mode 100644 linux-user/hexagon/signal.c
 create mode 100644 target/hexagon/arch.c
 create mode 100644 target/hexagon/conv_emu.c
 create mode 100644 target/hexagon/cpu.c
 create mode 100644 target/hexagon/decode.c
 create mode 100644 target/hexagon/fma_emu.c
 create mode 100644 target/hexagon/gdbstub.c
 create mode 100644 target/hexagon/gen_dectree_import.c
 create mode 100644 target/hexagon/gen_semantics.c
 create mode 100644 target/hexagon/genptr.c
 create mode 100644 target/hexagon/iclass.c
 create mode 100644 target/hexagon/op_helper.c
 create mode 100644 target/hexagon/opcodes.c
 create mode 100644 target/hexagon/printinsn.c
 create mode 100644 target/hexagon/q6v_decode.c
 create mode 100644 target/hexagon/reg_fields.c
 create mode 100644 target/hexagon/translate.c
 create mode 100644 tests/tcg/hexagon/atomics.c
 create mode 100644 tests/tcg/hexagon/clrtnew.c
 create mode 100644 tests/tcg/hexagon/dual_stores.c
 create mode 100644 tests/tcg/hexagon/mem_noshuf.c
 create mode 100644 tests/tcg/hexagon/misc.c
 create mode 100644 tests/tcg/hexagon/preg_alias.c
 create mode 100644 tests/tcg/hexagon/pthread_cancel.c
 create mode 100644 tests/tcg/hexagon/sfminmax.c
 create mode 100644 target/hexagon/README
 create mode 100755 target/hexagon/dectree.py
 create mode 100755 target/hexagon/gen_helper_funcs.py
 create mode 100755 target/hexagon/gen_helper_protos.py
 create mode 100755 target/hexagon/gen_op_attribs.py
 create mode 100755 target/hexagon/gen_op_regs.py
 create mode 100755 target/hexagon/gen_opcodes_def.py
 create mode 100755 target/hexagon/gen_printinsn.py
 create mode 100755 target/hexagon/gen_shortcode.py
 create mode 100755 target/hexagon/gen_tcg_func_table.py
 create mode 100755 target/hexagon/gen_tcg_funcs.py
 create mode 100755 target/hexagon/hex_common.py
 create mode 100644 target/hexagon/imported/allidefs.def
 create mode 100644 target/hexagon/imported/alu.idef
 create mode 100644 target/hexagon/imported/branch.idef
 create mode 100644 target/hexagon/imported/compare.idef
 create mode 100644 target/hexagon/imported/encode.def
 create mode 100644 target/hexagon/imported/encode_pp.def
 create mode 100644 target/hexagon/imported/encode_subinsn.def
 create mode 100644 target/hexagon/imported/float.idef
 create mode 100644 target/hexagon/imported/iclass.def
 create mode 100644 target/hexagon/imported/ldst.idef
 create mode 100755 target/hexagon/imported/macros.def
 create mode 100644 target/hexagon/imported/mpy.idef
 create mode 100644 target/hexagon/imported/shift.idef
 create mode 100644 target/hexagon/imported/subinsns.idef
 create mode 100644 target/hexagon/imported/system.idef
 create mode 100644 target/hexagon/meson.build
 create mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh
 create mode 100644 tests/docker/dockerfiles/debian-hexagon-cross.docker
 create mode 100644 tests/tcg/hexagon/Makefile.target
 create mode 100644 tests/tcg/hexagon/first.S
 create mode 100644 tests/tcg/hexagon/float_convs.ref
 create mode 100644 tests/tcg/hexagon/float_madds.ref

-- 
2.7.4

Patchew URL: https://patchew.org/QEMU/1604016519-28065-1-git-send-email-tsimpson@quicinc.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1604016519-28065-1-git-send-email-tsimpson@quicinc.com
Subject: [RFC PATCH v5 00/33] Hexagon patch series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/1604016519-28065-1-git-send-email-tsimpson@quicinc.com -> patchew/1604016519-28065-1-git-send-email-tsimpson@quicinc.com
Switched to a new branch 'test'
0c330fa Add Dockerfile for hexagon
d85cf6f Hexagon build infrastructure
3af1dde Hexagon (tests/tcg/hexagon) TCG tests
fa9a5dd Hexagon (linux-user/hexagon) Linux user emulation
5176cb3 Hexagon (target/hexagon) translation
274dd27 Hexagon (target/hexagon) TCG for floating point instructions
b802cba Hexagon (target/hexagon) TCG for instructions with multiple definitions
dcc2a90 Hexagon (target/hexagon) TCG generation
576f1cc Hexagon (target/hexagon) instruction classes
452b826 Hexagon (target/hexagon) macros
0a133bf Hexagon (target/hexagon) opcode data structures
767ce35 Hexagon (target/hexagon) generater phase 4 - decode tree
e217e1c Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree
a776029 Hexagon (target/hexagon) generator phase 2 - generate header files
f7fce74 Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics
bd3fbea Hexagon (target/hexagon/imported) arch import
b0ec0c4 Hexagon (target/hexagon/fma_emu.[ch]) utility functions
71d3179 Hexagon (target/hexagon/conv_emu.[ch]) utility functions
4a2fc1e Hexagon (target/hexagon/arch.[ch]) utility functions
30e1f51 Hexagon (target/hexagon) instruction printing
7811188 Hexagon (target/hexagon) instruction/packet decode
14c10b4 Hexagon (target/hexagon) instruction attributes
04f03bb Hexagon (target/hexagon) register fields
d374a01 Hexagon (target/hexagon) instruction and packet types
797f862 Hexagon (target/hexagon) architecture types
f96acbe Hexagon (target/hexagon) GDB Stub
6e52390 Hexagon (target/hexagon) scalar core helpers
46e63e5 Hexagon (target/hexagon) register names
7ae71bf Hexagon (disas) disassembler
08fba28 Hexagon (target/hexagon) scalar core definition
efd74e2 Hexagon (include/elf.h) ELF machine definition
5771cf0 Hexagon (target/hexagon) README
bbfeea5 Hexagon Update MAINTAINERS file

=== OUTPUT BEGIN ===
1/33 Checking commit bbfeea5304db (Hexagon Update MAINTAINERS file)
2/33 Checking commit 5771cf011159 (Hexagon (target/hexagon) README)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 235 lines checked

Patch 2/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/33 Checking commit efd74e2de913 (Hexagon (include/elf.h) ELF machine definition)
4/33 Checking commit 08fba2813f35 (Hexagon (target/hexagon) scalar core definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 595 lines checked

Patch 4/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/33 Checking commit 7ae71bf8e6ef (Hexagon (disas) disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 82 lines checked

Patch 5/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/33 Checking commit 46e63e56e7be (Hexagon (target/hexagon) register names)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 6/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/33 Checking commit 6e523900586c (Hexagon (target/hexagon) scalar core helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 1056 lines checked

Patch 7/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/33 Checking commit f96acbef0e83 (Hexagon (target/hexagon) GDB Stub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 64 lines checked

Patch 8/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/33 Checking commit 797f8625e65a (Hexagon (target/hexagon) architecture types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 38 lines checked

Patch 9/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/33 Checking commit d374a0111f36 (Hexagon (target/hexagon) instruction and packet types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 10/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/33 Checking commit 04f03bbe0c5d (Hexagon (target/hexagon) register fields)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#79: FILE: target/hexagon/reg_fields.h:29:
+#define DEF_REG_FIELD(TAG, START, WIDTH) \
+    TAG,

total: 1 errors, 1 warnings, 104 lines checked

Patch 11/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/33 Checking commit 14c10b46b3fd (Hexagon (target/hexagon) instruction attributes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#37: FILE: target/hexagon/attribs.h:22:
+#define DEF_ATTRIB(NAME, ...) A_##NAME,

total: 1 errors, 1 warnings, 127 lines checked

Patch 12/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/33 Checking commit 781118869953 (Hexagon (target/hexagon) instruction/packet decode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#127: FILE: target/hexagon/decode.c:101:
+#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#702: FILE: target/hexagon/q6v_decode.c:51:
+#define DECODE_OPINFO(TAG, BEH) \
+    case TAG: \
+        { BEH  } \
+        break; \
+

total: 2 errors, 1 warnings, 998 lines checked

Patch 13/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/33 Checking commit 30e1f510513b (Hexagon (target/hexagon) instruction printing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#58: FILE: target/hexagon/printinsn.c:43:
+#define DEF_PRINTINFO(TAG, FMT, ...) \
+    case TAG: \
+        snprintf(buf, n, FMT, __VA_ARGS__);\
+        break;

total: 1 errors, 1 warnings, 186 lines checked

Patch 14/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/33 Checking commit 4a2fc1e6d19e (Hexagon (target/hexagon/arch.[ch]) utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 329 lines checked

Patch 15/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/33 Checking commit 71d317960f08 (Hexagon (target/hexagon/conv_emu.[ch]) utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

total: 0 errors, 1 warnings, 208 lines checked

Patch 16/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/33 Checking commit b0ec0c424f02 (Hexagon (target/hexagon/fma_emu.[ch]) utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: "foo * bar" should be "foo *bar"
#407: FILE: target/hexagon/fma_emu.c:392:
+static inline SUFFIX accum_round_##SUFFIX(Accum a, float_status * fp_status) \

WARNING: Block comments use a leading /* on a separate line
#411: FILE: target/hexagon/fma_emu.c:396:
+        /* result zero */ \

WARNING: Block comments use a leading /* on a separate line
#419: FILE: target/hexagon/fma_emu.c:404:
+    /* Normalize right */ \

WARNING: Block comments use a leading /* on a separate line
#420: FILE: target/hexagon/fma_emu.c:405:
+    /* We want MANTBITS bits of mantissa plus the leading one. */ \

WARNING: Block comments use a leading /* on a separate line
#421: FILE: target/hexagon/fma_emu.c:406:
+    /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \

WARNING: Block comments use a leading /* on a separate line
#422: FILE: target/hexagon/fma_emu.c:407:
+    /* So we need to normalize right while the high word is non-zero and \

WARNING: Block comments should align the * on each line
#423: FILE: target/hexagon/fma_emu.c:408:
+    /* So we need to normalize right while the high word is non-zero and \
+    * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \

WARNING: Block comments use a leading /* on a separate line
#428: FILE: target/hexagon/fma_emu.c:413:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#438: FILE: target/hexagon/fma_emu.c:423:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#445: FILE: target/hexagon/fma_emu.c:430:
+        /* \

WARNING: Block comments use a leading /* on a separate line
#454: FILE: target/hexagon/fma_emu.c:439:
+    /* OK, we're relatively canonical... now we need to round */ \

WARNING: Block comments use a leading /* on a separate line
#459: FILE: target/hexagon/fma_emu.c:444:
+            /* Chop and we're done */ \

WARNING: Block comments use a leading /* on a separate line
#473: FILE: target/hexagon/fma_emu.c:458:
+                /* round up if guard is 1, down if guard is zero */ \

WARNING: Block comments use a leading /* on a separate line
#476: FILE: target/hexagon/fma_emu.c:461:
+                /* exactly .5, round up if odd */ \

WARNING: Block comments use a leading /* on a separate line
#482: FILE: target/hexagon/fma_emu.c:467:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#491: FILE: target/hexagon/fma_emu.c:476:
+    /* Overflow? */ \

WARNING: Block comments use a leading /* on a separate line
#493: FILE: target/hexagon/fma_emu.c:478:
+        /* Yep, inf result */ \

WARNING: Block comments use a leading /* on a separate line
#515: FILE: target/hexagon/fma_emu.c:500:
+    /* Underflow? */ \

WARNING: Block comments use a leading /* on a separate line
#517: FILE: target/hexagon/fma_emu.c:502:
+        /* Leading one means: No, we're normal. So, we should be done... */ \

total: 1 errors, 19 warnings, 738 lines checked

Patch 17/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/33 Checking commit bd3fbea41879 (Hexagon (target/hexagon/imported) arch import)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 9228 lines checked

Patch 18/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/33 Checking commit f7fce7417850 (Hexagon (target/hexagon) generator phase 1 - C preprocessor for semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

ERROR: suspicious ; after while (0)
#83: FILE: target/hexagon/gen_semantics.c:61:
+    } while (0);

total: 1 errors, 1 warnings, 88 lines checked

Patch 19/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/33 Checking commit a776029865b0 (Hexagon (target/hexagon) generator phase 2 - generate header files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100755

WARNING: line over 80 characters
#1052: FILE: target/hexagon/gen_tcg_funcs.py:51:
+        f.write("        tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s + 1]);\n" % \

WARNING: line over 80 characters
#1131: FILE: target/hexagon/gen_tcg_funcs.py:130:
+            f.write("    TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n" % \

WARNING: line over 80 characters
#1216: FILE: target/hexagon/gen_tcg_funcs.py:215:
+            f.write("                                 hex_gpr[%s%sN + 1]);\n" % \

WARNING: line over 80 characters
#1237: FILE: target/hexagon/gen_tcg_funcs.py:236:
+            f.write("                                     hex_gpr[%s%sN + 1]);\n" % \

WARNING: line over 80 characters
#1241: FILE: target/hexagon/gen_tcg_funcs.py:240:
+            f.write("        tcg_gen_concat_i32_i64(%s%sV, hex_gpr[%s%sN],\n" % \

WARNING: line over 80 characters
#1243: FILE: target/hexagon/gen_tcg_funcs.py:242:
+            f.write("                                     hex_gpr[%s%sN + 1]);\n" % \

WARNING: line over 80 characters
#1252: FILE: target/hexagon/gen_tcg_funcs.py:251:
+            f.write("        tcg_gen_mov_tl(%s%sV, hex_gpr[%s%sN + HEX_REG_SA0]);\n" % \

WARNING: line over 80 characters
#1312: FILE: target/hexagon/gen_tcg_funcs.py:311:
+        f.write("    gen_log_predicated_reg_write_pair(%s%sN, %s%sV, insn->slot);\n" % \

WARNING: line over 80 characters
#1356: FILE: target/hexagon/gen_tcg_funcs.py:355:
+            f.write("        gen_log_reg_write(%s%sN + HEX_REG_SA0 + 1, val32);\n" % \

WARNING: line over 80 characters
#1359: FILE: target/hexagon/gen_tcg_funcs.py:358:
+            f.write("        ctx_log_reg_write(ctx, %s%sN + HEX_REG_SA0 + 1);\n" % \

WARNING: line over 80 characters
#1362: FILE: target/hexagon/gen_tcg_funcs.py:361:
+            f.write("        gen_log_reg_write_pair(%s%sN + HEX_REG_SA0, %s%sV);\n" % \

WARNING: line over 80 characters
#1366: FILE: target/hexagon/gen_tcg_funcs.py:365:
+            f.write("        ctx_log_reg_write(ctx, %s%sN + HEX_REG_SA0 + 1);\n" % \

WARNING: line over 80 characters
#1375: FILE: target/hexagon/gen_tcg_funcs.py:374:
+            f.write("        gen_log_reg_write(%s%sN + HEX_REG_SA0, %s%sV);\n" % \

total: 0 errors, 14 warnings, 1671 lines checked

Patch 20/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/33 Checking commit e217e1c6acec (Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#16: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#64: FILE: target/hexagon/gen_dectree_import.c:44:
+#define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+   [TAG] = BEH,

ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target/hexagon/gen_dectree_import.c:46:
+#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+   [TAG] = BEH,

ERROR: Macros with complex values should be enclosed in parenthesis
#74: FILE: target/hexagon/gen_dectree_import.c:54:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#83: FILE: target/hexagon/gen_dectree_import.c:63:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: suspicious ; after while (0)
#180: FILE: target/hexagon/gen_dectree_import.c:160:
+    } while (0);

total: 5 errors, 1 warnings, 187 lines checked

Patch 21/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/33 Checking commit 767ce3526d02 (Hexagon (target/hexagon) generater phase 4 - decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100755

total: 0 errors, 1 warnings, 352 lines checked

Patch 22/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/33 Checking commit 0a133bfbc278 (Hexagon (target/hexagon) opcode data structures)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: target/hexagon/opcodes.c:41:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO,

ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target/hexagon/opcodes.c:51:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: target/hexagon/opcodes.c:61:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: target/hexagon/opcodes.c:69:
+#define DEF_SHORTCODE(TAG, SHORTCODE)              [TAG] = #SHORTCODE,

ERROR: Macros with complex values should be enclosed in parenthesis
#123: FILE: target/hexagon/opcodes.c:108:
+#define ATTRIBS(...) , ## __VA_ARGS__, 0

total: 5 errors, 1 warnings, 205 lines checked

Patch 23/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/33 Checking commit 452b826623e6 (Hexagon (target/hexagon) macros)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 591 lines checked

Patch 24/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/33 Checking commit 576f1ccc3f84 (Hexagon (target/hexagon) instruction classes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#40: FILE: target/hexagon/iclass.c:23:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS) \
+    [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,

ERROR: Macros with complex values should be enclosed in parenthesis
#42: FILE: target/hexagon/iclass.c:25:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS) \
+    [ICLASS_FROM_TYPE(TYPE)] = SLOTS_##SLOTS,

ERROR: Macros with complex values should be enclosed in parenthesis
#123: FILE: target/hexagon/iclass.h:27:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

ERROR: Macros with complex values should be enclosed in parenthesis
#124: FILE: target/hexagon/iclass.h:28:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

total: 4 errors, 1 warnings, 174 lines checked

Patch 25/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

26/33 Checking commit dcc2a90bd4ef (Hexagon (target/hexagon) TCG generation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 259 lines checked

Patch 26/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/33 Checking commit b802cba99f63 (Hexagon (target/hexagon) TCG for instructions with multiple definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 198 lines checked

Patch 27/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/33 Checking commit 274dd275a2f0 (Hexagon (target/hexagon) TCG for floating point instructions)
29/33 Checking commit 5176cb355395 (Hexagon (target/hexagon) translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 772 lines checked

Patch 29/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
30/33 Checking commit fa9a5ddfd6b1 (Hexagon (linux-user/hexagon) Linux user emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead
#122: FILE: linux-user/hexagon/cpu_loop.c:76:
+            EXCP_DUMP(env, "\nqemu: unhandled CPU exception %#x - aborting\n",

total: 1 errors, 1 warnings, 1031 lines checked

Patch 30/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

31/33 Checking commit 3af1ddeaf13f (Hexagon (tests/tcg/hexagon) TCG tests)
WARNING: line over 80 characters
#23: FILE: tests/tcg/configure.sh:73:
+: ${cross_cc_cflags_hexagon="-mv67 -O2 --static -Wno-incompatible-pointer-types"}

ERROR: line over 90 characters
#32: FILE: tests/tcg/configure.sh:99:
+    alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64)

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 1 errors, 2 warnings, 2669 lines checked

Patch 31/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

32/33 Checking commit d85cf6f21417 (Hexagon build infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#21: 
new file mode 100644

WARNING: line over 80 characters
#56: FILE: scripts/qemu-binfmt-conf.sh:139:
+hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00'

ERROR: line over 90 characters
#57: FILE: scripts/qemu-binfmt-conf.sh:140:
+hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 1 errors, 2 warnings, 211 lines checked

Patch 32/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

33/33 Checking commit 0c330fa46008 (Add Dockerfile for hexagon)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100755

WARNING: line over 80 characters
#79: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:63:
+    -DCMAKE_ASM_FLAGS="-G0 -mlong-calls -fno-pic --target=hexagon-unknown-linux-musl " \

ERROR: line over 90 characters
#106: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:90:
+    CROSS_CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \

ERROR: line over 90 characters
#143: FILE: tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh:127:
+    CFLAGS="-G0 -O0 -mv65 -fno-builtin -fno-rounding-math --target=hexagon-unknown-linux-musl" \

total: 2 errors, 2 warnings, 159 lines checked

Patch 33/33 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1604016519-28065-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com