[v2] tests/9pfs: Code refactoring

[PATCH v2 0/5] tests/9pfs: Code refactoring

Greg Kurz posted 5 patches 3 years, 6 months ago

Diff against v1
Download series mbox

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/160320977352.266767.5622969302437522296.stgit@bahia.lan

Maintainers: Greg Kurz <groug@kaod.org>, Paolo Bonzini <pbonzini@redhat.com>, Laurent Vivier <lvivier@redhat.com>, Thomas Huth <thuth@redhat.com>, Christian Schoenebeck <qemu_oss@crudebyte.com>

tests/qtest/virtio-9p-test.c |   62 +++++++++++++++++++++++-------------------
1 file changed, 34 insertions(+), 28 deletions(-)

Expand all Fold all

[PATCH v2 0/5] tests/9pfs: Code refactoring

Posted by Greg Kurz 3 years, 6 months ago

Some code refactoring to have a clear distinction between top level
test functions and helper functions.

v2: - use "do_" prefix instead of "do_fs_"

---

Greg Kurz (5):
      tests/9pfs: Factor out do_version() helper
      tests/9pfs: Turn fs_readdir_split() into a helper
      tests/9pfs: Set alloc in fs_create_dir()
      tests/9pfs: Factor out do_attach() helper
      tests/9pfs: Turn fs_mkdir() into a helper


 tests/qtest/virtio-9p-test.c |   62 +++++++++++++++++++++++-------------------
 1 file changed, 34 insertions(+), 28 deletions(-)

--
Greg

Re: [PATCH v2 0/5] tests/9pfs: Code refactoring

Posted by Christian Schoenebeck 3 years, 6 months ago

On Dienstag, 20. Oktober 2020 18:09:07 CEST Greg Kurz wrote:
> Some code refactoring to have a clear distinction between top level
> test functions and helper functions.
> 
> v2: - use "do_" prefix instead of "do_fs_"
> 
> ---
> 
> Greg Kurz (5):
>       tests/9pfs: Factor out do_version() helper
>       tests/9pfs: Turn fs_readdir_split() into a helper
>       tests/9pfs: Set alloc in fs_create_dir()
>       tests/9pfs: Factor out do_attach() helper
>       tests/9pfs: Turn fs_mkdir() into a helper
> 
> 
>  tests/qtest/virtio-9p-test.c |   62
> +++++++++++++++++++++++------------------- 1 file changed, 34
> insertions(+), 28 deletions(-)
> 
> --
> Greg

Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next

I just tweaked the order of the patches to prevent intermediate compiler 
errors.

Thanks!

Best regards,
Christian Schoenebeck

Re: [PATCH v2 0/5] tests/9pfs: Code refactoring

Posted by Greg Kurz 3 years, 6 months ago

On Tue, 20 Oct 2020 19:23:19 +0200
Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:

> On Dienstag, 20. Oktober 2020 18:09:07 CEST Greg Kurz wrote:
> > Some code refactoring to have a clear distinction between top level
> > test functions and helper functions.
> > 
> > v2: - use "do_" prefix instead of "do_fs_"
> > 
> > ---
> > 
> > Greg Kurz (5):
> >       tests/9pfs: Factor out do_version() helper
> >       tests/9pfs: Turn fs_readdir_split() into a helper
> >       tests/9pfs: Set alloc in fs_create_dir()
> >       tests/9pfs: Factor out do_attach() helper
> >       tests/9pfs: Turn fs_mkdir() into a helper
> > 
> > 
> >  tests/qtest/virtio-9p-test.c |   62
> > +++++++++++++++++++++++------------------- 1 file changed, 34
> > insertions(+), 28 deletions(-)
> > 
> > --
> > Greg
> 
> Queued on 9p.next:
> https://github.com/cschoenebeck/qemu/commits/9p.next
> 
> I just tweaked the order of the patches to prevent intermediate compiler 
> errors.
> 

Oops, sorry... thanks ! :)

> Thanks!
> 
> Best regards,
> Christian Schoenebeck
> 
>