[PATCH v1 0/8] Fix some style problems in migration

Bihong Yu posted 8 patches 3 years, 6 months ago
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com
Maintainers: Fam Zheng <fam@euphon.net>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
There is a newer version of this series
migration/block.c        |  4 ++--
migration/migration.c    |  4 ++--
migration/migration.h    |  3 +--
migration/postcopy-ram.c |  2 +-
migration/ram.c          | 14 ++++++++------
migration/rdma.c         |  7 ++++---
migration/savevm.c       |  4 ++--
migration/vmstate.c      | 10 +++++-----
8 files changed, 25 insertions(+), 23 deletions(-)
[PATCH v1 0/8] Fix some style problems in migration
Posted by Bihong Yu 3 years, 6 months ago
Recently I am reading migration related code, find some style problems in
migration directory while using checkpatch.pl to check migration code. Fix the
error style problems.

Bihong Yu (8):
  migration: Do not use C99 // comments
  migration: Don't use '#' flag of printf format
  migration: Add spaces around operator
  migration: Open brace '{' following struct go on the same line
  migration: Add braces {} for if statement
  migration: Do not initialise statics and globals to 0 or NULL
  migration: Open brace '{' following function declarations go on the
    next line
  migration: Delete redundant spaces

 migration/block.c        |  4 ++--
 migration/migration.c    |  4 ++--
 migration/migration.h    |  3 +--
 migration/postcopy-ram.c |  2 +-
 migration/ram.c          | 14 ++++++++------
 migration/rdma.c         |  7 ++++---
 migration/savevm.c       |  4 ++--
 migration/vmstate.c      | 10 +++++-----
 8 files changed, 25 insertions(+), 23 deletions(-)

-- 
1.8.3.1


Re: [PATCH v1 0/8] Fix some style problems in migration
Posted by no-reply@patchew.org 3 years, 6 months ago
Patchew URL: https://patchew.org/QEMU/1602411429-12043-1-git-send-email-yubihong@huawei.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1602411429-12043-1-git-send-email-yubihong@huawei.com
Subject: [PATCH v1 0/8] Fix some style problems in migration

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   4a7c0bd..b433f2c  master     -> master
 * [new tag]         patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com -> patchew/1602411429-12043-1-git-send-email-yubihong@huawei.com
Switched to a new branch 'test'
1a213e1 migration: Delete redundant spaces
515c82f migration: Open brace '{' following function declarations go on the next line
d49e458 migration: Do not initialise statics and globals to 0 or NULL
74a25de migration: Add braces {} for if statement
7dbb0ff migration: Open brace '{' following struct go on the same line
730c9a26 migration: Add spaces around operator
62c3395 migration: Don't use '#' flag of printf format
05c1af5 migration: Do not use C99 // comments

=== OUTPUT BEGIN ===
1/8 Checking commit 05c1af5dbfcc (migration: Do not use C99 // comments)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 16 lines checked

Patch 1/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/8 Checking commit 62c339591b16 (migration: Don't use '#' flag of printf format)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 24 lines checked

Patch 2/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/8 Checking commit 730c9a264343 (migration: Add spaces around operator)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 59 lines checked

Patch 3/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/8 Checking commit 7dbb0ff26f66 (migration: Open brace '{' following struct go on the same line)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 9 lines checked

Patch 4/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/8 Checking commit 74a25de0eed8 (migration: Add braces {} for if statement)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 18 lines checked

Patch 5/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

6/8 Checking commit d49e4586bb79 (migration: Do not initialise statics and globals to 0 or NULL)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 16 lines checked

Patch 6/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

7/8 Checking commit 515c82ff06b4 (migration: Open brace '{' following function declarations go on the next line)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 9 lines checked

Patch 7/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

8/8 Checking commit 1a213e145493 (migration: Delete redundant spaces)
ERROR: space required after Signed-off-by:
#7: 
    Signed-off-by:Bihong Yu <yubihong@huawei.com>

total: 1 errors, 0 warnings, 8 lines checked

Patch 8/8 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1602411429-12043-1-git-send-email-yubihong@huawei.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com