sd: Exhibit support for CMD23

[PATCH v2] sd: Exhibit support for CMD23

Sai Pavan Boddu posted 1 patch 3 years, 7 months ago

Download mbox

Test docker-quick@centos7 failed

Test docker-mingw@fedora failed

Test checkpatch failed

Test FreeBSD failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1600278689-32187-1-git-send-email-sai.pavan.boddu@xilinx.com

Maintainers: "Philippe Mathieu-Daudé" <f4bug@amsat.org>

hw/sd/sd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[PATCH v2] sd: Exhibit support for CMD23

Posted by Sai Pavan Boddu 3 years, 7 months ago

Update 'SCR.CMD_SUPPORT' register with support of CMD23.

Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Reported-by: Rahul Thati <rthati@xilinx.com>
---
Changes for V2:
	Fix commit message

 hw/sd/sd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 0012882..16d1b61 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c
@@ -335,7 +335,7 @@ static void sd_set_scr(SDState *sd)
     if (sd->spec_version >= SD_PHY_SPECv3_01_VERS) {
         sd->scr[2] |= 1 << 7;   /* Spec Version 3.0X */
     }
-    sd->scr[3] = 0x00;
+    sd->scr[3] = 0x2;           /* CMD23 supported */
     /* reserved for manufacturer usage */
     sd->scr[4] = 0x00;
     sd->scr[5] = 0x00;
-- 
2.7.4

Re: [PATCH v2] sd: Exhibit support for CMD23

Posted by Philippe Mathieu-Daudé 3 years, 6 months ago

Hi Sai,

On 9/16/20 7:51 PM, Sai Pavan Boddu wrote:
> Update 'SCR.CMD_SUPPORT' register with support of CMD23.
> 
> Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
> Reported-by: Rahul Thati <rthati@xilinx.com>
> ---
> Changes for V2:
> 	Fix commit message
> 
>  hw/sd/sd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/sd/sd.c b/hw/sd/sd.c
> index 0012882..16d1b61 100644
> --- a/hw/sd/sd.c
> +++ b/hw/sd/sd.c
> @@ -335,7 +335,7 @@ static void sd_set_scr(SDState *sd)
>      if (sd->spec_version >= SD_PHY_SPECv3_01_VERS) {
>          sd->scr[2] |= 1 << 7;   /* Spec Version 3.0X */
>      }
> -    sd->scr[3] = 0x00;
> +    sd->scr[3] = 0x2;           /* CMD23 supported */

You need to check:
- spec_version >= SD_PHY_SPECv3_01_VERS
- sd->size > SDSC_MAX_CAPACITY

Then you should also update the TRAN_SPEED value in sd_set_csd().

>      /* reserved for manufacturer usage */
>      sd->scr[4] = 0x00;
>      sd->scr[5] = 0x00;
>