hw/i386/pc: Add a description for the i8042 property

[PATCH] hw/i386/pc: Add a description for the i8042 property

Posted by Kamil Szczęk 1 year, 6 months ago

While working on exposing the i8042 property in libvirt I noticed that
the property is missing a description. This adds a simple description
so that QEMU users don't have to dig in the source code to figure out
what this option does.

Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
---
 hw/i386/pc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index c74931d577..defbc33125 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1807,6 +1807,8 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
 
     object_class_property_add_bool(oc, PC_MACHINE_I8042,
         pc_machine_get_i8042, pc_machine_set_i8042);
+    object_class_property_set_description(oc, PC_MACHINE_I8042,
+        "Enable/disable Intel 8042 PS/2 controller emulation");
 
     object_class_property_add_bool(oc, "default-bus-bypass-iommu",
         pc_machine_get_default_bus_bypass_iommu,
-- 
2.45.0

Re: [PATCH] hw/i386/pc: Add a description for the i8042 property

Posted by Paolo Bonzini 1 year, 6 months ago

On 8/12/24 19:23, Kamil Szczęk wrote:
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
> 
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>

Queued, thanks.

Paolo

> ---
>   hw/i386/pc.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index c74931d577..defbc33125 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1807,6 +1807,8 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
>   
>       object_class_property_add_bool(oc, PC_MACHINE_I8042,
>           pc_machine_get_i8042, pc_machine_set_i8042);
> +    object_class_property_set_description(oc, PC_MACHINE_I8042,
> +        "Enable/disable Intel 8042 PS/2 controller emulation");
>   
>       object_class_property_add_bool(oc, "default-bus-bypass-iommu",
>           pc_machine_get_default_bus_bypass_iommu,

Re: [PATCH] hw/i386/pc: Add a description for the i8042 property

Posted by Zhao Liu 1 year, 6 months ago

On Mon, Aug 12, 2024 at 05:23:31PM +0000, Kamil Szczęk wrote:
> Date: Mon, 12 Aug 2024 17:23:31 +0000
> From: Kamil Szczęk <kamil@szczek.dev>
> Subject: [PATCH] hw/i386/pc: Add a description for the i8042 property
> 
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
> 
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
> ---
>  hw/i386/pc.c | 2 ++
>  1 file changed, 2 insertions(+)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Re: [PATCH] hw/i386/pc: Add a description for the i8042 property

Posted by Philippe Mathieu-Daudé 1 year, 6 months ago

On 12/8/24 19:23, Kamil Szczęk wrote:
> While working on exposing the i8042 property in libvirt I noticed that
> the property is missing a description. This adds a simple description
> so that QEMU users don't have to dig in the source code to figure out
> what this option does.
> 
> Signed-off-by: Kamil Szczęk <kamil@szczek.dev>
> ---
>   hw/i386/pc.c | 2 ++
>   1 file changed, 2 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>