On 7/13/20 2:27 AM, Andrey Shinkevich wrote:
> Add dirty bitmap information to QCOW2 metadata dump in the qcow2_format.py.
>
> v9:
> 01: In patch 0003, removed explicit constructor in the class Qcow2BitmapExt.
> 02: In patch 0004, the format string was changed.
>
>
> Andrey Shinkevich (10):
> qcow2: Fix capitalization of header extension constant.
> qcow2_format.py: make printable data an extension class member
> qcow2_format.py: change Qcow2BitmapExt initialization method
> qcow2_format.py: dump bitmap flags in human readable way.
> qcow2_format.py: Dump bitmap directory information
> qcow2_format.py: pass cluster size to substructures
> qcow2_format.py: Dump bitmap table serialized entries
> qcow2.py: Introduce '-j' key to dump in JSON format
> qcow2_format.py: collect fields to dump in JSON format
> qcow2_format.py: support dumping metadata in JSON format
>
> block/qcow2.c | 2 +-
> docs/interop/qcow2.txt | 2 +-
> tests/qemu-iotests/291.out | 90 ++++++++++++++++
Test 291 no longer outputs bitmap metadata (see commit 24b861c038);
which means your patches to 291.out don't make sense. You'll want to
respin this to follow the advice in that commit of having a separate
iotest just for qcow2.py output testing.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org