Thank you very much dear colleagues for your collaboration. Your reviews comments are well noted.
Andrey
________________________________
From: Eric Blake <eblake@redhat.com>
Sent: Tuesday, June 2, 2020 12:46 AM
To: Andrey Shinkevich <andrey.shinkevich@virtuozzo.com>; qemu-block@nongnu.org <qemu-block@nongnu.org>
Cc: qemu-devel@nongnu.org <qemu-devel@nongnu.org>; kwolf@redhat.com <kwolf@redhat.com>; mreitz@redhat.com <mreitz@redhat.com>; Denis Lunev <den@virtuozzo.com>; Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Subject: Re: [PATCH v3 0/6] iotests: Dump QCOW2 dirty bitmaps metadata
On 6/1/20 8:48 AM, Andrey Shinkevich wrote:
> Add dirty bitmap information to QCOW2 metadata dump in qcow2.py script.
>
> v3:
> 01: JSON format output possibility added.
Also, you split it into a series. Thanks; this makes it easier to
review each step :)
>
> v2:
> 01: Refactoring of the Python code in the script qcow2.py.
> New methods were added. The bitmap dictionary was instantiated.
> The all of bitmaps information is read completely before
> printing the dictionary.
> 02: The outputs of the tests 031, 036 and 061 were modified.
>
> Andrey Shinkevich (6):
> iotests: Add extension names to qcow2.py dump
> iotests: move check for printable data to QcowHeaderExtension class
> iotests: dump bitmap extension data with qcow2.py
> iotests: Dump bitmap directory info with qcow2.py
> iotests: Dump bitmap table entries serialized in QCOW2 image
> iotests: Dump QCOW2 image metadata in JSON format with qcow2.py
>
> tests/qemu-iotests/031.out | 22 +--
> tests/qemu-iotests/036.out | 4 +-
> tests/qemu-iotests/061.out | 18 +--
> tests/qemu-iotests/qcow2.py | 338 ++++++++++++++++++++++++++++++++++++++++++--
> 4 files changed, 346 insertions(+), 36 deletions(-)
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org