target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again

[PATCH] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again

Posted by Greg Kurz 5 years, 5 months ago

The penultimate argument of function ppc_radix64_partition_scoped_xlate()
has the bool type.

Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation"
Signed-off-by: Greg Kurz <groug@kaod.org>
---

A patch fixing the same issue in other places was merged recently in
ppc-for-5.1. Maybe worth squashing the two patches into one ?

commit 372ef6e9b803ef10c3200c45311d218e2c97b218
Author: Greg Kurz <groug@kaod.org>
Date:   Thu May 14 00:57:13 2020 +0200

    target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()
---
 target/ppc/mmu-radix64.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
index 0d3922537c4c..c60bf3135734 100644
--- a/target/ppc/mmu-radix64.c
+++ b/target/ppc/mmu-radix64.c
@@ -513,7 +513,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr, int rwx,
 
             ret = ppc_radix64_partition_scoped_xlate(cpu, rwx, eaddr, g_raddr,
                                                      pate, raddr, &prot, &psize,
-                                                     0, guest_visible);
+                                                     false, guest_visible);
             if (ret) {
                 return ret;
             }

Re: [PATCH] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again

Posted by Philippe Mathieu-Daudé 5 years, 5 months ago

On 5/26/20 6:20 PM, Greg Kurz wrote:
> The penultimate argument of function ppc_radix64_partition_scoped_xlate()
> has the bool type.
> 
> Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation"
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
> 
> A patch fixing the same issue in other places was merged recently in
> ppc-for-5.1. Maybe worth squashing the two patches into one ?
> 
> commit 372ef6e9b803ef10c3200c45311d218e2c97b218
> Author: Greg Kurz <groug@kaod.org>
> Date:   Thu May 14 00:57:13 2020 +0200
> 
>     target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()
> ---
>  target/ppc/mmu-radix64.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 0d3922537c4c..c60bf3135734 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -513,7 +513,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr, int rwx,
>  
>              ret = ppc_radix64_partition_scoped_xlate(cpu, rwx, eaddr, g_raddr,
>                                                       pate, raddr, &prot, &psize,
> -                                                     0, guest_visible);
> +                                                     false, guest_visible);
>              if (ret) {
>                  return ret;
>              }
> 
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [PATCH] target/ppc: Fix argument to ppc_radix64_partition_scoped_xlate() again

Posted by David Gibson 5 years, 5 months ago

On Tue, May 26, 2020 at 06:20:37PM +0200, Greg Kurz wrote:
> The penultimate argument of function ppc_radix64_partition_scoped_xlate()
> has the bool type.
> 
> Fixes: d04ea940c597 "target/ppc: Add support for Radix partition-scoped translation"
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied, thanks.

> ---
> 
> A patch fixing the same issue in other places was merged recently in
> ppc-for-5.1. Maybe worth squashing the two patches into one ?

I haven't done this, because it ran into some conflicts that I didn't
want to spend time resolving.

> 
> commit 372ef6e9b803ef10c3200c45311d218e2c97b218
> Author: Greg Kurz <groug@kaod.org>
> Date:   Thu May 14 00:57:13 2020 +0200
> 
>     target/ppc: Fix arguments to ppc_radix64_partition_scoped_xlate()
> ---
>  target/ppc/mmu-radix64.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 0d3922537c4c..c60bf3135734 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -513,7 +513,7 @@ static int ppc_radix64_xlate(PowerPCCPU *cpu, vaddr eaddr, int rwx,
>  
>              ret = ppc_radix64_partition_scoped_xlate(cpu, rwx, eaddr, g_raddr,
>                                                       pate, raddr, &prot, &psize,
> -                                                     0, guest_visible);
> +                                                     false, guest_visible);
>              if (ret) {
>                  return ret;
>              }
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson