[PATCH] target/ppc: Untabify excp_helper.c

Greg Kurz posted 1 patch 5 years, 6 months ago
Test asan passed
Test docker-mingw@fedora passed
Test checkpatch passed
Test docker-quick@centos7 passed
Test FreeBSD passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/158886788307.1560068.14096740175576278978.stgit@bahia.lan
Maintainers: David Gibson <david@gibson.dropbear.id.au>
target/ppc/excp_helper.c |   16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
[PATCH] target/ppc: Untabify excp_helper.c
Posted by Greg Kurz 5 years, 6 months ago
Some tabs crept in with a recent change.

Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging"
Signed-off-by: Greg Kurz <groug@kaod.org>
---
 target/ppc/excp_helper.c |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 639cac38f9c3..4db3d9ed9af5 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -70,16 +70,16 @@ static inline void dump_syscall(CPUPPCState *env)
 static inline void dump_hcall(CPUPPCState *env)
 {
     qemu_log_mask(CPU_LOG_INT, "hypercall r3=%016" PRIx64
-		  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
-		  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
-		  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
+                  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
+                  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
+                  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
                   " nip=" TARGET_FMT_lx "\n",
                   ppc_dump_gpr(env, 3), ppc_dump_gpr(env, 4),
-		  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
-		  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
-		  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
-		  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
-		  env->nip);
+                  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
+                  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
+                  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
+                  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
+                  env->nip);
 }
 
 static int powerpc_reset_wakeup(CPUState *cs, CPUPPCState *env, int excp,


Re: [PATCH] target/ppc: Untabify excp_helper.c
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago
On 5/7/20 6:11 PM, Greg Kurz wrote:
> Some tabs crept in with a recent change.
> 
> Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging"
> Signed-off-by: Greg Kurz <groug@kaod.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
using `git-diff --ignore-space-change`.

> ---
>   target/ppc/excp_helper.c |   16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 639cac38f9c3..4db3d9ed9af5 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -70,16 +70,16 @@ static inline void dump_syscall(CPUPPCState *env)
>   static inline void dump_hcall(CPUPPCState *env)
>   {
>       qemu_log_mask(CPU_LOG_INT, "hypercall r3=%016" PRIx64
> -		  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> -		  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> -		  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
> +                  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> +                  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> +                  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
>                     " nip=" TARGET_FMT_lx "\n",
>                     ppc_dump_gpr(env, 3), ppc_dump_gpr(env, 4),
> -		  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> -		  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> -		  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> -		  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> -		  env->nip);
> +                  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> +                  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> +                  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> +                  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> +                  env->nip);
>   }
>   
>   static int powerpc_reset_wakeup(CPUState *cs, CPUPPCState *env, int excp,
> 
> 


Re: [PATCH] target/ppc: Untabify excp_helper.c
Posted by David Gibson 5 years, 6 months ago
On Thu, May 07, 2020 at 06:11:23PM +0200, Greg Kurz wrote:
> Some tabs crept in with a recent change.
> 
> Fixes: 6dc6b557913f "target/ppc: Improve syscall exception logging"
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied, thanks.

Not quite sure why my pre-commit hook didn't catch this before I sent
the PR, but there you go.

> ---
>  target/ppc/excp_helper.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
> index 639cac38f9c3..4db3d9ed9af5 100644
> --- a/target/ppc/excp_helper.c
> +++ b/target/ppc/excp_helper.c
> @@ -70,16 +70,16 @@ static inline void dump_syscall(CPUPPCState *env)
>  static inline void dump_hcall(CPUPPCState *env)
>  {
>      qemu_log_mask(CPU_LOG_INT, "hypercall r3=%016" PRIx64
> -		  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> -		  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> -		  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
> +                  " r4=%016" PRIx64 " r5=%016" PRIx64 " r6=%016" PRIx64
> +                  " r7=%016" PRIx64 " r8=%016" PRIx64 " r9=%016" PRIx64
> +                  " r10=%016" PRIx64 " r11=%016" PRIx64 " r12=%016" PRIx64
>                    " nip=" TARGET_FMT_lx "\n",
>                    ppc_dump_gpr(env, 3), ppc_dump_gpr(env, 4),
> -		  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> -		  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> -		  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> -		  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> -		  env->nip);
> +                  ppc_dump_gpr(env, 5), ppc_dump_gpr(env, 6),
> +                  ppc_dump_gpr(env, 7), ppc_dump_gpr(env, 8),
> +                  ppc_dump_gpr(env, 9), ppc_dump_gpr(env, 10),
> +                  ppc_dump_gpr(env, 11), ppc_dump_gpr(env, 12),
> +                  env->nip);
>  }
>  
>  static int powerpc_reset_wakeup(CPUState *cs, CPUPPCState *env, int excp,
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson