1. Patchew
  2. QEMU
  3. View series

[PATCH] tests/Makefile: Fix description of "make check"

Huacai Chen posted 1 patch 5 years, 6 months ago
Test docker-mingw@fedora failed
Test checkpatch failed
Test asan failed
Test docker-quick@centos7 failed
Test FreeBSD failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1588663771-5534-1-git-send-email-chenhc@lemote.com
There is a newer version of this series
tests/Makefile.include | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH] tests/Makefile: Fix description of "make check"
Posted by Huacai Chen 5 years, 6 months ago 
The description of "make check" is out-of-date, so fix it by adding
block and softfloat.

Signed-off-by: Huacai Chen <chenhc@lemote.com>
---
 tests/Makefile.include | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Makefile.include b/tests/Makefile.include
index 03a74b6..5d32239 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -4,7 +4,7 @@
 check-help:
 	@echo "Regression testing targets:"
 	@echo
-	@echo " $(MAKE) check                Run unit, qapi-schema, qtest and decodetree"
+	@echo " $(MAKE) check                Run block, qapi-schema, unit, softfloat, qtest and decodetree"
 	@echo
 	@echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
 	@echo " $(MAKE) check-qtest          Run qtest tests"
-- 
2.7.0
Re: [PATCH] tests/Makefile: Fix description of "make check"
Posted by Claudio Fontana 5 years, 6 months ago 
On 5/5/20 9:29 AM, Huacai Chen wrote:
> The description of "make check" is out-of-date, so fix it by adding
> block and softfloat.
> 
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 03a74b6..5d32239 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -4,7 +4,7 @@
>  check-help:
>  	@echo "Regression testing targets:"
>  	@echo
> -	@echo " $(MAKE) check                Run unit, qapi-schema, qtest and decodetree"
> +	@echo " $(MAKE) check                Run block, qapi-schema, unit, softfloat, qtest and decodetree"
>  	@echo
>  	@echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
>  	@echo " $(MAKE) check-qtest          Run qtest tests"
> 

added Cc: qemu-trivial@nongnu.org

Reviewed-by: Claudio Fontana <cfontana@suse.de>
Re: [PATCH] tests/Makefile: Fix description of "make check"
Posted by Aleksandar Markovic 5 years, 6 months ago 
уторак, 05. мај 2020., Huacai Chen <zltjiangshi@gmail.com> је написао/ла:

> The description of "make check" is out-of-date, so fix it by adding
> block and softfloat.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---


Reviewed-by: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>


>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 03a74b6..5d32239 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -4,7 +4,7 @@
>  check-help:
>         @echo "Regression testing targets:"
>         @echo
> -       @echo " $(MAKE) check                Run unit, qapi-schema, qtest
> and decodetree"
> +       @echo " $(MAKE) check                Run block, qapi-schema, unit,
> softfloat, qtest and decodetree"
>         @echo
>         @echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given
> target"
>         @echo " $(MAKE) check-qtest          Run qtest tests"
> --
> 2.7.0
>
>
>
Re: [PATCH] tests/Makefile: Fix description of "make check"
Posted by Aleksandar Markovic 5 years, 5 months ago 
On Tue, May 5, 2020 at 9:30 AM Huacai Chen <zltjiangshi@gmail.com> wrote:
>
> The description of "make check" is out-of-date, so fix it by adding
> block and softfloat.
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---

Applied to mips queue.

Thanks,
Aleksandar

>  tests/Makefile.include | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 03a74b6..5d32239 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -4,7 +4,7 @@
>  check-help:
>         @echo "Regression testing targets:"
>         @echo
> -       @echo " $(MAKE) check                Run unit, qapi-schema, qtest and decodetree"
> +       @echo " $(MAKE) check                Run block, qapi-schema, unit, softfloat, qtest and decodetree"
>         @echo
>         @echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
>         @echo " $(MAKE) check-qtest          Run qtest tests"
> --
> 2.7.0
>
>
Re: [PATCH] tests/Makefile: Fix description of "make check"
Posted by Philippe Mathieu-Daudé 5 years, 6 months ago 
On 5/5/20 9:29 AM, Huacai Chen wrote:
> The description of "make check" is out-of-date, so fix it by adding
> block and softfloat.
> 
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> ---
>   tests/Makefile.include | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 03a74b6..5d32239 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -4,7 +4,7 @@
>   check-help:
>   	@echo "Regression testing targets:"
>   	@echo
> -	@echo " $(MAKE) check                Run unit, qapi-schema, qtest and decodetree"
> +	@echo " $(MAKE) check                Run block, qapi-schema, unit, softfloat, qtest and decodetree"

Maybe end with " tests"?

>   	@echo
>   	@echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
>   	@echo " $(MAKE) check-qtest          Run qtest tests"
>
Re: [PATCH] tests/Makefile: Fix description of "make check"
Posted by chen huacai 5 years, 6 months ago 
Hi, Philippe,

On Tue, May 5, 2020 at 5:33 PM Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>
> On 5/5/20 9:29 AM, Huacai Chen wrote:
> > The description of "make check" is out-of-date, so fix it by adding
> > block and softfloat.
> >
> > Signed-off-by: Huacai Chen <chenhc@lemote.com>
> > ---
> >   tests/Makefile.include | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/Makefile.include b/tests/Makefile.include
> > index 03a74b6..5d32239 100644
> > --- a/tests/Makefile.include
> > +++ b/tests/Makefile.include
> > @@ -4,7 +4,7 @@
> >   check-help:
> >       @echo "Regression testing targets:"
> >       @echo
> > -     @echo " $(MAKE) check                Run unit, qapi-schema, qtest and decodetree"
> > +     @echo " $(MAKE) check                Run block, qapi-schema, unit, softfloat, qtest and decodetree"
>
> Maybe end with " tests"?
Thank you, let me add "tests" in V2
>
> >       @echo
> >       @echo " $(MAKE) check-qtest-TARGET   Run qtest tests for given target"
> >       @echo " $(MAKE) check-qtest          Run qtest tests"
> >



-- 
Huacai Chen

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.