[PATCH] MAINTAINERS: Reactivate MIPS KVM CPUs

Aleksandar Markovic posted 1 patch 5 years, 8 months ago
Failed in applying to current master (apply log)
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
[PATCH] MAINTAINERS: Reactivate MIPS KVM CPUs
Posted by Aleksandar Markovic 5 years, 8 months ago
From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>

Reactivate MIPS KVM maintainership with a modest goal of keeping
the support alive, checking common KVM code changes against MIPS
functionality, etc. (hence the status "Odd Fixes"), with hope that
this component will be fully maintained at some further, but not
distant point in future.

CC: James Hogan <jhogan@kernel.org>
CC: Christian Borntraeger <borntraeger@de.ibm.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
---
 MAINTAINERS | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b0728c8..9cc55d5 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -365,8 +365,8 @@ S: Maintained
 F: target/arm/kvm.c
 
 MIPS KVM CPUs
-R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
-S: Orphan
+M: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
+S: Odd Fixes
 F: target/mips/kvm.c
 
 PPC KVM CPUs
-- 
2.7.4


Re: [PATCH] MAINTAINERS: Reactivate MIPS KVM CPUs
Posted by Christian Borntraeger 5 years, 8 months ago

On 24.02.20 12:50, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> 
> Reactivate MIPS KVM maintainership with a modest goal of keeping
> the support alive, checking common KVM code changes against MIPS
> functionality, etc. (hence the status "Odd Fixes"), with hope that
> this component will be fully maintained at some further, but not
> distant point in future.
> 
> CC: James Hogan <jhogan@kernel.org>
> CC: Christian Borntraeger <borntraeger@de.ibm.com>
> CC: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>

I talked with Aleksandar several times about maintainership and I 
think he is the right person for the job stepping up as maintainer.

Acked-by: Christian Borntraeger <borntraeger@de.ibm.co>

> ---
>  MAINTAINERS | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b0728c8..9cc55d5 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -365,8 +365,8 @@ S: Maintained
>  F: target/arm/kvm.c
>  
>  MIPS KVM CPUs
> -R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
> -S: Orphan
> +M: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> +S: Odd Fixes
>  F: target/mips/kvm.c
>  
>  PPC KVM CPUs
> 


Re: [PATCH] MAINTAINERS: Reactivate MIPS KVM CPUs
Posted by Philippe Mathieu-Daudé 5 years, 8 months ago
On 2/24/20 12:55 PM, Christian Borntraeger wrote:
> On 24.02.20 12:50, Aleksandar Markovic wrote:
>> From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
>>
>> Reactivate MIPS KVM maintainership with a modest goal of keeping
>> the support alive, checking common KVM code changes against MIPS
>> functionality, etc. (hence the status "Odd Fixes"), with hope that
>> this component will be fully maintained at some further, but not
>> distant point in future.

My only worry here is, do you have hardware to run tests?

>>
>> CC: James Hogan <jhogan@kernel.org>
>> CC: Christian Borntraeger <borntraeger@de.ibm.com>
>> CC: Paolo Bonzini <pbonzini@redhat.com>
>> Signed-off-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> 
> I talked with Aleksandar several times about maintainership and I
> think he is the right person for the job stepping up as maintainer.

Agreed.

FWIW:
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> Acked-by: Christian Borntraeger <borntraeger@de.ibm.co>
> 
>> ---
>>   MAINTAINERS | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b0728c8..9cc55d5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -365,8 +365,8 @@ S: Maintained
>>   F: target/arm/kvm.c
>>   
>>   MIPS KVM CPUs
>> -R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
>> -S: Orphan
>> +M: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
>> +S: Odd Fixes
>>   F: target/mips/kvm.c
>>   
>>   PPC KVM CPUs
>>
> 
> 


Re: [PATCH] MAINTAINERS: Reactivate MIPS KVM CPUs
Posted by Philippe Mathieu-Daudé 5 years, 8 months ago
On Mon, Feb 24, 2020 at 1:09 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
> On 2/24/20 12:55 PM, Christian Borntraeger wrote:
> > On 24.02.20 12:50, Aleksandar Markovic wrote:
> >> From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> >>
> >> Reactivate MIPS KVM maintainership with a modest goal of keeping
> >> the support alive, checking common KVM code changes against MIPS
> >> functionality, etc. (hence the status "Odd Fixes"), with hope that
> >> this component will be fully maintained at some further, but not
> >> distant point in future.
>
> My only worry here is, do you have hardware to run tests?
>
> >>
> >> CC: James Hogan <jhogan@kernel.org>
> >> CC: Christian Borntraeger <borntraeger@de.ibm.com>
> >> CC: Paolo Bonzini <pbonzini@redhat.com>
> >> Signed-off-by: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> >
> > I talked with Aleksandar several times about maintainership and I
> > think he is the right person for the job stepping up as maintainer.
>
> Agreed.
>
> FWIW:
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> > Acked-by: Christian Borntraeger <borntraeger@de.ibm.co>
> >
> >> ---
> >>   MAINTAINERS | 4 ++--
> >>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/MAINTAINERS b/MAINTAINERS
> >> index b0728c8..9cc55d5 100644
> >> --- a/MAINTAINERS
> >> +++ b/MAINTAINERS
> >> @@ -365,8 +365,8 @@ S: Maintained
> >>   F: target/arm/kvm.c
> >>
> >>   MIPS KVM CPUs
> >> -R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>

BTW are you sure you want to remove Aleksandar Rikalo as reviewer?
(There is no description about this change.)

> >> -S: Orphan
> >> +M: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> >> +S: Odd Fixes
> >>   F: target/mips/kvm.c
> >>
> >>   PPC KVM CPUs
> >>
> >
> >


Re: [PATCH] MAINTAINERS:Reactivate MIPS KVM CPUs
Posted by Aleksandar Markovic 5 years, 8 months ago
> Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
> > >> diff --git a/MAINTAINERS b/MAINTAINERS
> > >> index b0728c8..9cc55d5 100644
> > >> --- a/MAINTAINERS
> > >> +++ b/MAINTAINERS
> > >> @@ -365,8 +365,8 @@ S: Maintained
> > >>   F: target/arm/kvm.c
> > >>
> > >>   MIPS KVM CPUs
> > >> -R: Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>
>
> BTW are you sure you want to remove Aleksandar Rikalo as reviewer?
> (There is no description about this change.)

Aleksandar Rikalo is an experienced engineer very familiar
with QEMU, and he is helping reviewing many other areas of
QEMU for MIPS - however, his main day-to-day duties currently
involve projects other than QEMU, and he is not sure if he will
manage to get enough time to devote to KVM/MIPS. I talked to
him too about the whole situation. If the current situation
changes (he gets more time), and he wishes to participate,
he will be welcomed, and we can add him easily.

Thank you,
Aleksandar

 
Re: [PATCH] MAINTAINERS:Reactivate MIPS KVM CPUs
Posted by Aleksandar Markovic 5 years, 8 months ago
> Philippe Mathieu-Daudé wrote:
> > Aleksandar Markovic wrote:
> >> From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
> >>
> >> Reactivate MIPS KVM maintainership with a modest goal of keeping
> >> the support alive, checking common KVM code changes against MIPS
> >> functionality, etc. (hence the status "Odd Fixes"), with hope that
> >> this component will be fully maintained at some further, but not
> >> distant point in future.
>
> My only worry here is, do you have hardware to run tests?

Yes, I do have access to the appropriate MIPS hardware.

Thank you,
Aleksandar
 
Re: [PATCH] MAINTAINERS: Reactivate MIPS KVM CPUs
Posted by Philippe Mathieu-Daudé 5 years, 8 months ago
On 2/24/20 1:20 PM, Aleksandar Markovic wrote:
> 
>  > Philippe Mathieu-Daudé wrote:
>  > > Aleksandar Markovic wrote:
>  > >> From: Aleksandar Markovic <aleksandar.m.mail@gmail.com>
>  > >>
>  > >> Reactivate MIPS KVM maintainership with a modest goal of keeping
>  > >> the support alive, checking common KVM code changes against MIPS
>  > >> functionality, etc. (hence the status "Odd Fixes"), with hope that
>  > >> this component will be fully maintained at some further, but not
>  > >> distant point in future.
>  >
>  > My only worry here is, do you have hardware to run tests?
> 
> Yes, I do have access to the appropriate MIPS hardware.

Great news :)

This is something to consider when we add more GitLab CI runners (for 
automated testing).