[PATCH 0/3] target/i386: early MSR initialization + pass down host microcode revision for "-cpu host"

Paolo Bonzini posted 3 patches 4 years, 3 months ago
Test FreeBSD passed
Test docker-mingw@fedora passed
Test checkpatch failed
Test docker-quick@centos7 passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1579544504-3616-1-git-send-email-pbonzini@redhat.com
Maintainers: Eduardo Habkost <ehabkost@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>, Marcelo Tosatti <mtosatti@redhat.com>
target/i386/cpu.c         | 14 ++++++++
target/i386/cpu.h         |  3 ++
target/i386/hvf/x86_emu.c |  4 +--
target/i386/kvm.c         | 86 +++++++++++++++++++++++++++++------------------
target/i386/kvm_i386.h    |  1 +
target/i386/misc_helper.c |  4 +++
6 files changed, 76 insertions(+), 36 deletions(-)
[PATCH 0/3] target/i386: early MSR initialization + pass down host microcode revision for "-cpu host"
Posted by Paolo Bonzini 4 years, 3 months ago
As part of this, patch 1 moves feature MSR initialization to
kvm_arch_init_vcpu, which also fixes a problem related to the ordering
of kvm_put_msrs and kvm_put_nested_state.  Patch 2 adds a customizable
ucode-rev property that is supported by both TCG and HVF.  Finally patch 3
adds the KVM support, including getting the host version via KVM_GET_MSRS
and passing it back to the guest for "-cpu host" only.

Paolo Bonzini (3):
  target/i386: kvm: initialize feature MSRs very early
  target/i386: add a ucode-rev property
  target/i386: kvm: initialize microcode revision from KVM

 target/i386/cpu.c         | 14 ++++++++
 target/i386/cpu.h         |  3 ++
 target/i386/hvf/x86_emu.c |  4 +--
 target/i386/kvm.c         | 86 +++++++++++++++++++++++++++++------------------
 target/i386/kvm_i386.h    |  1 +
 target/i386/misc_helper.c |  4 +++
 6 files changed, 76 insertions(+), 36 deletions(-)

-- 
1.8.3.1


Re: [PATCH 0/3] target/i386: early MSR initialization + pass down host microcode revision for "-cpu host"
Posted by no-reply@patchew.org 4 years, 3 months ago
Patchew URL: https://patchew.org/QEMU/1579544504-3616-1-git-send-email-pbonzini@redhat.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1579544504-3616-1-git-send-email-pbonzini@redhat.com
Subject: [PATCH 0/3] target/i386: early MSR initialization + pass down host microcode revision for "-cpu host"

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
29ac94b target/i386: kvm: initialize microcode revision from KVM
54502b3 target/i386: add a ucode-rev property
7d66a0a target/i386: kvm: initialize feature MSRs very early

=== OUTPUT BEGIN ===
1/3 Checking commit 7d66a0ad44e0 (target/i386: kvm: initialize feature MSRs very early)
2/3 Checking commit 54502b34491d (target/i386: add a ucode-rev property)
3/3 Checking commit 29ac94bec151 (target/i386: kvm: initialize microcode revision from KVM)
WARNING: line over 80 characters
#23: FILE: target/i386/cpu.c:6421:
+                                                                MSR_IA32_UCODE_REV);

ERROR: code indent should never use tabs
#37: FILE: target/i386/kvm.c:2700:
+^I^I^I^I^I   MSR_IA32_UCODE_REV)) {$

total: 1 errors, 1 warnings, 21 lines checked

Patch 3/3 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1579544504-3616-1-git-send-email-pbonzini@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com