docker: gtester is no longer used

[PATCH] docker: gtester is no longer used

Paolo Bonzini posted 1 patch 4 years, 4 months ago

Download mbox

Test asan failed

Test checkpatch failed

Test FreeBSD failed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1576632611-55032-1-git-send-email-pbonzini@redhat.com

Maintainers: "Alex Bennée" <alex.bennee@linaro.org>, Fam Zheng <fam@euphon.net>, "Philippe Mathieu-Daudé" <philmd@redhat.com>

tests/docker/common.rc | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)

Expand all Fold all

[PATCH] docker: gtester is no longer used

Posted by Paolo Bonzini 4 years, 4 months ago

We are using tap-driver.pl, do not require anymore gtester to be installed
to run the testsuite in docker-based tests.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/docker/common.rc | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 512202b..02cd67a 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -53,12 +53,7 @@ check_qemu()
         INVOCATION="$@"
     fi
 
-    if command -v gtester > /dev/null 2>&1 && \
-           gtester --version > /dev/null 2>&1; then
-        make $MAKEFLAGS $INVOCATION
-    else
-        echo "No working gtester, skipping make $INVOCATION"
-    fi
+    make $MAKEFLAGS $INVOCATION
 }
 
 test_fail()
-- 
1.8.3.1

Re: [PATCH] docker: gtester is no longer used

Posted by Thomas Huth 4 years, 4 months ago

On 18/12/2019 02.30, Paolo Bonzini wrote:
> We are using tap-driver.pl, do not require anymore gtester to be installed
> to run the testsuite in docker-based tests.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/common.rc | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 512202b..02cd67a 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -53,12 +53,7 @@ check_qemu()
>          INVOCATION="$@"
>      fi
>  
> -    if command -v gtester > /dev/null 2>&1 && \
> -           gtester --version > /dev/null 2>&1; then
> -        make $MAKEFLAGS $INVOCATION
> -    else
> -        echo "No working gtester, skipping make $INVOCATION"
> -    fi
> +    make $MAKEFLAGS $INVOCATION
>  }
>  
>  test_fail()
> 

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [PATCH] docker: gtester is no longer used

Posted by Alex Bennée 4 years, 4 months ago

Paolo Bonzini <pbonzini@redhat.com> writes:

> We are using tap-driver.pl, do not require anymore gtester to be installed
> to run the testsuite in docker-based tests.

Queued to pullreq/testing-logging-misc, thanks.

>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  tests/docker/common.rc | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/tests/docker/common.rc b/tests/docker/common.rc
> index 512202b..02cd67a 100755
> --- a/tests/docker/common.rc
> +++ b/tests/docker/common.rc
> @@ -53,12 +53,7 @@ check_qemu()
>          INVOCATION="$@"
>      fi
>  
> -    if command -v gtester > /dev/null 2>&1 && \
> -           gtester --version > /dev/null 2>&1; then
> -        make $MAKEFLAGS $INVOCATION
> -    else
> -        echo "No working gtester, skipping make $INVOCATION"
> -    fi
> +    make $MAKEFLAGS $INVOCATION
>  }
>  
>  test_fail()


-- 
Alex Bennée