numa: stop abusing numa_mem_supported

[PATCH 0/2] numa: stop abusing numa_mem_supported

Posted by Igor Mammedov 4 years, 4 months ago

A fix  and cleanup for a mistakes that slipped by me in
  aa57020774 (numa: move numa global variable nb_numa_nodes into MachineState)


CC: Eduardo Habkost <ehabkost@redhat.com>
CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
CC: Tao Xu <tao3.xu@intel.com>

Igor Mammedov (2):
  numa: remove not needed check
  numa: properly check if numa is supported

 hw/arm/sbsa-ref.c | 1 -
 hw/core/machine.c | 4 ++--
 hw/core/numa.c    | 7 +------
 3 files changed, 3 insertions(+), 9 deletions(-)

-- 
2.7.4

Re: [PATCH 0/2] numa: stop abusing numa_mem_supported

Posted by Igor Mammedov 4 years, 4 months ago

On Thu, 12 Dec 2019 13:48:54 +0100
Igor Mammedov <imammedo@redhat.com> wrote:

> A fix  and cleanup for a mistakes that slipped by me in
>   aa57020774 (numa: move numa global variable nb_numa_nodes into MachineState)

ping,

could someone pick it up please?

> 
> 
> CC: Eduardo Habkost <ehabkost@redhat.com>
> CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> CC: Tao Xu <tao3.xu@intel.com>
> 
> Igor Mammedov (2):
>   numa: remove not needed check
>   numa: properly check if numa is supported
> 
>  hw/arm/sbsa-ref.c | 1 -
>  hw/core/machine.c | 4 ++--
>  hw/core/numa.c    | 7 +------
>  3 files changed, 3 insertions(+), 9 deletions(-)
>

Re: [PATCH 0/2] numa: stop abusing numa_mem_supported

Posted by Michael S. Tsirkin 4 years, 4 months ago

On Thu, Dec 19, 2019 at 02:28:51PM +0100, Igor Mammedov wrote:
> On Thu, 12 Dec 2019 13:48:54 +0100
> Igor Mammedov <imammedo@redhat.com> wrote:
> 
> > A fix  and cleanup for a mistakes that slipped by me in
> >   aa57020774 (numa: move numa global variable nb_numa_nodes into MachineState)
> 
> ping,
> 
> could someone pick it up please?

Looks more like Eduardo's thing.

> > 
> > 
> > CC: Eduardo Habkost <ehabkost@redhat.com>
> > CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > CC: Tao Xu <tao3.xu@intel.com>
> > 
> > Igor Mammedov (2):
> >   numa: remove not needed check
> >   numa: properly check if numa is supported
> > 
> >  hw/arm/sbsa-ref.c | 1 -
> >  hw/core/machine.c | 4 ++--
> >  hw/core/numa.c    | 7 +------
> >  3 files changed, 3 insertions(+), 9 deletions(-)
> >

Re: [PATCH 0/2] numa: stop abusing numa_mem_supported

Posted by Igor Mammedov 4 years, 4 months ago

On Thu, 19 Dec 2019 08:30:34 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> On Thu, Dec 19, 2019 at 02:28:51PM +0100, Igor Mammedov wrote:
> > On Thu, 12 Dec 2019 13:48:54 +0100
> > Igor Mammedov <imammedo@redhat.com> wrote:
> >   
> > > A fix  and cleanup for a mistakes that slipped by me in
> > >   aa57020774 (numa: move numa global variable nb_numa_nodes into MachineState)  
> > 
> > ping,
> > 
> > could someone pick it up please?  
> 
> Looks more like Eduardo's thing.

Yep if he is still available,
but I wasn't sure with coming winter break.

In addition, this patch will be prerequisite for disabling
deprecated '-numa node,mem'
hence broadcast ping to make sure it won't get lost.

> 
> > > 
> > > 
> > > CC: Eduardo Habkost <ehabkost@redhat.com>
> > > CC: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
> > > CC: Tao Xu <tao3.xu@intel.com>
> > > 
> > > Igor Mammedov (2):
> > >   numa: remove not needed check
> > >   numa: properly check if numa is supported
> > > 
> > >  hw/arm/sbsa-ref.c | 1 -
> > >  hw/core/machine.c | 4 ++--
> > >  hw/core/numa.c    | 7 +------
> > >  3 files changed, 3 insertions(+), 9 deletions(-)
> > >   
>

Re: [PATCH 0/2] numa: stop abusing numa_mem_supported

Posted by Paolo Bonzini 4 years, 4 months ago

On 19/12/19 14:42, Igor Mammedov wrote:
> On Thu, 19 Dec 2019 08:30:34 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
> 
>> On Thu, Dec 19, 2019 at 02:28:51PM +0100, Igor Mammedov wrote:
>>> On Thu, 12 Dec 2019 13:48:54 +0100
>>> Igor Mammedov <imammedo@redhat.com> wrote:
>>>   
>>>> A fix  and cleanup for a mistakes that slipped by me in
>>>>   aa57020774 (numa: move numa global variable nb_numa_nodes into MachineState)  
>>>
>>> ping,
>>>
>>> could someone pick it up please?  
>>
>> Looks more like Eduardo's thing.
> 
> Yep if he is still available,
> but I wasn't sure with coming winter break.
> 
> In addition, this patch will be prerequisite for disabling
> deprecated '-numa node,mem'
> hence broadcast ping to make sure it won't get lost.

I'll take care of it (after new year).

Paolo

Re: [PATCH 0/2] numa: stop abusing numa_mem_supported

Posted by Igor Mammedov 4 years, 4 months ago

On Fri, 20 Dec 2019 14:14:58 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:

> On 19/12/19 14:42, Igor Mammedov wrote:
> > On Thu, 19 Dec 2019 08:30:34 -0500
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >   
> >> On Thu, Dec 19, 2019 at 02:28:51PM +0100, Igor Mammedov wrote:  
> >>> On Thu, 12 Dec 2019 13:48:54 +0100
> >>> Igor Mammedov <imammedo@redhat.com> wrote:
> >>>     
> >>>> A fix  and cleanup for a mistakes that slipped by me in
> >>>>   aa57020774 (numa: move numa global variable nb_numa_nodes into MachineState)    
> >>>
> >>> ping,
> >>>
> >>> could someone pick it up please?    
> >>
> >> Looks more like Eduardo's thing.  
> > 
> > Yep if he is still available,
> > but I wasn't sure with coming winter break.
> > 
> > In addition, this patch will be prerequisite for disabling
> > deprecated '-numa node,mem'
> > hence broadcast ping to make sure it won't get lost.  
> 
> I'll take care of it (after new year).

It' looks like Eduardo already picked it up.
(meanwhile I'm preparing to post mem-path patch bomb with these included)


Though it would be nice is you could take a look at another series
  [PATCH for-5.0 v2 0/9] q35: CPU hotplug with secure boot, part 1+2
especially 2/9 patch

> 
> Paolo
> 
>