[v2] Complete the implementation of -accel

[PATCH v2 06/18] accel: compile accel/accel.c just once

Paolo Bonzini posted 18 patches 6 years, 2 months ago

Diff against v1
Download mbox

Maintainers: Richard Henderson <rth@twiddle.net>, David Gibson <david@gibson.dropbear.id.au>, David Hildenbrand <david@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Paul Durrant <paul@xen.org>, Aleksandar Markovic <amarkovic@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>, Christian Borntraeger <borntraeger@de.ibm.com>, "Daniel P. Berrangé" <berrange@redhat.com>, James Hogan <jhogan@kernel.org>, Marcelo Tosatti <mtosatti@redhat.com>, Anthony Perard <anthony.perard@citrix.com>, Stefano Stabellini <sstabellini@kernel.org>, Peter Maydell <peter.maydell@linaro.org>, Marcel Apfelbaum <marcel.apfelbaum@gmail.com>, Eduardo Habkost <ehabkost@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, Halil Pasic <pasic@linux.ibm.com>

Expand all Fold all

[PATCH v2 06/18] accel: compile accel/accel.c just once

Posted by Paolo Bonzini 6 years, 2 months ago

Now that accel/accel.c does not use CONFIG_TCG or CONFIG_KVM anymore,
it need not be compiled once for every softmmu target.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 Makefile.objs       | 1 +
 accel/Makefile.objs | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/Makefile.objs b/Makefile.objs
index 11ba1a3..b6fcbac 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -55,6 +55,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o
 
 common-obj-$(CONFIG_LINUX) += fsdev/
 
+common-obj-y += accel/
 common-obj-y += migration/
 
 common-obj-y += audio/
diff --git a/accel/Makefile.objs b/accel/Makefile.objs
index 8b498d3..17e5ac6 100644
--- a/accel/Makefile.objs
+++ b/accel/Makefile.objs
@@ -1,4 +1,4 @@
-obj-$(CONFIG_SOFTMMU) += accel.o
+common-obj-$(CONFIG_SOFTMMU) += accel.o
 obj-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_POSIX)) += qtest.o
 obj-$(CONFIG_KVM) += kvm/
 obj-$(CONFIG_TCG) += tcg/
-- 
1.8.3.1

Re: [PATCH v2 06/18] accel: compile accel/accel.c just once

Posted by Philippe Mathieu-Daudé 6 years, 2 months ago

On 12/9/19 4:01 PM, Paolo Bonzini wrote:
> Now that accel/accel.c does not use CONFIG_TCG or CONFIG_KVM anymore,
> it need not be compiled once for every softmmu target.
> 
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

> ---
>   Makefile.objs       | 1 +
>   accel/Makefile.objs | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile.objs b/Makefile.objs
> index 11ba1a3..b6fcbac 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -55,6 +55,7 @@ common-obj-$(CONFIG_POSIX) += os-posix.o
>   
>   common-obj-$(CONFIG_LINUX) += fsdev/
>   
> +common-obj-y += accel/
>   common-obj-y += migration/
>   
>   common-obj-y += audio/
> diff --git a/accel/Makefile.objs b/accel/Makefile.objs
> index 8b498d3..17e5ac6 100644
> --- a/accel/Makefile.objs
> +++ b/accel/Makefile.objs
> @@ -1,4 +1,4 @@
> -obj-$(CONFIG_SOFTMMU) += accel.o
> +common-obj-$(CONFIG_SOFTMMU) += accel.o
>   obj-$(call land,$(CONFIG_SOFTMMU),$(CONFIG_POSIX)) += qtest.o
>   obj-$(CONFIG_KVM) += kvm/
>   obj-$(CONFIG_TCG) += tcg/
>