[v1] mips: machines: Renovate coding style

[PATCH 0/5] mips: machines: Renovate coding style

Filip Bozuta posted 5 patches 4 years, 4 months ago

Diff against v1
Download series mbox

Test asan passed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1575640687-20744-1-git-send-email-Filip.Bozuta@rt-rk.com

Maintainers: Aurelien Jarno <aurelien@aurel32.net>, Jason Wang <jasowang@redhat.com>, Aleksandar Markovic <amarkovic@wavecomp.com>, Aleksandar Rikalo <aleksandar.rikalo@rt-rk.com>, "Hervé Poussineau" <hpoussin@reactos.org>

hw/display/jazz_led.c                    | 123 +++++++++++-----------
hw/dma/rc4030.c                          |  12 ++-
hw/isa/vt82c686.c                        |  23 +++--
hw/mips/mips_jazz.c                      |  32 +++---
hw/mips/mips_malta.c                     | 169 ++++++++++++++++---------------
hw/mips/mips_r4k.c                       |  55 ++++++----
hw/net/mipsnet.c                         |  44 ++++----
hw/pci-host/bonito.c                     |  60 ++++++-----
tests/acceptance/linux_ssh_mips_malta.py |   6 +-
9 files changed, 281 insertions(+), 243 deletions(-)

Expand all Fold all

[PATCH 0/5] mips: machines: Renovate coding style

Posted by Filip Bozuta 4 years, 4 months ago

The scripts checkpatch.pl located in scripts folder
was used to check for errors and warnings in fllowing
mips machines:

    Jazz
    Malta
    Mipssim
    R4000
    Fulong 2E
    Boston

All generated errors and warnings were corrected
and the script was ran again to make sure there
are no more errors and warnings

Note:

    Boston machine was already clear of errors
    and warnings so the boston machine files 
    were not edited.

Note:

    One error occured due to the machro #IF 0.
    That error was not corrected beacuse there
    is some reduntant code within that macro that
    might be used in future versions.

v2:

    * changed lines in hw/mips/mips_malta.c from 848 to
      995 so that comments begin at the same line

    * changed line 573 in hw/mips/mips_malta.c to fix
      the build error due to the function g_new0 that is
      used for allocating

    * changed lines 103 and 107 in tests/acceptance/mips_malta.c
      so that splitting lines are aligned vertically 
      belove the opening brackets

    * changed line 121 in mips_r4k.c so that INITRD_PAGE_MASK so 
      that it is aligned vertically belove the opening bracket

Filip Bozuta (5):
  mips: jazz: Renovate coding style
  mips: malta: Renovate coding style
  mips: mipssim: Renovate coding style
  mips: r4000: Renovate coding style
  mips: fulong 2e: Renovate coding style

 hw/display/jazz_led.c                    | 123 +++++++++++-----------
 hw/dma/rc4030.c                          |  12 ++-
 hw/isa/vt82c686.c                        |  23 +++--
 hw/mips/mips_jazz.c                      |  32 +++---
 hw/mips/mips_malta.c                     | 169 ++++++++++++++++---------------
 hw/mips/mips_r4k.c                       |  55 ++++++----
 hw/net/mipsnet.c                         |  44 ++++----
 hw/pci-host/bonito.c                     |  60 ++++++-----
 tests/acceptance/linux_ssh_mips_malta.py |   6 +-
 9 files changed, 281 insertions(+), 243 deletions(-)

-- 
2.7.4

Re: [PATCH 0/5] mips: machines: Renovate coding style

Posted by Aleksandar Markovic 4 years, 4 months ago

On Fri, Dec 6, 2019 at 3:41 PM Filip Bozuta <Filip.Bozuta@rt-rk.com> wrote:
>
> The scripts checkpatch.pl located in scripts folder
> was used to check for errors and warnings in fllowing
> mips machines:
>
>     Jazz
>     Malta
>     Mipssim
>     R4000
>     Fulong 2E
>     Boston
>
> All generated errors and warnings were corrected
> and the script was ran again to make sure there
> are no more errors and warnings
>
> Note:
>
>     Boston machine was already clear of errors
>     and warnings so the boston machine files
>     were not edited.
>
> Note:
>
>     One error occured due to the machro #IF 0.
>     That error was not corrected beacuse there
>     is some reduntant code within that macro that
>     might be used in future versions.
>
> v2:
>
>     * changed lines in hw/mips/mips_malta.c from 848 to
>       995 so that comments begin at the same line
>
>     * changed line 573 in hw/mips/mips_malta.c to fix
>       the build error due to the function g_new0 that is
>       used for allocating
>
>     * changed lines 103 and 107 in tests/acceptance/mips_malta.c
>       so that splitting lines are aligned vertically
>       belove the opening brackets
>
>     * changed line 121 in mips_r4k.c so that INITRD_PAGE_MASK so
>       that it is aligned vertically belove the opening bracket
>
> Filip Bozuta (5):
>   mips: jazz: Renovate coding style
>   mips: malta: Renovate coding style
>   mips: mipssim: Renovate coding style
>   mips: r4000: Renovate coding style
>   mips: fulong 2e: Renovate coding style
>
>  hw/display/jazz_led.c                    | 123 +++++++++++-----------
>  hw/dma/rc4030.c                          |  12 ++-
>  hw/isa/vt82c686.c                        |  23 +++--
>  hw/mips/mips_jazz.c                      |  32 +++---
>  hw/mips/mips_malta.c                     | 169 ++++++++++++++++---------------
>  hw/mips/mips_r4k.c                       |  55 ++++++----
>  hw/net/mipsnet.c                         |  44 ++++----
>  hw/pci-host/bonito.c                     |  60 ++++++-----
>  tests/acceptance/linux_ssh_mips_malta.py |   6 +-
>  9 files changed, 281 insertions(+), 243 deletions(-)
>

Applied to mips queue, with some minor modifications limited to
several lines of code.

Filip, please make sure to test build in future.

(Of course, other applicable unit and integration tests should be executed too.)

Thanks,
Aleksandar

> --
> 2.7.4
>
>