ppc/pnv: Drop "chip" link from POWER9 PSI object

[PATCH] ppc/pnv: Drop "chip" link from POWER9 PSI object

Greg Kurz posted 1 patch 4 years, 5 months ago

Download mbox

Test asan failed

Test checkpatch passed

Test FreeBSD passed

Test docker-mingw@fedora failed

Test docker-clang@ubuntu failed

Test docker-quick@centos7 failed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/157383383118.166856.2588933416368211047.stgit@bahia.lan

Maintainers: David Gibson <david@gibson.dropbear.id.au>, "Cédric Le Goater" <clg@kaod.org>

hw/ppc/pnv.c |    2 --
1 file changed, 2 deletions(-)

Expand all Fold all

[PATCH] ppc/pnv: Drop "chip" link from POWER9 PSI object

Posted by Greg Kurz 4 years, 5 months ago

It has no apparent user.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/ppc/pnv.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
index d7130c3304f0..24bc3d5ab32b 100644
--- a/hw/ppc/pnv.c
+++ b/hw/ppc/pnv.c
@@ -1091,8 +1091,6 @@ static void pnv_chip_power9_instance_init(Object *obj)
 
     object_initialize_child(obj, "psi",  &chip9->psi, sizeof(chip9->psi),
                             TYPE_PNV9_PSI, &error_abort, NULL);
-    object_property_add_const_link(OBJECT(&chip9->psi), "chip", obj,
-                                   &error_abort);
 
     object_initialize_child(obj, "lpc",  &chip9->lpc, sizeof(chip9->lpc),
                             TYPE_PNV9_LPC, &error_abort, NULL);

Re: [PATCH] ppc/pnv: Drop "chip" link from POWER9 PSI object

Posted by Greg Kurz 4 years, 5 months ago

Oops 'for-5.0' tag is missing :)

On Fri, 15 Nov 2019 17:03:51 +0100
Greg Kurz <groug@kaod.org> wrote:

> It has no apparent user.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  hw/ppc/pnv.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index d7130c3304f0..24bc3d5ab32b 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -1091,8 +1091,6 @@ static void pnv_chip_power9_instance_init(Object *obj)
>  
>      object_initialize_child(obj, "psi",  &chip9->psi, sizeof(chip9->psi),
>                              TYPE_PNV9_PSI, &error_abort, NULL);
> -    object_property_add_const_link(OBJECT(&chip9->psi), "chip", obj,
> -                                   &error_abort);
>  
>      object_initialize_child(obj, "lpc",  &chip9->lpc, sizeof(chip9->lpc),
>                              TYPE_PNV9_LPC, &error_abort, NULL);
> 
>

Re: [PATCH] ppc/pnv: Drop "chip" link from POWER9 PSI object

Posted by David Gibson 4 years, 5 months ago

On Fri, Nov 15, 2019 at 05:03:51PM +0100, Greg Kurz wrote:
> It has no apparent user.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied to ppc-for-5.0, thanks.

> ---
>  hw/ppc/pnv.c |    2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index d7130c3304f0..24bc3d5ab32b 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -1091,8 +1091,6 @@ static void pnv_chip_power9_instance_init(Object *obj)
>  
>      object_initialize_child(obj, "psi",  &chip9->psi, sizeof(chip9->psi),
>                              TYPE_PNV9_PSI, &error_abort, NULL);
> -    object_property_add_const_link(OBJECT(&chip9->psi), "chip", obj,
> -                                   &error_abort);
>  
>      object_initialize_child(obj, "lpc",  &chip9->lpc, sizeof(chip9->lpc),
>                              TYPE_PNV9_LPC, &error_abort, NULL);
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson