[v8] Allow Valgrind checking all QEMU processes

[Qemu-devel] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

Andrey Shinkevich posted 6 patches 4 years, 7 months ago

Diff against v1 v2 v3 v4 v5 v6 v7
Download series mbox

Test docker-clang@ubuntu failed

Test FreeBSD passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1567588284-975381-1-git-send-email-andrey.shinkevich@virtuozzo.com

Maintainers: Max Reitz <mreitz@redhat.com>, Kevin Wolf <kwolf@redhat.com>

tests/qemu-iotests/028       |   6 ++-
tests/qemu-iotests/039       |   5 +++
tests/qemu-iotests/039.out   |  30 +++----------
tests/qemu-iotests/051       |   4 ++
tests/qemu-iotests/061       |   2 +
tests/qemu-iotests/061.out   |  12 +----
tests/qemu-iotests/137       |   1 +
tests/qemu-iotests/137.out   |   6 +--
tests/qemu-iotests/183       |   9 +++-
tests/qemu-iotests/192       |   6 ++-
tests/qemu-iotests/247       |   6 ++-
tests/qemu-iotests/common.rc | 105 +++++++++++++++++++++++++++++++++++--------
12 files changed, 130 insertions(+), 62 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

Posted by Andrey Shinkevich 4 years, 7 months ago

In the current implementation of the QEMU bash iotests, only qemu-io
processes may be run under the Valgrind with the switch '-valgrind'.
Let's allow the common.rc bash script running all other QEMU processes,
such as qemu-kvm, qemu-img, qemu-ndb and qemu-vxhs, under the Valgrind.

v8:
  01: Fix for the optimization made in v7 where the iotests 039 and 051
      did not pass being run under the Valgrind. NO_VALGRIND variable
      has been introduced to complete the optimization logic (patch 2/6).

  Discussed in the email threads with the message IDs:
  <1563553816-148827-1-git-send-email-andrey.shinkevich@virtuozzo.com>
  <1560276131-683243-1-git-send-email-andrey.shinkevich@virtuozzo.com>
  <1566834628-485525-1-git-send-email-andrey.shinkevich@virtuozzo.com>

Andrey Shinkevich (6):
  iotests: allow Valgrind checking all QEMU processes
  iotests: exclude killed processes from running under Valgrind
  iotests: Add casenotrun report to bash tests
  iotests: Valgrind fails with nonexistent directory
  iotests: extended timeout under Valgrind
  iotests: extend sleeping time under Valgrind

 tests/qemu-iotests/028       |   6 ++-
 tests/qemu-iotests/039       |   5 +++
 tests/qemu-iotests/039.out   |  30 +++----------
 tests/qemu-iotests/051       |   4 ++
 tests/qemu-iotests/061       |   2 +
 tests/qemu-iotests/061.out   |  12 +----
 tests/qemu-iotests/137       |   1 +
 tests/qemu-iotests/137.out   |   6 +--
 tests/qemu-iotests/183       |   9 +++-
 tests/qemu-iotests/192       |   6 ++-
 tests/qemu-iotests/247       |   6 ++-
 tests/qemu-iotests/common.rc | 105 +++++++++++++++++++++++++++++++++++--------
 12 files changed, 130 insertions(+), 62 deletions(-)

-- 
1.8.3.1

Re: [Qemu-devel] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

Posted by Kevin Wolf 4 years, 7 months ago

Am 04.09.2019 um 11:11 hat Andrey Shinkevich geschrieben:
> In the current implementation of the QEMU bash iotests, only qemu-io
> processes may be run under the Valgrind with the switch '-valgrind'.
> Let's allow the common.rc bash script running all other QEMU processes,
> such as qemu-kvm, qemu-img, qemu-ndb and qemu-vxhs, under the Valgrind.
> 
> v8:
>   01: Fix for the optimization made in v7 where the iotests 039 and 051
>       did not pass being run under the Valgrind. NO_VALGRIND variable
>       has been introduced to complete the optimization logic (patch 2/6).

Thanks, applied to the block branch.

Kevin

Re: [Qemu-devel] [PATCH v8 0/6] Allow Valgrind checking all QEMU processes

Posted by Andrey Shinkevich 4 years, 7 months ago


On 04/09/2019 16:44, Kevin Wolf wrote:
> Am 04.09.2019 um 11:11 hat Andrey Shinkevich geschrieben:
>> In the current implementation of the QEMU bash iotests, only qemu-io
>> processes may be run under the Valgrind with the switch '-valgrind'.
>> Let's allow the common.rc bash script running all other QEMU processes,
>> such as qemu-kvm, qemu-img, qemu-ndb and qemu-vxhs, under the Valgrind.
>>
>> v8:
>>    01: Fix for the optimization made in v7 where the iotests 039 and 051
>>        did not pass being run under the Valgrind. NO_VALGRIND variable
>>        has been introduced to complete the optimization logic (patch 2/6).
> 
> Thanks, applied to the block branch.
> 
> Kevin
> 

Thank you too, Kevin.

Andrey
-- 
With the best regards,
Andrey Shinkevich