Reduce the number of Valgrind reports in unit tests.

[Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

Andrey Shinkevich posted 3 patches 4 years, 8 months ago

Download series mbox

Test docker-clang@ubuntu passed

Test s390x passed

Test asan passed

Test docker-mingw@fedora passed

Test FreeBSD passed

Test checkpatch passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1564502498-805893-1-git-send-email-andrey.shinkevich@virtuozzo.com

Maintainers: Richard Henderson <rth@twiddle.net>, Alberto Garcia <berto@igalia.com>, Markus Armbruster <armbru@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Eduardo Habkost <ehabkost@redhat.com>

target/i386/kvm.c                 | 3 +++
tests/test-string-input-visitor.c | 8 +++-----
tests/test-throttle.c             | 2 ++
3 files changed, 8 insertions(+), 5 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

Posted by Andrey Shinkevich 4 years, 8 months ago

Running unit tests under the Valgrind may help to detect QEMU memory issues
(suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
unit test code itself. Let's eliminate the detected memory issues to ease
locating critical ones.

Andrey Shinkevich (3):
  test-throttle: Fix uninitialized use of burst_length
  tests: Fix uninitialized byte in test_visitor_in_fuzz
  i386/kvm: initialize struct at full before ioctl call

 target/i386/kvm.c                 | 3 +++
 tests/test-string-input-visitor.c | 8 +++-----
 tests/test-throttle.c             | 2 ++
 3 files changed, 8 insertions(+), 5 deletions(-)

-- 
1.8.3.1

Re: [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

Posted by Andrey Shinkevich 4 years, 8 months ago

PINGING...

On 30/07/2019 19:01, Andrey Shinkevich wrote:
> Running unit tests under the Valgrind may help to detect QEMU memory issues
> (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
> unit test code itself. Let's eliminate the detected memory issues to ease
> locating critical ones.
> 
> Andrey Shinkevich (3):
>    test-throttle: Fix uninitialized use of burst_length
>    tests: Fix uninitialized byte in test_visitor_in_fuzz
>    i386/kvm: initialize struct at full before ioctl call
> 
>   target/i386/kvm.c                 | 3 +++
>   tests/test-string-input-visitor.c | 8 +++-----
>   tests/test-throttle.c             | 2 ++
>   3 files changed, 8 insertions(+), 5 deletions(-)
> 

-- 
With the best regards,
Andrey Shinkevich

Re: [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

Posted by Paolo Bonzini 4 years, 8 months ago

On 13/08/19 14:02, Andrey Shinkevich wrote:
> PINGING...

I thought I had already said I queued the series?

Paolo

> On 30/07/2019 19:01, Andrey Shinkevich wrote:
>> Running unit tests under the Valgrind may help to detect QEMU memory issues
>> (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
>> unit test code itself. Let's eliminate the detected memory issues to ease
>> locating critical ones.
>>
>> Andrey Shinkevich (3):
>>    test-throttle: Fix uninitialized use of burst_length
>>    tests: Fix uninitialized byte in test_visitor_in_fuzz
>>    i386/kvm: initialize struct at full before ioctl call
>>
>>   target/i386/kvm.c                 | 3 +++
>>   tests/test-string-input-visitor.c | 8 +++-----
>>   tests/test-throttle.c             | 2 ++
>>   3 files changed, 8 insertions(+), 5 deletions(-)
>>
>

Re: [Qemu-devel] [PATCH 0/3] Reduce the number of Valgrind reports in unit tests.

Posted by Andrey Shinkevich 4 years, 8 months ago


On 13/08/2019 15:05, Paolo Bonzini wrote:
> On 13/08/19 14:02, Andrey Shinkevich wrote:
>> PINGING...
> 
> I thought I had already said I queued the series?
> 
> Paolo
> 

Thank you Paolo.
I am clear now.

Andrey

>> On 30/07/2019 19:01, Andrey Shinkevich wrote:
>>> Running unit tests under the Valgrind may help to detect QEMU memory issues
>>> (suggested by Denis V. Lunev). Some of the Valgrind reports relate to the
>>> unit test code itself. Let's eliminate the detected memory issues to ease
>>> locating critical ones.
>>>
>>> Andrey Shinkevich (3):
>>>     test-throttle: Fix uninitialized use of burst_length
>>>     tests: Fix uninitialized byte in test_visitor_in_fuzz
>>>     i386/kvm: initialize struct at full before ioctl call
>>>
>>>    target/i386/kvm.c                 | 3 +++
>>>    tests/test-string-input-visitor.c | 8 +++-----
>>>    tests/test-throttle.c             | 2 ++
>>>    3 files changed, 8 insertions(+), 5 deletions(-)
>>>
>>
> 

-- 
With the best regards,
Andrey Shinkevich