The set of patches include the block-related updates
of the record/replay icount feature:
 - application of 'snapshot' option on the file layer instead of
   the top one: command line and documentation fix
 - implementation of bdrv_snapshot_goto for blkreplay driver
 - start/stop fix in replay mode with attached block devices
 - record/replay of bh oneshot events, used in the block layer

These patches are rebased upon the following series:
https://lists.gnu.org/archive/html/qemu-devel/2019-07/msg05568.html

---

Pavel Dovgalyuk (6):
      block: implement bdrv_snapshot_goto for blkreplay
      replay: disable default snapshot for record/replay
      replay: update docs for record/replay with block devices
      replay: don't drain/flush bdrv queue while RR is working
      replay: finish record/replay before closing the disks
      replay: add BH oneshot event for block layer


 block/blkreplay.c        |    8 ++++++++
 block/block-backend.c    |    8 +++++---
 block/io.c               |   32 ++++++++++++++++++++++++++++++--
 block/iscsi.c            |    5 +++--
 block/nfs.c              |    5 +++--
 block/null.c             |    4 +++-
 block/nvme.c             |    6 ++++--
 block/rbd.c              |    5 +++--
 block/vxhs.c             |    5 +++--
 cpus.c                   |    2 --
 docs/replay.txt          |   12 +++++++++---
 include/sysemu/replay.h  |    3 +++
 replay/replay-events.c   |   16 ++++++++++++++++
 replay/replay-internal.h |    1 +
 replay/replay.c          |    4 +++-
 stubs/Makefile.objs      |    1 +
 stubs/replay-user.c      |    9 +++++++++
 vl.c                     |   11 +++++++++--
 18 files changed, 113 insertions(+), 24 deletions(-)
 create mode 100644 stubs/replay-user.c

-- 
Pavel Dovgalyuk

Patchew URL: https://patchew.org/QEMU/156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower/



Hi,

This series failed the asan build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
make docker-image-fedora V=1 NETWORK=1
time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1
=== TEST SCRIPT END ===

  CC      ui/x_keymap.o
  CC      ui/gtk.o
  CC      ui/curses.o
/tmp/qemu-test/src/replay/replay-events.c:141:23: error: implicit declaration of function 'replay_get_current_icount' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        uint64_t id = replay_get_current_icount();
                      ^
/tmp/qemu-test/src/replay/replay-events.c:141:23: note: did you mean 'replay_get_current_step'?
/tmp/qemu-test/src/include/sysemu/replay.h:78:10: note: 'replay_get_current_step' declared here
uint64_t replay_get_current_step(void);
         ^
/tmp/qemu-test/src/replay/replay-events.c:141:23: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes]
        uint64_t id = replay_get_current_icount();
                      ^
2 errors generated.


The full log is available at
http://patchew.org/logs/156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower/testing.asan/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Patchew URL: https://patchew.org/QEMU/156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa

echo
echo "=== UNAME ==="
uname -a

CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
=== TEST SCRIPT END ===

  CC      replay/replay-snapshot.o
  CC      replay/replay-net.o
/var/tmp/patchew-tester-tmp-z2gfg7al/src/replay/replay-events.c: In function ‘replay_bh_schedule_oneshot_event’:
/var/tmp/patchew-tester-tmp-z2gfg7al/src/replay/replay-events.c:141:23: error: implicit declaration of function ‘replay_get_current_icount’; did you mean ‘replay_get_current_step’? [-Werror=implicit-function-declaration]
  141 |         uint64_t id = replay_get_current_icount();
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                       replay_get_current_step
/var/tmp/patchew-tester-tmp-z2gfg7al/src/replay/replay-events.c:141:23: error: nested extern declaration of ‘replay_get_current_icount’ [-Werror=nested-externs]
cc1: all warnings being treated as errors
make: *** [/var/tmp/patchew-tester-tmp-z2gfg7al/src/rules.mak:69: replay/replay-events.o] Error 1
make: *** Waiting for unfinished jobs....


The full log is available at
http://patchew.org/logs/156438176555.22071.10523120047318890136.stgit@pasha-Precision-3630-Tower/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com