[v2] Only enable the halt poll control MSR if it is supported by the host

[Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host

Posted by Mark Kanda 4 years, 9 months ago

The halt poll control MSR should only be enabled on hosts which
support it.

Fixes: ("kvm: i386: halt poll control MSR support")

Signed-off-by: Mark Kanda <mark.kanda@oracle.com>

---
v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
---
 target/i386/cpu.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target/i386/cpu.c b/target/i386/cpu.c
index a8bafdb8b9..543bc25f64 100644
--- a/target/i386/cpu.c
+++ b/target/i386/cpu.c
@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
     { "kvm-asyncpf", "on" },
     { "kvm-steal-time", "on" },
     { "kvm-pv-eoi", "on" },
-    { "kvm-poll-control", "on" },
     { "kvmclock-stable-bit", "on" },
     { "x2apic", "on" },
     { "acpi", "off" },
-- 
2.21.0

Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host

Posted by Mark Kanda 4 years, 8 months ago

Gentle ping - I would like to confirm this patch is acceptable.

Thanks/regards,
-Mark

On 7/17/2019 9:38 AM, Mark Kanda wrote:
> The halt poll control MSR should only be enabled on hosts which
> support it.
> 
> Fixes: ("kvm: i386: halt poll control MSR support")
> 
> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> 
> ---
> v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
> ---
>   target/i386/cpu.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> index a8bafdb8b9..543bc25f64 100644
> --- a/target/i386/cpu.c
> +++ b/target/i386/cpu.c
> @@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
>       { "kvm-asyncpf", "on" },
>       { "kvm-steal-time", "on" },
>       { "kvm-pv-eoi", "on" },
> -    { "kvm-poll-control", "on" },
>       { "kvmclock-stable-bit", "on" },
>       { "x2apic", "on" },
>       { "acpi", "off" },
>

Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host

Posted by Paolo Bonzini 4 years, 7 months ago

On 28/08/19 19:22, Mark Kanda wrote:
> Gentle ping - I would like to confirm this patch is acceptable.

Yes, it was squashed in Marcelo's patch (commit
d645e1328726b38b3c79525eb57842ce29c1df7c).

Paolo

> Thanks/regards,
> -Mark
> 
> On 7/17/2019 9:38 AM, Mark Kanda wrote:
>> The halt poll control MSR should only be enabled on hosts which
>> support it.
>>
>> Fixes: ("kvm: i386: halt poll control MSR support")
>>
>> Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
>>
>> ---
>> v2: Remove unnecessary hunks which break migration with older hosts
>> (Paolo)
>> ---
>>   target/i386/cpu.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/target/i386/cpu.c b/target/i386/cpu.c
>> index a8bafdb8b9..543bc25f64 100644
>> --- a/target/i386/cpu.c
>> +++ b/target/i386/cpu.c
>> @@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
>>       { "kvm-asyncpf", "on" },
>>       { "kvm-steal-time", "on" },
>>       { "kvm-pv-eoi", "on" },
>> -    { "kvm-poll-control", "on" },
>>       { "kvmclock-stable-bit", "on" },
>>       { "x2apic", "on" },
>>       { "acpi", "off" },
>>

Re: [Qemu-devel] [PATCH-for-4.2 v2] Only enable the halt poll control MSR if it is supported by the host

Posted by Marcelo Tosatti 4 years, 8 months ago

On Wed, Aug 28, 2019 at 12:22:59PM -0500, Mark Kanda wrote:
> Gentle ping - I would like to confirm this patch is acceptable.
> 
> Thanks/regards,
> -Mark

ACK

> 
> On 7/17/2019 9:38 AM, Mark Kanda wrote:
> >The halt poll control MSR should only be enabled on hosts which
> >support it.
> >
> >Fixes: ("kvm: i386: halt poll control MSR support")
> >
> >Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> >
> >---
> >v2: Remove unnecessary hunks which break migration with older hosts (Paolo)
> >---
> >  target/i386/cpu.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> >diff --git a/target/i386/cpu.c b/target/i386/cpu.c
> >index a8bafdb8b9..543bc25f64 100644
> >--- a/target/i386/cpu.c
> >+++ b/target/i386/cpu.c
> >@@ -2838,7 +2838,6 @@ static PropValue kvm_default_props[] = {
> >      { "kvm-asyncpf", "on" },
> >      { "kvm-steal-time", "on" },
> >      { "kvm-pv-eoi", "on" },
> >-    { "kvm-poll-control", "on" },
> >      { "kvmclock-stable-bit", "on" },
> >      { "x2apic", "on" },
> >      { "acpi", "off" },
> >