linux-user/generic/fcntl.h | 8 +-- linux-user/mips/cpu_loop.c | 17 ++++++ linux-user/mips/target_fcntl.h | 17 +++++- linux-user/strace.c | 86 +++++++++++++++++++++++++++++++ linux-user/strace.list | 3 ++ linux-user/syscall.c | 114 ++++++++++++++++++++++++++++++++++++++++- linux-user/syscall_defs.h | 37 +++++++++++++ 7 files changed, 276 insertions(+), 6 deletions(-)
From: Aleksandar Markovic <amarkovic@wavecomp.com>
This is a collection of misc patches for Linux user that I recently
accumulated from variuous sources. All of them originate from problems
observed on mips target. However, most of these changes actually
affect and fix linux-user problems on multiple targets.
There are three checkpatch warninhs and two checkpatch errors that
sould be ignored in the given circumstances.
NOTE: Two checkpatch errors and three warnings are false alarms.
v14->v15:
- removed inclusion of sys/stat.h from patch #1
- a minor correction in the commit message for patch #3
- amended patch #5 to reflect the kernel behavior wrt FPE
v13->v14:
- several minor corrections in commit messages
v12->v13:
- removed two patches that got accepted
- simplified the patch on statx()
- added a patch on TARGET_HAVE_ARCH_STRUCT_FLOCK
- added a patch on fixing EXCP_FPE handling on MIPS
v11->v12:
- used the preffered Laurent's email address for linux-user
- added a note on checkpetch warnings and errors in the commit letter
v10->v11:
- patch on <ADD|DROP>_MEMEBERSHIP basically reverted to its first
version
- corrected patch on statx()
- added patch on strace support for statx()
- added patch on fixing flock structure for MIPS O64 ABI
v9->v10:
- improved commit messages for patches 2 and 3
v8->v9:
- fixed build error on some systems related to SOL_ALG
v7->v8:
- added a patch on setsockopt() option SOL_ALG
v6->v7:
- fixed a build error for older kernels related to the patch on
setsockopt() options
- removed four patches that on the meantime got accepted into the
main source tree
v5->v6:
- fixed a mistake in patch #4
- improved commit messages in patches #4 and #6
v4->v5:
- added the patch on statx() support
- improved the patch on IPV6_<ADD|DROP>_MEMBERSHIP to take into
account the possibility of different names for a field
- minor corrections in commit messages
v3->v4:
- improved commit messages (fixed some typos, improved relevance)
v2->v3:
- updated and improved commit messages
- added IPV6_DROP_MEMBERSHIP support to the patch on setsockopt()'s
option
v1->v2:
- added the patch on setsockopt()'s option IPV6_ADD_MEMBERSHIP
- improved the commit messages
Aleksandar Markovic (3):
linux-user: Fix target_flock structure for MIPS O64 ABI
linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK
linux-user: Handle EXCP_FPE properly for MIPS
Aleksandar Rikalo (1):
linux-user: Add support for translation of statx() syscall
Jim Wilson (1):
linux-user: Add support for strace for statx() syscall
linux-user/generic/fcntl.h | 8 +--
linux-user/mips/cpu_loop.c | 17 ++++++
linux-user/mips/target_fcntl.h | 17 +++++-
linux-user/strace.c | 86 +++++++++++++++++++++++++++++++
linux-user/strace.list | 3 ++
linux-user/syscall.c | 114 ++++++++++++++++++++++++++++++++++++++++-
linux-user/syscall_defs.h | 37 +++++++++++++
7 files changed, 276 insertions(+), 6 deletions(-)
--
2.7.4
Patchew URL: https://patchew.org/QEMU/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com
Type: series
Subject: [Qemu-devel] [PATCH v15 0/5] linux-user: A set of miscellaneous patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
* [new tag] patchew/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com -> patchew/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com
Switched to a new branch 'test'
7a91f2ac4c linux-user: Handle EXCP_FPE properly for MIPS
569ce4b0b7 linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK
819bdffd01 linux-user: Fix target_flock structure for MIPS O64 ABI
b1f7d32d9a linux-user: Add support for strace for statx() syscall
00cca0ba1d linux-user: Add support for translation of statx() syscall
=== OUTPUT BEGIN ===
1/5 Checking commit 00cca0ba1dae (linux-user: Add support for translation of statx() syscall)
WARNING: architecture specific defines should be avoided
#53: FILE: linux-user/syscall.c:321:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)
WARNING: architecture specific defines should be avoided
#65: FILE: linux-user/syscall.c:6478:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)
WARNING: architecture specific defines should be avoided
#135: FILE: linux-user/syscall.c:10188:
+#if defined(__NR_statx)
total: 0 errors, 3 warnings, 179 lines checked
Patch 1/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit b1f7d32d9a70 (linux-user: Add support for strace for statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {
ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {
total: 2 errors, 0 warnings, 104 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 819bdffd0139 (linux-user: Fix target_flock structure for MIPS O64 ABI)
4/5 Checking commit 569ce4b0b746 (linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK)
5/5 Checking commit 7a91f2ac4c93 (linux-user: Handle EXCP_FPE properly for MIPS)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/
Hi,
This series failed build test on s390x host. Please find the details below.
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install
echo
echo "=== ENV ==="
env
echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===
CC microblaze-linux-user/linux-user/strace.o
CC mips64el-linux-user/linux-user/syscall.o
LINK microblazeel-linux-user/qemu-microblazeel
/var/tmp/patchew-tester-tmp-tr0wvoyz/src/linux-user/syscall.c:322:16: error: conflicting types for ‘statx’
322 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, flags,
| ^~~~~
/var/tmp/patchew-tester-tmp-tr0wvoyz/src/linux-user/syscall.c:213:13: note: in definition of macro ‘_syscall5’
The full log is available at
http://patchew.org/logs/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Dear Patchew developers, Le 28/06/2019 à 11:49, no-reply@patchew.org a écrit : > Patchew URL: https://patchew.org/QEMU/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/ > > > > Hi, > > This series failed build test on s390x host. Please find the details below. To debug this kind of problem (at least to reproduce it), it may be interesting to know the OS release of the target build environment (glibc version, gcc version, ...) on which the build fails. Is this possible to add this in the mail (or in the logs)? ... > CC microblaze-linux-user/linux-user/strace.o > CC mips64el-linux-user/linux-user/syscall.o > LINK microblazeel-linux-user/qemu-microblazeel > /var/tmp/patchew-tester-tmp-tr0wvoyz/src/linux-user/syscall.c:322:16: error: conflicting types for ‘statx’ > 322 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, flags, > | ^~~~~ > /var/tmp/patchew-tester-tmp-tr0wvoyz/src/linux-user/syscall.c:213:13: note: in definition of macro ‘_syscall5’ Thanks, Laurent _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel
On Fri, 06/28 14:15, Laurent Vivier wrote: > Dear Patchew developers, > > Le 28/06/2019 à 11:49, no-reply@patchew.org a écrit : > > Patchew URL: https://patchew.org/QEMU/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/ > > > > > > > > Hi, > > > > This series failed build test on s390x host. Please find the details below. > > To debug this kind of problem (at least to reproduce it), it may be > interesting to know the OS release of the target build environment > (glibc version, gcc version, ...) on which the build fails. > > Is this possible to add this in the mail (or in the logs)? I've moved the env/rpm/uname commands before the actual testing commands, so the information can be collected even upon failures. Fam > > ... > > CC microblaze-linux-user/linux-user/strace.o > > CC mips64el-linux-user/linux-user/syscall.o > > LINK microblazeel-linux-user/qemu-microblazeel > > /var/tmp/patchew-tester-tmp-tr0wvoyz/src/linux-user/syscall.c:322:16: error: conflicting types for ‘statx’ > > 322 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, flags, > > | ^~~~~ > > /var/tmp/patchew-tester-tmp-tr0wvoyz/src/linux-user/syscall.c:213:13: note: in definition of macro ‘_syscall5’ > > Thanks, > Laurent > > _______________________________________________ > Patchew-devel mailing list > Patchew-devel@redhat.com > https://www.redhat.com/mailman/listinfo/patchew-devel _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel
Le 28/06/2019 à 14:41, Fam Zheng a écrit : > On Fri, 06/28 14:15, Laurent Vivier wrote: >> Dear Patchew developers, >> >> Le 28/06/2019 à 11:49, no-reply@patchew.org a écrit : >>> Patchew URL: https://patchew.org/QEMU/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/ >>> >>> >>> >>> Hi, >>> >>> This series failed build test on s390x host. Please find the details below. >> >> To debug this kind of problem (at least to reproduce it), it may be >> interesting to know the OS release of the target build environment >> (glibc version, gcc version, ...) on which the build fails. >> >> Is this possible to add this in the mail (or in the logs)? > > I've moved the env/rpm/uname commands before the actual testing commands, so > the information can be collected even upon failures. Thank you Fam. >From the v16 log, I can see s390x runs Fedora 30 (v15 works fine on debian/sid s390x) Laurent _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel
> I've moved the env/rpm/uname commands before the actual testing commands, so > the information can be collected even upon failures. Would it be hard for you to capture output of the command "ldd --version" and include it early in the log? That would be sufficient for us to deduce "glibc version". Thanks, Aleksandar _______________________________________________ Patchew-devel mailing list Patchew-devel@redhat.com https://www.redhat.com/mailman/listinfo/patchew-devel
Patchew URL: https://patchew.org/QEMU/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com
Type: series
Subject: [Qemu-devel] [PATCH v15 0/5] linux-user: A set of miscellaneous patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
From https://github.com/patchew-project/qemu
- [tag update] patchew/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com -> patchew/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com
Switched to a new branch 'test'
8e36bc8 linux-user: Handle EXCP_FPE properly for MIPS
8d588de linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK
9f12ce3 linux-user: Fix target_flock structure for MIPS O64 ABI
c3af4f1 linux-user: Add support for strace for statx() syscall
b00199b linux-user: Add support for translation of statx() syscall
=== OUTPUT BEGIN ===
1/5 Checking commit b00199b2c730 (linux-user: Add support for translation of statx() syscall)
WARNING: architecture specific defines should be avoided
#53: FILE: linux-user/syscall.c:321:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)
WARNING: architecture specific defines should be avoided
#65: FILE: linux-user/syscall.c:6478:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)
WARNING: architecture specific defines should be avoided
#135: FILE: linux-user/syscall.c:10188:
+#if defined(__NR_statx)
total: 0 errors, 3 warnings, 179 lines checked
Patch 1/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/5 Checking commit c3af4f1f9421 (linux-user: Add support for strace for statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {
ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {
total: 2 errors, 0 warnings, 104 lines checked
Patch 2/5 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/5 Checking commit 9f12ce370693 (linux-user: Fix target_flock structure for MIPS O64 ABI)
4/5 Checking commit 8d588de6f092 (linux-user: Introduce TARGET_HAVE_ARCH_STRUCT_FLOCK)
5/5 Checking commit 8e36bc871a28 (linux-user: Handle EXCP_FPE properly for MIPS)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/1561712082-31441-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
© 2016 - 2024 Red Hat, Inc.