[v12] | Patchew

[Qemu-devel] [PATCH v12 0/5]

Posted by Aleksandar Markovic 4 years, 10 months ago

From: Aleksandar Markovic <amarkovic@wavecomp.com>

This is a collection of misc patches for Linux user that I recently
accumulated from variuous sources. All of them originate from problems
observed on mips target. However, most of these changes actually
affect and fix linux-user problems on multiple targets.

There are three checkpatch warninhs and two checkpatch errors that
sould be ignored in the given circumstances.

v11->v12:

  - used the preffered Laurent's email address for linux-user
  - added a note on checkpetch warnings and errors in the commit letter
 

v10->v11:

  - patch on <ADD|DROP>_MEMEBERSHIP basically reverted to its first
    version
  - corrected patch on statx()
  - added patch on strace support for statx()
  - added patch on fixing flock structure for MIPS O64 ABI

v9->v10:

  - improved commit messages for patches 2 and 3

v8->v9:

  - fixed build error on some systems related to SOL_ALG

v7->v8:

  - added a patch on setsockopt() option SOL_ALG

v6->v7:

  - fixed a build error for older kernels related to the patch on
    setsockopt() options
  - removed four patches that on the meantime got accepted into the
    main source tree

v5->v6:

  - fixed a mistake in patch #4
  - improved commit messages in patches #4 and #6

v4->v5:

  - added the patch on statx() support
  - improved the patch on IPV6_<ADD|DROP>_MEMBERSHIP to take into
    account the possibility of different names for a field
  - minor corrections in commit messages

v3->v4:

  - improved commit messages (fixed some typos, improved relevance)

v2->v3:

  - updated and improved commit messages
  - added IPV6_DROP_MEMBERSHIP support to the patch on setsockopt()'s
    option

v1->v2:

  - added the patch on setsockopt()'s option IPV6_ADD_MEMBERSHIP
  - improved the commit messages

Aleksandar Markovic (1):
  linux-user: Fix flock structure for MIPS O64 ABI

Aleksandar Rikalo (1):
  linux-user: Add support for translation of statx() syscall

Jim Wilson (1):
  linux-user: Add support for strace for statx() syscall

Neng Chen (1):
  linux-user: Add support for setsockopt() options
    IPV6_<ADD|DROP>_MEMBERSHIP

Yunqiang Su (1):
  linux-user: Add support for setsockopt() option SOL_ALG

 linux-user/generic/fcntl.h     |   2 +-
 linux-user/mips/target_fcntl.h |   4 +
 linux-user/strace.c            |  86 +++++++++++++++++++
 linux-user/strace.list         |   3 +
 linux-user/syscall.c           | 186 ++++++++++++++++++++++++++++++++++++++++-
 linux-user/syscall_defs.h      |  37 ++++++++
 6 files changed, 316 insertions(+), 2 deletions(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH v12 0/5]

Posted by no-reply@patchew.org 4 years, 10 months ago

Patchew URL: https://patchew.org/QEMU/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series failed build test on s390x host. Please find the details below.

=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under the git checkout with
# HEAD pointing to a commit that has the patches applied on top of "base"
# branch
set -e
CC=$HOME/bin/cc
INSTALL=$PWD/install
BUILD=$PWD/build
mkdir -p $BUILD $INSTALL
SRC=$PWD
cd $BUILD
$SRC/configure --cc=$CC --prefix=$INSTALL
make -j4
# XXX: we need reliable clean up
# make check -j4 V=1
make install

echo
echo "=== ENV ==="
env

echo
echo "=== PACKAGES ==="
rpm -qa
=== TEST SCRIPT END ===

  CC      mips64el-linux-user/linux-user/syscall.o
  CC      mips64-linux-user/accel/tcg/user-exec-stub.o
  CC      mips64-linux-user/linux-user/main.o
/var/tmp/patchew-tester-tmp-o2hme1xk/src/linux-user/syscall.c:324:16: error: conflicting types for ‘statx’
  324 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, flags,
      |                ^~~~~
/var/tmp/patchew-tester-tmp-o2hme1xk/src/linux-user/syscall.c:215:13: note: in definition of macro ‘_syscall5’
---
  CC      microblaze-linux-user/disas.o
  CC      mips64-linux-user/linux-user/syscall.o
  CC      mips64-linux-user/linux-user/strace.o
/var/tmp/patchew-tester-tmp-o2hme1xk/src/linux-user/syscall.c:324:16: error: conflicting types for ‘statx’
  324 | _syscall5(int, statx, int, dirfd, const char *, pathname, int, flags,
      |                ^~~~~
/var/tmp/patchew-tester-tmp-o2hme1xk/src/linux-user/syscall.c:215:13: note: in definition of macro ‘_syscall5’


The full log is available at
http://patchew.org/logs/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.s390x/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v12 0/5]

Posted by no-reply@patchew.org 4 years, 10 months ago

Patchew URL: https://patchew.org/QEMU/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v12 0/5]
Type: series
Message-id: 1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com -> patchew/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com
Switched to a new branch 'test'
da94588f68 linux-user: Fix flock structure for MIPS O64 ABI
61a9980aca linux-user: Add support for strace for statx() syscall
5058c9cfc7 linux-user: Add support for translation of statx() syscall
7b71d1b65a linux-user: Add support for setsockopt() option SOL_ALG
174903e7a9 linux-user: Add support for setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP

=== OUTPUT BEGIN ===
1/5 Checking commit 174903e7a97c (linux-user: Add support for setsockopt() options IPV6_<ADD|DROP>_MEMBERSHIP)
2/5 Checking commit 7b71d1b65a34 (linux-user: Add support for setsockopt() option SOL_ALG)
3/5 Checking commit 5058c9cfc7de (linux-user: Add support for translation of statx() syscall)
WARNING: architecture specific defines should be avoided
#60: FILE: linux-user/syscall.c:323:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#72: FILE: linux-user/syscall.c:6529:
+#if defined(TARGET_NR_statx) && defined(__NR_statx)

WARNING: architecture specific defines should be avoided
#142: FILE: linux-user/syscall.c:10239:
+#if defined(__NR_statx)

total: 0 errors, 3 warnings, 207 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/5 Checking commit 61a9980acaf8 (linux-user: Add support for strace for statx() syscall)
ERROR: storage class should be at the beginning of the declaration
#27: FILE: linux-user/strace.c:979:
+UNUSED static struct flags statx_flags[] = {

ERROR: storage class should be at the beginning of the declaration
#49: FILE: linux-user/strace.c:1001:
+UNUSED static struct flags statx_mask[] = {

total: 2 errors, 0 warnings, 104 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit da94588f687d (linux-user: Fix flock structure for MIPS O64 ABI)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1560953834-29584-1-git-send-email-aleksandar.markovic@rt-rk.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com