xics: Add comment about CPU hotplug

[Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

Greg Kurz posted 1 patch 6 years, 4 months ago

Download mbox

Test s390x passed

Test checkpatch passed

Test asan passed

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test FreeBSD passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/156078063349.435533.12283208810037409702.stgit@bahia.lan

Maintainers: David Gibson <david@gibson.dropbear.id.au>

hw/intc/xics.c |    1 +
1 file changed, 1 insertion(+)

Expand all Fold all

[Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

Posted by Greg Kurz 6 years, 4 months ago

So that no one is tempted to drop that code, which is never called
for cold plugged CPUs.

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 hw/intc/xics.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index 8535e583dd41..faa976e2f8a8 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp)
         return;
     }
 
+    /* Connect the presenter to the VCPU (required for CPU hotplug) */
     if (kvm_irqchip_in_kernel()) {
         icp_kvm_realize(dev, &err);
         if (err) {

Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

Posted by David Gibson 6 years, 4 months ago

On Mon, Jun 17, 2019 at 04:10:33PM +0200, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>

Applied, thanks.

> ---
>  hw/intc/xics.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index 8535e583dd41..faa976e2f8a8 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -363,6 +363,7 @@ static void icp_realize(DeviceState *dev, Error **errp)
>          return;
>      }
>  
> +    /* Connect the presenter to the VCPU (required for CPU hotplug) */
>      if (kvm_irqchip_in_kernel()) {
>          icp_kvm_realize(dev, &err);
>          if (err) {
> 

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Re: [Qemu-devel] [PATCH] xics: Add comment about CPU hotplug

Posted by Cédric Le Goater 6 years, 4 months ago

On 17/06/2019 16:10, Greg Kurz wrote:
> So that no one is tempted to drop that code, which is never called
> for cold plugged CPUs.
> 
> Signed-off-by: Greg Kurz <groug@kaod.org>


Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.