[v1] docs: smbios: remove family=x from type2 entry description

[Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description

Igor Mammedov posted 1 patch 6 years, 5 months ago

Diff against v2
Download mbox

Test docker-clang@ubuntu passed

Test asan passed

Test checkpatch passed

Test docker-mingw@fedora passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1558444486-314511-1-git-send-email-imammedo@redhat.com

There is a newer version of this series

qemu-options.hx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Expand all Fold all

[Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description

Posted by Igor Mammedov 6 years, 5 months ago

'family' option is not part of type 2 table and if user tries to use it
as such QEMU will error out with an unknow option error.
Drop it from docs lest it confuse users.

Fixes: b155eb1d04
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 5daa5a8..dcdb808 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
 @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
 Specify SMBIOS type 1 fields
 
-@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
+@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
 Specify SMBIOS type 2 fields
 
 @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
-- 
2.7.4

Re: [Qemu-devel] [PATCH] docs: smbios: remove family=x from type2 entry description

Posted by Michael S. Tsirkin 6 years, 5 months ago

On Tue, May 21, 2019 at 03:14:46PM +0200, Igor Mammedov wrote:
> 'family' option is not part of type 2 table and if user tries to use it
> as such QEMU will error out with an unknow option error.
> Drop it from docs lest it confuse users.
> 
> Fixes: b155eb1d04

Add summary after the hash within ("...") please.

> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 5daa5a8..dcdb808 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2080,7 +2080,7 @@ Specify SMBIOS type 0 fields
>  @item -smbios type=1[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,uuid=@var{uuid}][,sku=@var{str}][,family=@var{str}]
>  Specify SMBIOS type 1 fields
>  
> -@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}][,family=@var{str}]
> +@item -smbios type=2[,manufacturer=@var{str}][,product=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,location=@var{str}]
>  Specify SMBIOS type 2 fields
>  
>  @item -smbios type=3[,manufacturer=@var{str}][,version=@var{str}][,serial=@var{str}][,asset=@var{str}][,sku=@var{str}]
> -- 
> 2.7.4