migration: Fix typo in migrate_add_blocker() error message

[Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message

Posted by Greg Kurz 4 years, 11 months ago

Signed-off-by: Greg Kurz <groug@kaod.org>
---
 migration/migration.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/migration/migration.c b/migration/migration.c
index 609e0df5d0c0..c15e75e0eebe 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
     if (only_migratable) {
         error_propagate_prepend(errp, error_copy(reason),
                                 "disallowing migration blocker "
-                                "(--only_migratable) for: ");
+                                "(--only-migratable) for: ");
         return -EACCES;
     }

Re: [Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message

Posted by Stefano Garzarella 4 years, 11 months ago

On Thu, May 16, 2019 at 12:58:05PM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  migration/migration.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
>      if (only_migratable) {
>          error_propagate_prepend(errp, error_copy(reason),
>                                  "disallowing migration blocker "
> -                                "(--only_migratable) for: ");
> +                                "(--only-migratable) for: ");
>          return -EACCES;
>      }

Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] migration: Fix typo in migrate_add_blocker() error message

Posted by Laurent Vivier 4 years, 11 months ago

On 16/05/2019 12:58, Greg Kurz wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>   migration/migration.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
>       if (only_migratable) {
>           error_propagate_prepend(errp, error_copy(reason),
>                                   "disallowing migration blocker "
> -                                "(--only_migratable) for: ");
> +                                "(--only-migratable) for: ");
>           return -EACCES;
>       }
>   
> 
> 

Applied to my trivial-patches branch.

Thanks,
Laurent

Re: [Qemu-devel] [PATCH] migration: Fix typo in migrate_add_blocker() error message

Posted by Dr. David Alan Gilbert 4 years, 11 months ago

* Greg Kurz (groug@kaod.org) wrote:
> Signed-off-by: Greg Kurz <groug@kaod.org>
> ---
>  migration/migration.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/migration.c b/migration/migration.c
> index 609e0df5d0c0..c15e75e0eebe 100644
> --- a/migration/migration.c
> +++ b/migration/migration.c
> @@ -1714,7 +1714,7 @@ int migrate_add_blocker(Error *reason, Error **errp)
>      if (only_migratable) {
>          error_propagate_prepend(errp, error_copy(reason),
>                                  "disallowing migration blocker "
> -                                "(--only_migratable) for: ");
> +                                "(--only-migratable) for: ");

Thanks.
Trivial: Please take this.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>          return -EACCES;
>      }
>  
> 
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK