[Qemu-devel] [PATCH v3 0/7] Leon3 patches

KONRAD Frederic posted 7 patches 9 weeks ago
Test docker-clang@ubuntu passed
Test asan passed
Test docker-mingw@fedora passed
Test checkpatch passed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1557923493-4836-1-git-send-email-frederic.konrad@adacore.com
Maintainers: Fabien Chouteau <chouteau@adacore.com>, Paolo Bonzini <pbonzini@redhat.com>, Artyom Tarasenko <atar4qemu@gmail.com>, "Marc-André Lureau" <marcandre.lureau@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
MAINTAINERS                         |   3 +-
hw/char/grlib_apbuart.c             |   4 +-
hw/intc/grlib_irqmp.c               |   3 +-
hw/misc/Makefile.objs               |   2 +
hw/misc/grlib_ahb_apb_pnp.c         | 269 ++++++++++++++++++++++++++++++++++++
hw/sparc/leon3.c                    | 157 ++++++++++++++++++---
hw/timer/grlib_gptimer.c            |   4 +-
include/hw/misc/grlib_ahb_apb_pnp.h |  60 ++++++++
include/hw/sparc/grlib.h            |  78 +----------
9 files changed, 483 insertions(+), 97 deletions(-)
create mode 100644 hw/misc/grlib_ahb_apb_pnp.c
create mode 100644 include/hw/misc/grlib_ahb_apb_pnp.h

[Qemu-devel] [PATCH v3 0/7] Leon3 patches

Posted by KONRAD Frederic 9 weeks ago
Hi all,

Those are some little fixes for the leon3 machine:
  * The first patch makes an error message more friendly when no kernel / bios
    are provided.
  * The three next one remove the old-style create function as suggested by
    Mark.
  * The fifth part initializes the uart and the timer when no bios are
    provided.
  * The sixth part adds AHB and APB plug and play devices to allow to boot
    linux.
  * The last part adds myself to the MAINTAINERS for this board.

The test images are available here: https://www.gaisler.com/anonftp/linux/lin
ux-2.6/images/leon-linux-4.9/leon-linux-4.9-1.0/up/

Tested with:
  qemu-system-sparc -M leon3_generic --nographic --kernel image.ram

V2 -> V3:
  * rebased.
  * added patches 1, 2, 3, 4 as suggested by Mark.
  * fixed DEVICE_NATIVE_ENDIAN to DEVICE_BIG_ENDIAN in patch 6 as suggested by
    Mark.
  * added include/hw/*/grlib* to the MAINTAINED file as suggested by Mark.
V1 -> V2:
  * minor fixes in the first patch suggested by Philippe.

Regards,
Fred

KONRAD Frederic (7):
  leon3: fix the error message when no bios are provided
  grlib,irqmp: get rid of the old-style create function
  grlib,gptimer: get rid of the old-style create function
  grlib,apbuart: get rid of the old-style create function
  leon3: add a little bootloader
  leon3: introduce the plug and play mechanism
  MAINTAINERS: add myself for leon3

 MAINTAINERS                         |   3 +-
 hw/char/grlib_apbuart.c             |   4 +-
 hw/intc/grlib_irqmp.c               |   3 +-
 hw/misc/Makefile.objs               |   2 +
 hw/misc/grlib_ahb_apb_pnp.c         | 269 ++++++++++++++++++++++++++++++++++++
 hw/sparc/leon3.c                    | 157 ++++++++++++++++++---
 hw/timer/grlib_gptimer.c            |   4 +-
 include/hw/misc/grlib_ahb_apb_pnp.h |  60 ++++++++
 include/hw/sparc/grlib.h            |  78 +----------
 9 files changed, 483 insertions(+), 97 deletions(-)
 create mode 100644 hw/misc/grlib_ahb_apb_pnp.c
 create mode 100644 include/hw/misc/grlib_ahb_apb_pnp.h

-- 
1.8.3.1


Re: [Qemu-devel] [PATCH v3 0/7] Leon3 patches

Posted by Mark Cave-Ayland 9 weeks ago
On 15/05/2019 13:31, KONRAD Frederic wrote:

> Hi all,
> 
> Those are some little fixes for the leon3 machine:
>   * The first patch makes an error message more friendly when no kernel / bios
>     are provided.
>   * The three next one remove the old-style create function as suggested by
>     Mark.
>   * The fifth part initializes the uart and the timer when no bios are
>     provided.
>   * The sixth part adds AHB and APB plug and play devices to allow to boot
>     linux.
>   * The last part adds myself to the MAINTAINERS for this board.
> 
> The test images are available here: https://www.gaisler.com/anonftp/linux/lin
> ux-2.6/images/leon-linux-4.9/leon-linux-4.9-1.0/up/
> 
> Tested with:
>   qemu-system-sparc -M leon3_generic --nographic --kernel image.ram
> 
> V2 -> V3:
>   * rebased.
>   * added patches 1, 2, 3, 4 as suggested by Mark.
>   * fixed DEVICE_NATIVE_ENDIAN to DEVICE_BIG_ENDIAN in patch 6 as suggested by
>     Mark.
>   * added include/hw/*/grlib* to the MAINTAINED file as suggested by Mark.
> V1 -> V2:
>   * minor fixes in the first patch suggested by Philippe.
> 
> Regards,
> Fred
> 
> KONRAD Frederic (7):
>   leon3: fix the error message when no bios are provided
>   grlib,irqmp: get rid of the old-style create function
>   grlib,gptimer: get rid of the old-style create function
>   grlib,apbuart: get rid of the old-style create function
>   leon3: add a little bootloader
>   leon3: introduce the plug and play mechanism
>   MAINTAINERS: add myself for leon3
> 
>  MAINTAINERS                         |   3 +-
>  hw/char/grlib_apbuart.c             |   4 +-
>  hw/intc/grlib_irqmp.c               |   3 +-
>  hw/misc/Makefile.objs               |   2 +
>  hw/misc/grlib_ahb_apb_pnp.c         | 269 ++++++++++++++++++++++++++++++++++++
>  hw/sparc/leon3.c                    | 157 ++++++++++++++++++---
>  hw/timer/grlib_gptimer.c            |   4 +-
>  include/hw/misc/grlib_ahb_apb_pnp.h |  60 ++++++++
>  include/hw/sparc/grlib.h            |  78 +----------
>  9 files changed, 483 insertions(+), 97 deletions(-)
>  create mode 100644 hw/misc/grlib_ahb_apb_pnp.c
>  create mode 100644 include/hw/misc/grlib_ahb_apb_pnp.h

Thanks for sorting out the old-style functions, this version looks much better. I've
applied this to my qemu-sparc branch and will send a PR shortly.


ATB,

Mark.

Re: [Qemu-devel] [PATCH v3 0/7] Leon3 patches

Posted by KONRAD Frederic 9 weeks ago

Le 5/17/19 à 10:51 AM, Mark Cave-Ayland a écrit :
> On 15/05/2019 13:31, KONRAD Frederic wrote:
> 
>> Hi all,
>>
>> Those are some little fixes for the leon3 machine:
>>    * The first patch makes an error message more friendly when no kernel / bios
>>      are provided.
>>    * The three next one remove the old-style create function as suggested by
>>      Mark.
>>    * The fifth part initializes the uart and the timer when no bios are
>>      provided.
>>    * The sixth part adds AHB and APB plug and play devices to allow to boot
>>      linux.
>>    * The last part adds myself to the MAINTAINERS for this board.
>>
>> The test images are available here: https://www.gaisler.com/anonftp/linux/lin
>> ux-2.6/images/leon-linux-4.9/leon-linux-4.9-1.0/up/
>>
>> Tested with:
>>    qemu-system-sparc -M leon3_generic --nographic --kernel image.ram
>>
>> V2 -> V3:
>>    * rebased.
>>    * added patches 1, 2, 3, 4 as suggested by Mark.
>>    * fixed DEVICE_NATIVE_ENDIAN to DEVICE_BIG_ENDIAN in patch 6 as suggested by
>>      Mark.
>>    * added include/hw/*/grlib* to the MAINTAINED file as suggested by Mark.
>> V1 -> V2:
>>    * minor fixes in the first patch suggested by Philippe.
>>
>> Regards,
>> Fred
>>
>> KONRAD Frederic (7):
>>    leon3: fix the error message when no bios are provided
>>    grlib,irqmp: get rid of the old-style create function
>>    grlib,gptimer: get rid of the old-style create function
>>    grlib,apbuart: get rid of the old-style create function
>>    leon3: add a little bootloader
>>    leon3: introduce the plug and play mechanism
>>    MAINTAINERS: add myself for leon3
>>
>>   MAINTAINERS                         |   3 +-
>>   hw/char/grlib_apbuart.c             |   4 +-
>>   hw/intc/grlib_irqmp.c               |   3 +-
>>   hw/misc/Makefile.objs               |   2 +
>>   hw/misc/grlib_ahb_apb_pnp.c         | 269 ++++++++++++++++++++++++++++++++++++
>>   hw/sparc/leon3.c                    | 157 ++++++++++++++++++---
>>   hw/timer/grlib_gptimer.c            |   4 +-
>>   include/hw/misc/grlib_ahb_apb_pnp.h |  60 ++++++++
>>   include/hw/sparc/grlib.h            |  78 +----------
>>   9 files changed, 483 insertions(+), 97 deletions(-)
>>   create mode 100644 hw/misc/grlib_ahb_apb_pnp.c
>>   create mode 100644 include/hw/misc/grlib_ahb_apb_pnp.h
> 
> Thanks for sorting out the old-style functions, this version looks much better. I've

You're welcome!

> applied this to my qemu-sparc branch and will send a PR shortly.
> 
Great! Thanks!

Regards,
Fred

> 
> ATB,
> 
> Mark.
>