[Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c

Aleksandar Markovic posted 8 patches 6 years, 9 months ago
Maintainers: Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Markovic <amarkovic@wavecomp.com>, Aleksandar Rikalo <arikalo@wavecomp.com>
[Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c
Posted by Aleksandar Markovic 6 years, 9 months ago
From: Aleksandar Markovic <amarkovic@wavecomp.com>

Remove several minor checkpatch warnings and errors.

Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
---
 target/mips/lmi_helper.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/target/mips/lmi_helper.c b/target/mips/lmi_helper.c
index fb1245b..6c645cf 100644
--- a/target/mips/lmi_helper.c
+++ b/target/mips/lmi_helper.c
@@ -21,9 +21,11 @@
 #include "cpu.h"
 #include "exec/helper-proto.h"
 
-/* If the byte ordering doesn't matter, i.e. all columns are treated
-   identically, then this union can be used directly.  If byte ordering
-   does matter, we generally ignore dumping to memory.  */
+/*
+ * If the byte ordering doesn't matter, i.e. all columns are treated
+ * identically, then this union can be used directly.  If byte ordering
+ * does matter, we generally ignore dumping to memory.
+ */
 typedef union {
     uint8_t  ub[8];
     int8_t   sb[8];
-- 
2.7.4


Re: [Qemu-devel] [PATCH 6/8] target/mips: Clean up lmi_helper.c
Posted by Philippe Mathieu-Daudé 6 years, 9 months ago
On 4/23/19 1:29 PM, Aleksandar Markovic wrote:
> From: Aleksandar Markovic <amarkovic@wavecomp.com>
> 
> Remove several minor checkpatch warnings and errors.
> 
> Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com>
> ---
>  target/mips/lmi_helper.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/target/mips/lmi_helper.c b/target/mips/lmi_helper.c
> index fb1245b..6c645cf 100644
> --- a/target/mips/lmi_helper.c
> +++ b/target/mips/lmi_helper.c
> @@ -21,9 +21,11 @@
>  #include "cpu.h"
>  #include "exec/helper-proto.h"
>  
> -/* If the byte ordering doesn't matter, i.e. all columns are treated
> -   identically, then this union can be used directly.  If byte ordering
> -   does matter, we generally ignore dumping to memory.  */
> +/*
> + * If the byte ordering doesn't matter, i.e. all columns are treated
> + * identically, then this union can be used directly.  If byte ordering
> + * does matter, we generally ignore dumping to memory.
> + */
>  typedef union {
>      uint8_t  ub[8];
>      int8_t   sb[8];
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>