target/mips: Integer division by zero in MSA insturctions

[Qemu-devel] [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions

Mateja Marjanovic posted 2 patches 5 years ago

Download series mbox

Test docker-mingw@fedora passed

Test docker-clang@ubuntu passed

Test checkpatch passed

Test asan passed

Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1554129501-27175-1-git-send-email-mateja.marjanovic@rt-rk.com

Maintainers: Aleksandar Markovic <amarkovic@wavecomp.com>, Aurelien Jarno <aurelien@aurel32.net>, Aleksandar Rikalo <arikalo@wavecomp.com>

target/mips/msa_helper.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)

Expand all Fold all

[Qemu-devel] [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions

Posted by Mateja Marjanovic 5 years ago

From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>

Integer division by zero in MSA insturctions results in unpredictable
behaviour, but according to the hardware, it depends on the sign of
the dividend, or always returns the same value.

Mateja Marjanovic (2):
  target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed
  target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed

 target/mips/msa_helper.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

-- 
2.7.4

Re: [Qemu-devel] [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions

Posted by Aleksandar Markovic 5 years ago

> From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
> Subject: [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions
>

The title look incomplete and uninformative: it mentions "the division by zero"
- but what is done in this case? Is this an implementation of that case? Or fix?
Or something else?

The title should clearly and in a condensed form explain what is done in the
series.

> From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>
>
> Integer division by zero in MSA insturctions results in unpredictable
> behaviour, but according to the hardware, it depends on the sign of
> the dividend, or always returns the same value.
> 

This is a very unclear sentence.

A sentence that says that the series makes the behavior of QEMU
and the reference hardware the same in cases of division and modulus
operations with zero divisor is missing.

> Mateja Marjanovic (2):
>  target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed
>  target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed
>
> target/mips/msa_helper.c | 11 +++++++----
> 1 file changed, 7 insertions(+), 4 deletions(-)

Check spelling.

Thanks,
Aleksandar

Re: [Qemu-devel] [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions

Posted by Mateja Marjanovic 5 years ago

On 1.4.19. 19:43, Aleksandar Markovic wrote:
>> From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
>> Subject: [PATCH 0/2] target/mips: Integer division by zero in MSA insturctions
>>
> The title look incomplete and uninformative: it mentions "the division by zero"
> - but what is done in this case? Is this an implementation of that case? Or fix?
> Or something else?
>
> The title should clearly and in a condensed form explain what is done in the
> series.
Yes, you are right, it looks unclear, I will change it in v2.
>
>> From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>
>>
>> Integer division by zero in MSA insturctions results in unpredictable
>> behaviour, but according to the hardware, it depends on the sign of
>> the dividend, or always returns the same value.
>>
> This is a very unclear sentence.
>
> A sentence that says that the series makes the behavior of QEMU
> and the reference hardware the same in cases of division and modulus
> operations with zero divisor is missing.
I will change it and make it more clear and understandable in v2.
>
>> Mateja Marjanovic (2):
>>   target/mips: DIV_<U|S>.<B|H|W|D> MSA insturctions fixed
>>   target/mips: MOD_<U|S>.<B|H|W|D> MSA insturctions fixed
>>
>> target/mips/msa_helper.c | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
> Check spelling.
I will try to find some tool for that.
>
> Thanks,
> Aleksandar
Thanks,
Mateja