intel_iommu: Correct caching-mode error message

[Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

Posted by Alex Williamson 6 years, 10 months ago

If we try to use the intel-iommu device with vfio-pci devices without
caching mode enabled, we're told:

  qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable
  device assignment with IOMMU protection.

But to enable caching mode, the option is actually "caching-mode=on".

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---
 hw/i386/intel_iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index b90de6c66461..b62badd4f08d 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2919,7 +2919,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
     IntelIOMMUState *s = vtd_as->iommu_state;
 
     if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
-        error_report("We need to set caching-mode=1 for intel-iommu to enable "
+        error_report("We need to set caching-mode=on for intel-iommu to enable "
                      "device assignment with IOMMU protection.");
         exit(1);
     }

Re: [Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

Posted by Peter Xu 6 years, 10 months ago

On Tue, Mar 26, 2019 at 05:05:38PM -0600, Alex Williamson wrote:
> If we try to use the intel-iommu device with vfio-pci devices without
> caching mode enabled, we're told:
> 
>   qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable
>   device assignment with IOMMU protection.
> 
> But to enable caching mode, the option is actually "caching-mode=on".
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>

Reviewed-by: Peter Xu <peterx@redhat.com>

-- 
Peter Xu

Re: [Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

Posted by Philippe Mathieu-Daudé 6 years, 10 months ago

Le mer. 27 mars 2019 00:06, Alex Williamson <alex.williamson@redhat.com> a
écrit :

> If we try to use the intel-iommu device with vfio-pci devices without
> caching mode enabled, we're told:
>
>   qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to
> enable
>   device assignment with IOMMU protection.
>
> But to enable caching mode, the option is actually "caching-mode=on".
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>  hw/i386/intel_iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index b90de6c66461..b62badd4f08d 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2919,7 +2919,7 @@ static void
> vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
>      IntelIOMMUState *s = vtd_as->iommu_state;
>
>      if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
> -        error_report("We need to set caching-mode=1 for intel-iommu to
> enable "
> +        error_report("We need to set caching-mode=on for intel-iommu to
> enable "
>                       "device assignment with IOMMU protection.");
>          exit(1);
>      }
>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

>

Re: [Qemu-devel] [PATCH] intel_iommu: Correct caching-mode error message

Posted by Auger Eric 6 years, 10 months ago

Hi,

On 3/27/19 12:05 AM, Alex Williamson wrote:
> If we try to use the intel-iommu device with vfio-pci devices without
> caching mode enabled, we're told:
> 
>   qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable
>   device assignment with IOMMU protection.
> 
> But to enable caching mode, the option is actually "caching-mode=on".
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks

Eric

> ---
>  hw/i386/intel_iommu.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index b90de6c66461..b62badd4f08d 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2919,7 +2919,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
>      IntelIOMMUState *s = vtd_as->iommu_state;
>  
>      if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
> -        error_report("We need to set caching-mode=1 for intel-iommu to enable "
> +        error_report("We need to set caching-mode=on for intel-iommu to enable "
>                       "device assignment with IOMMU protection.");
>          exit(1);
>      }
> 
>

Re: [Qemu-devel] [Qemu-trivial] [PATCH] intel_iommu: Correct caching-mode error message

Posted by Laurent Vivier 6 years, 10 months ago

On 27/03/2019 00:05, Alex Williamson wrote:
> If we try to use the intel-iommu device with vfio-pci devices without
> caching mode enabled, we're told:
> 
>    qemu-system-x86_64: We need to set caching-mode=1 for intel-iommu to enable
>    device assignment with IOMMU protection.
> 
> But to enable caching mode, the option is actually "caching-mode=on".
> 
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
> ---
>   hw/i386/intel_iommu.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index b90de6c66461..b62badd4f08d 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -2919,7 +2919,7 @@ static void vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
>       IntelIOMMUState *s = vtd_as->iommu_state;
>   
>       if (!s->caching_mode && new & IOMMU_NOTIFIER_MAP) {
> -        error_report("We need to set caching-mode=1 for intel-iommu to enable "
> +        error_report("We need to set caching-mode=on for intel-iommu to enable "
>                        "device assignment with IOMMU protection.");
>           exit(1);
>       }
> 
> 

Reviewed-by: Laurent Vivier <laurent@vivier.eu>