From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>

While working on adding support for big endian hosts on QEMU for the
MSA instructions copy_u, copy_s and insert, I noticed there was some
unreachable code (copy_u.d doesn't exist), and some unnecessary code
(for instance, insert supports doublewords only on MIPS64)

v2:
 - Eliminate unreachable code in copy_u
 - Add preprocessing conditionals (if host is MIPS64, check that case)
   in copy_u, insert, fill. 

Mateja Marjanovic (7):
  target/mips: Fix <ld|st>.<b|h|w|d> MSA instructions for MIPS big
    endian host
  target/mips: Fix copy_s.<b|h|w> for MIPS big endian host
  target/mips: Fix copy_u.<b|h|w> for MIPS big endian host
  target/mips: Fix insert.<b|h|w> for MIPS big endian host
  target/mips: Eliminate unreachable case for MSA instructions copy_u
  target/mips: Eliminate unreachable case for MSA instructions insert
  target/mips: Eliminate unreachable case for MSA instructions fill

 target/mips/msa_helper.c | 30 +++++++++++++++---
 target/mips/op_helper.c  | 79 +++++++++++++++++++++++++++++++++---------------
 2 files changed, 81 insertions(+), 28 deletions(-)

-- 
2.7.4

> From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
> Subject: [PATCH v2 0/7] target/mips: Add support for MSA instructions on a big endian host
> 
> From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>
> 
> While working on adding support for big endian hosts on QEMU for the
> MSA instructions copy_u, copy_s and insert, I noticed there was some
> unreachable code (copy_u.d doesn't exist), and some unnecessary code
 >(for instance, insert supports doublewords only on MIPS64)

This cover letter covers your activity that is not the main body of the series.

The cover letter should be the description of the series, and this is not at all -
it lack desription of endian problems and their solutions in this series.

Aleksandar

On 25.3.19. 22:33, Aleksandar Markovic wrote:
>> From: Mateja Marjanovic <mateja.marjanovic@rt-rk.com>
>> Subject: [PATCH v2 0/7] target/mips: Add support for MSA instructions on a big endian host
>>
>> From: Mateja Marjanovic <Mateja.Marjanovic@rt-rk.com>
>>
>> While working on adding support for big endian hosts on QEMU for the
>> MSA instructions copy_u, copy_s and insert, I noticed there was some
>> unreachable code (copy_u.d doesn't exist), and some unnecessary code
>   >(for instance, insert supports doublewords only on MIPS64)
>
> This cover letter covers your activity that is not the main body of the series.
>
> The cover letter should be the description of the series, and this is not at all -
> it lack desription of endian problems and their solutions in this series.
It will be more descriptive in v3.
>
> Aleksandar
Mateja