[Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c

Jafar Abdi posted 4 patches 6 years, 10 months ago
Maintainers: "Daniel P. Berrangé" <berrange@redhat.com>, Stefan Berger <stefanb@linux.ibm.com>, Thomas Huth <thuth@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Laurent Vivier <lvivier@redhat.com>
[Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c
Posted by Jafar Abdi 6 years, 10 months ago
Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.

FALSE and TRUE (with capital letters) are the constants defined by glib for
being used with the "gboolean" type of glib. But some parts of the code also use
TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).

Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 authz/listfile.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/authz/listfile.c b/authz/listfile.c
index d457976..03eaf46 100644
--- a/authz/listfile.c
+++ b/authz/listfile.c
@@ -238,7 +238,7 @@ qauthz_list_file_init(Object *obj)
 
     authz->file_watch = -1;
 #ifdef CONFIG_INOTIFY1
-    authz->refresh = TRUE;
+    authz->refresh = true;
 #endif
 }
 
-- 
2.7.4


Re: [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c
Posted by Thomas Huth 6 years, 10 months ago
On 23/03/2019 15.26, Jafar Abdi wrote:
> Clean up wrong usage of FALSE and TRUE in places that use "bool" from stdbool.h.
> 
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code also use
> TRUE and FALSE for variables that are declared as "bool" (the type from <stdbool.h>).
> 
> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
> ---
>  authz/listfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/authz/listfile.c b/authz/listfile.c
> index d457976..03eaf46 100644
> --- a/authz/listfile.c
> +++ b/authz/listfile.c
> @@ -238,7 +238,7 @@ qauthz_list_file_init(Object *obj)
>  
>      authz->file_watch = -1;
>  #ifdef CONFIG_INOTIFY1
> -    authz->refresh = TRUE;
> +    authz->refresh = true;
>  #endif
>  }

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH V2 1/4] authz: fix usage of bool in listfile.c
Posted by Philippe Mathieu-Daudé 6 years, 10 months ago
Le sam. 23 mars 2019 15:27, Jafar Abdi <cafer.abdi@gmail.com> a écrit :

> Clean up wrong usage of FALSE and TRUE in places that use "bool" from
> stdbool.h.
>
> FALSE and TRUE (with capital letters) are the constants defined by glib for
> being used with the "gboolean" type of glib. But some parts of the code
> also use
> TRUE and FALSE for variables that are declared as "bool" (the type from
> <stdbool.h>).
>
> Signed-off-by: Jafar Abdi <cafer.abdi@gmail.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
>

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

---
>  authz/listfile.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/authz/listfile.c b/authz/listfile.c
> index d457976..03eaf46 100644
> --- a/authz/listfile.c
> +++ b/authz/listfile.c
> @@ -238,7 +238,7 @@ qauthz_list_file_init(Object *obj)
>
>      authz->file_watch = -1;
>  #ifdef CONFIG_INOTIFY1
> -    authz->refresh = TRUE;
> +    authz->refresh = true;
>  #endif
>  }
>
> --
> 2.7.4
>
>
>