[Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Jason J. Herne posted 15 patches 9 weeks ago
Test asan failed
Test docker-clang@ubuntu failed
Test docker-mingw@fedora passed
Test checkpatch failed
Patches applied successfully (tree, apply log)
git fetch https://github.com/patchew-project/qemu tags/patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Maintainers: Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, Cornelia Huck <cohuck@redhat.com>, Laurent Vivier <lvivier@redhat.com>, David Hildenbrand <david@redhat.com>, Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>, Richard Henderson <rth@twiddle.net>, Eric Farman <farman@linux.ibm.com>, Alex Williamson <alex.williamson@redhat.com>, Farhan Ali <alifm@linux.ibm.com>
MAINTAINERS                  |   2 +
docs/devel/s390-dasd-ipl.txt | 133 ++++++++++++++
hw/s390x/ipl.c               |  61 +++++--
hw/s390x/s390-ccw.c          |   9 +
hw/vfio/ccw.c                |   2 +-
include/hw/s390x/s390-ccw.h  |   1 +
include/hw/s390x/vfio-ccw.h  |  28 +++
pc-bios/s390-ccw/Makefile    |   2 +-
pc-bios/s390-ccw/cio.c       | 423 +++++++++++++++++++++++++++++++++++++++++++
pc-bios/s390-ccw/cio.h       | 270 +++++++++++++++++++++------
pc-bios/s390-ccw/dasd-ipl.c  | 249 +++++++++++++++++++++++++
pc-bios/s390-ccw/dasd-ipl.h  |  16 ++
pc-bios/s390-ccw/helper.h    |  31 ++++
pc-bios/s390-ccw/libc.h      |  11 ++
pc-bios/s390-ccw/main.c      | 161 ++++++++++------
pc-bios/s390-ccw/netboot.mak |   2 +-
pc-bios/s390-ccw/netmain.c   |   2 +
pc-bios/s390-ccw/s390-arch.h | 103 +++++++++++
pc-bios/s390-ccw/s390-ccw.h  |  10 +-
pc-bios/s390-ccw/start.S     |  29 +++
pc-bios/s390-ccw/virtio.c    |  81 +++------
tests/boot-serial-test.c     |   2 +-
22 files changed, 1431 insertions(+), 197 deletions(-)
create mode 100644 docs/devel/s390-dasd-ipl.txt
create mode 100644 include/hw/s390x/vfio-ccw.h
create mode 100644 pc-bios/s390-ccw/cio.c
create mode 100644 pc-bios/s390-ccw/dasd-ipl.c
create mode 100644 pc-bios/s390-ccw/dasd-ipl.h
create mode 100644 pc-bios/s390-ccw/helper.h
create mode 100644 pc-bios/s390-ccw/s390-arch.h

[Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by Jason J. Herne 9 weeks ago
This is to support booting from vfio-ccw dasd devices. We basically implement
the real hardware ipl procedure. This allows for booting Linux guests on
vfio-ccw devices.

vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl
channel programs dynamically modify themselves. Details on the ipl process and
how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt.

Changelog
==========
v5
- Whitespace changes and comments.
- Added newlines to printed strings in patch 15.

Jason J. Herne (15):
  s390 vfio-ccw: Add bootindex property and IPLB data
  s390-bios: decouple cio setup from virtio
  s390-bios: decouple common boot logic from virtio
  s390-bios: Extend find_dev() for non-virtio devices
  s390-bios: Factor finding boot device out of virtio code path
  s390-bios: Clean up cio.h
  s390-bios: Decouple channel i/o logic from virtio
  s390-bios: Map low core memory
  s390-bios: ptr2u32 and u32toptr
  s390-bios: Support for running format-0/1 channel programs
  s390-bios: cio error handling
  s390-bios: Refactor virtio to run channel programs via cio
  s390-bios: Use control unit type to determine boot method
  s390-bios: Add channel command codes/structs needed for dasd-ipl
  s390-bios: Support booting from real dasd device

 MAINTAINERS                  |   2 +
 docs/devel/s390-dasd-ipl.txt | 133 ++++++++++++++
 hw/s390x/ipl.c               |  61 +++++--
 hw/s390x/s390-ccw.c          |   9 +
 hw/vfio/ccw.c                |   2 +-
 include/hw/s390x/s390-ccw.h  |   1 +
 include/hw/s390x/vfio-ccw.h  |  28 +++
 pc-bios/s390-ccw/Makefile    |   2 +-
 pc-bios/s390-ccw/cio.c       | 423 +++++++++++++++++++++++++++++++++++++++++++
 pc-bios/s390-ccw/cio.h       | 270 +++++++++++++++++++++------
 pc-bios/s390-ccw/dasd-ipl.c  | 249 +++++++++++++++++++++++++
 pc-bios/s390-ccw/dasd-ipl.h  |  16 ++
 pc-bios/s390-ccw/helper.h    |  31 ++++
 pc-bios/s390-ccw/libc.h      |  11 ++
 pc-bios/s390-ccw/main.c      | 161 ++++++++++------
 pc-bios/s390-ccw/netboot.mak |   2 +-
 pc-bios/s390-ccw/netmain.c   |   2 +
 pc-bios/s390-ccw/s390-arch.h | 103 +++++++++++
 pc-bios/s390-ccw/s390-ccw.h  |  10 +-
 pc-bios/s390-ccw/start.S     |  29 +++
 pc-bios/s390-ccw/virtio.c    |  81 +++------
 tests/boot-serial-test.c     |   2 +-
 22 files changed, 1431 insertions(+), 197 deletions(-)
 create mode 100644 docs/devel/s390-dasd-ipl.txt
 create mode 100644 include/hw/s390x/vfio-ccw.h
 create mode 100644 pc-bios/s390-ccw/cio.c
 create mode 100644 pc-bios/s390-ccw/dasd-ipl.c
 create mode 100644 pc-bios/s390-ccw/dasd-ipl.h
 create mode 100644 pc-bios/s390-ccw/helper.h
 create mode 100644 pc-bios/s390-ccw/s390-arch.h

--
2.7.4


Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
5b52a9ea01 s390-bios: Support booting from real dasd device
0e7289f537 s390-bios: Add channel command codes/structs needed for dasd-ipl
a434fe6c6d s390-bios: Use control unit type to determine boot method
ba9ad94973 s390-bios: Refactor virtio to run channel programs via cio
d2c7b774fd s390-bios: cio error handling
028eba5020 s390-bios: Support for running format-0/1 channel programs
43d36bb78e s390-bios: ptr2u32 and u32toptr
599c626517 s390-bios: Map low core memory
7f2a409316 s390-bios: Decouple channel i/o logic from virtio
37c07e15a9 s390-bios: Clean up cio.h
fd39523b20 s390-bios: Factor finding boot device out of virtio code path
f96fbcd49c s390-bios: Extend find_dev() for non-virtio devices
9f580acc20 s390-bios: decouple common boot logic from virtio
8cc9caf68d s390-bios: decouple cio setup from virtio
395a3257a1 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 395a3257a1e2 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 8cc9caf68df6 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 9f580acc2011 (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit f96fbcd49c03 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit fd39523b20cf (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 37c07e15a919 (s390-bios: Clean up cio.h)
7/15 Checking commit 7f2a409316c3 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 599c62651754 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 43d36bb78e22 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 028eba502095 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit d2c7b774fd89 (s390-bios: cio error handling)
12/15 Checking commit ba9ad94973e5 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit a434fe6c6d21 (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 0e7289f537ad (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 5b52a9ea0196 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by Jason J. Herne 8 weeks ago
On 3/13/19 12:31 PM, Jason J. Herne wrote:
> This is to support booting from vfio-ccw dasd devices. We basically implement
> the real hardware ipl procedure. This allows for booting Linux guests on
> vfio-ccw devices.
> 
> vfio-ccw's channel program prefetch algorithm complicates ipl because most ipl
> channel programs dynamically modify themselves. Details on the ipl process and
> how we worked around this issue can be found in docs/devel/s390-dasd-ipl.txt.
> 
> Changelog
> ==========
> v5
> - Whitespace changes and comments.
> - Added newlines to printed strings in patch 15.
> 
...

Ping. Thomas or Christian, are you ready to pick this series up or do you feel we need any 
more work?

-- 
-- Jason J. Herne (jjherne@linux.ibm.com)


Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by Thomas Huth 7 weeks ago
On 20/03/2019 16.11, Jason J. Herne wrote:
> On 3/13/19 12:31 PM, Jason J. Herne wrote:
>> This is to support booting from vfio-ccw dasd devices. We basically
>> implement
>> the real hardware ipl procedure. This allows for booting Linux guests on
>> vfio-ccw devices.
>>
>> vfio-ccw's channel program prefetch algorithm complicates ipl because
>> most ipl
>> channel programs dynamically modify themselves. Details on the ipl
>> process and
>> how we worked around this issue can be found in
>> docs/devel/s390-dasd-ipl.txt.
>>
>> Changelog
>> ==========
>> v5
>> - Whitespace changes and comments.
>> - Added newlines to printed strings in patch 15.
>>
> ...
> 
> Ping. Thomas or Christian, are you ready to pick this series up or do
> you feel we need any more work?

The regression with non-bootable devices still exists, i.e. this used to
work before:

 $ qemu-system-s390x -enable-kvm -nographic -device x-terminal3270 \
     -device virtio-blk-ccw,drive=dr1 \
     -drive if=none,id=dr1,format=qcow2,file=guest.qcow2

... but now aborts with:

 Attempting to boot from unexpected device type: 0x0000000000003270

Can you somehow limit the choice of devices here that are considered for
booting?

 Thomas

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by Thomas Huth 8 weeks ago
On 20/03/2019 16.11, Jason J. Herne wrote:
> On 3/13/19 12:31 PM, Jason J. Herne wrote:
>> This is to support booting from vfio-ccw dasd devices. We basically
>> implement
>> the real hardware ipl procedure. This allows for booting Linux guests on
>> vfio-ccw devices.
>>
>> vfio-ccw's channel program prefetch algorithm complicates ipl because
>> most ipl
>> channel programs dynamically modify themselves. Details on the ipl
>> process and
>> how we worked around this issue can be found in
>> docs/devel/s390-dasd-ipl.txt.
>>
>> Changelog
>> ==========
>> v5
>> - Whitespace changes and comments.
>> - Added newlines to printed strings in patch 15.
>>
> ...
> 
> Ping. Thomas or Christian, are you ready to pick this series up or do
> you feel we need any more work?

Sorry, I was out of office during the last week ... I'll try to have a
closer look during the next days... (but it's too late for 4.0 now since
we're already in the freeze period).

 Thomas

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
   36fe770966..523a2a42c3  master     -> master
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
ea5b2d5dbb s390-bios: Support booting from real dasd device
9af807232e s390-bios: Add channel command codes/structs needed for dasd-ipl
07592e8719 s390-bios: Use control unit type to determine boot method
6951c3ac21 s390-bios: Refactor virtio to run channel programs via cio
019a22ce2b s390-bios: cio error handling
233dcaa131 s390-bios: Support for running format-0/1 channel programs
071334b15c s390-bios: ptr2u32 and u32toptr
8fda549cc9 s390-bios: Map low core memory
9000c16854 s390-bios: Decouple channel i/o logic from virtio
d8c254d212 s390-bios: Clean up cio.h
52f48bcf08 s390-bios: Factor finding boot device out of virtio code path
141b34b683 s390-bios: Extend find_dev() for non-virtio devices
ca9d1e9638 s390-bios: decouple common boot logic from virtio
e528af5cbb s390-bios: decouple cio setup from virtio
edfff47b44 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit edfff47b4417 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit e528af5cbbfd (s390-bios: decouple cio setup from virtio)
3/15 Checking commit ca9d1e9638d2 (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 141b34b683e5 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 52f48bcf08d6 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit d8c254d212f1 (s390-bios: Clean up cio.h)
7/15 Checking commit 9000c16854b7 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 8fda549cc9fa (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 071334b15c8c (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 233dcaa13117 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit 019a22ce2be3 (s390-bios: cio error handling)
12/15 Checking commit 6951c3ac21d2 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 07592e8719d7 (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 9af807232e56 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit ea5b2d5dbb9a (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
1bf5971d8e s390-bios: Support booting from real dasd device
4cc01cddd8 s390-bios: Add channel command codes/structs needed for dasd-ipl
aaf1030744 s390-bios: Use control unit type to determine boot method
fb7803ac4e s390-bios: Refactor virtio to run channel programs via cio
fff15a4260 s390-bios: cio error handling
b3cf1d3e43 s390-bios: Support for running format-0/1 channel programs
bd371cb0f7 s390-bios: ptr2u32 and u32toptr
23441a0a32 s390-bios: Map low core memory
951d0fde02 s390-bios: Decouple channel i/o logic from virtio
775a168199 s390-bios: Clean up cio.h
dcd6097827 s390-bios: Factor finding boot device out of virtio code path
dc5858492d s390-bios: Extend find_dev() for non-virtio devices
6e03bf72c8 s390-bios: decouple common boot logic from virtio
7c22a8afb6 s390-bios: decouple cio setup from virtio
814c33c58f s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 814c33c58f8b (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 7c22a8afb68f (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 6e03bf72c85d (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit dc5858492d9f (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit dcd609782702 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 775a16819970 (s390-bios: Clean up cio.h)
7/15 Checking commit 951d0fde02f6 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 23441a0a3261 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit bd371cb0f7d1 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit b3cf1d3e4384 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit fff15a42609d (s390-bios: cio error handling)
12/15 Checking commit fb7803ac4e99 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit aaf10307449d (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 4cc01cddd87f (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 1bf5971d8e8b (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
14bf2bfa7d s390-bios: Support booting from real dasd device
3eeb0e5573 s390-bios: Add channel command codes/structs needed for dasd-ipl
fda8f8e7a8 s390-bios: Use control unit type to determine boot method
9791caad3e s390-bios: Refactor virtio to run channel programs via cio
ead3fec2b1 s390-bios: cio error handling
4b90526fd3 s390-bios: Support for running format-0/1 channel programs
8d5483ff02 s390-bios: ptr2u32 and u32toptr
2f5c86181a s390-bios: Map low core memory
2a68ea5054 s390-bios: Decouple channel i/o logic from virtio
ccdb223cbb s390-bios: Clean up cio.h
368c7519c9 s390-bios: Factor finding boot device out of virtio code path
5ba43279c8 s390-bios: Extend find_dev() for non-virtio devices
900c23168c s390-bios: decouple common boot logic from virtio
74b23b191a s390-bios: decouple cio setup from virtio
8e9223d357 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 8e9223d3577b (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 74b23b191aef (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 900c23168c53 (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 5ba43279c892 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 368c7519c9c8 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit ccdb223cbbda (s390-bios: Clean up cio.h)
7/15 Checking commit 2a68ea50540f (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 2f5c86181a01 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 8d5483ff028e (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 4b90526fd317 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit ead3fec2b1ca (s390-bios: cio error handling)
12/15 Checking commit 9791caad3e7c (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit fda8f8e7a854 (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 3eeb0e5573f9 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 14bf2bfa7dbb (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
cd514b4e60 s390-bios: Support booting from real dasd device
27a733a38f s390-bios: Add channel command codes/structs needed for dasd-ipl
58d77c77cc s390-bios: Use control unit type to determine boot method
f35fdd07de s390-bios: Refactor virtio to run channel programs via cio
461083b940 s390-bios: cio error handling
6d5bd7c785 s390-bios: Support for running format-0/1 channel programs
8db73f2261 s390-bios: ptr2u32 and u32toptr
0054a39d4e s390-bios: Map low core memory
fd6bd00914 s390-bios: Decouple channel i/o logic from virtio
b1f529dacb s390-bios: Clean up cio.h
402c563ccd s390-bios: Factor finding boot device out of virtio code path
0916a051e0 s390-bios: Extend find_dev() for non-virtio devices
cd95f973b3 s390-bios: decouple common boot logic from virtio
424646eba2 s390-bios: decouple cio setup from virtio
29fa9c2874 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 29fa9c287475 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 424646eba20c (s390-bios: decouple cio setup from virtio)
3/15 Checking commit cd95f973b3e4 (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 0916a051e010 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 402c563ccd47 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit b1f529dacb8f (s390-bios: Clean up cio.h)
7/15 Checking commit fd6bd0091402 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 0054a39d4e5f (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 8db73f2261ed (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 6d5bd7c78587 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit 461083b9408e (s390-bios: cio error handling)
12/15 Checking commit f35fdd07de40 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 58d77c77ccee (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 27a733a38f9c (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit cd514b4e6066 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
6ab8ad2ff9 s390-bios: Support booting from real dasd device
a9256d3427 s390-bios: Add channel command codes/structs needed for dasd-ipl
f28f52b209 s390-bios: Use control unit type to determine boot method
29fc48af3f s390-bios: Refactor virtio to run channel programs via cio
2734245df2 s390-bios: cio error handling
e7432cd8da s390-bios: Support for running format-0/1 channel programs
6c1974320c s390-bios: ptr2u32 and u32toptr
bb00e116f1 s390-bios: Map low core memory
c5d71f41f5 s390-bios: Decouple channel i/o logic from virtio
7186dda499 s390-bios: Clean up cio.h
29686c3fd2 s390-bios: Factor finding boot device out of virtio code path
8838da3b5f s390-bios: Extend find_dev() for non-virtio devices
4b35710f4e s390-bios: decouple common boot logic from virtio
6f712b8229 s390-bios: decouple cio setup from virtio
438e215747 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 438e21574796 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 6f712b8229b2 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 4b35710f4efc (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 8838da3b5f2f (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 29686c3fd231 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 7186dda4998c (s390-bios: Clean up cio.h)
7/15 Checking commit c5d71f41f58f (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit bb00e116f1c3 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 6c1974320cad (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit e7432cd8da91 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit 2734245df2eb (s390-bios: cio error handling)
12/15 Checking commit 29fc48af3f06 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit f28f52b209af (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit a9256d342729 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 6ab8ad2ff950 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
 t [tag update]            patchew/20190313164207.25166-1-marcandre.lureau@redhat.com -> patchew/20190313164207.25166-1-marcandre.lureau@redhat.com
Switched to a new branch 'test'
4b8f0d8ca1 s390-bios: Support booting from real dasd device
58d89a48aa s390-bios: Add channel command codes/structs needed for dasd-ipl
27184019e9 s390-bios: Use control unit type to determine boot method
e89de02f38 s390-bios: Refactor virtio to run channel programs via cio
4a9e3f3293 s390-bios: cio error handling
0e3c357024 s390-bios: Support for running format-0/1 channel programs
e026f9363d s390-bios: ptr2u32 and u32toptr
69b1199cb4 s390-bios: Map low core memory
81c99b9681 s390-bios: Decouple channel i/o logic from virtio
8cc7aeaf32 s390-bios: Clean up cio.h
eb50486bcc s390-bios: Factor finding boot device out of virtio code path
f01ef093e9 s390-bios: Extend find_dev() for non-virtio devices
560a2985c0 s390-bios: decouple common boot logic from virtio
c4b6e8b164 s390-bios: decouple cio setup from virtio
2a16b06b29 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 2a16b06b291d (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit c4b6e8b16493 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 560a2985c0e9 (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit f01ef093e92f (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit eb50486bcc42 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 8cc7aeaf32a1 (s390-bios: Clean up cio.h)
7/15 Checking commit 81c99b9681c0 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 69b1199cb4d5 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit e026f9363d16 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 0e3c3570241d (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit 4a9e3f329374 (s390-bios: cio error handling)
12/15 Checking commit e89de02f3828 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 27184019e9da (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 58d89a48aaa4 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 4b8f0d8ca11f (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
ba6e0b49ef s390-bios: Support booting from real dasd device
d8f0f6a831 s390-bios: Add channel command codes/structs needed for dasd-ipl
77d4a6c854 s390-bios: Use control unit type to determine boot method
abd580c4e8 s390-bios: Refactor virtio to run channel programs via cio
f4aa2655fe s390-bios: cio error handling
f6e6c855fb s390-bios: Support for running format-0/1 channel programs
d19e0f1fcc s390-bios: ptr2u32 and u32toptr
a2d3802471 s390-bios: Map low core memory
6ff41ded4c s390-bios: Decouple channel i/o logic from virtio
77c9a181ce s390-bios: Clean up cio.h
0529825e5d s390-bios: Factor finding boot device out of virtio code path
01ac92151c s390-bios: Extend find_dev() for non-virtio devices
fff49d16e3 s390-bios: decouple common boot logic from virtio
63915cf62c s390-bios: decouple cio setup from virtio
1728c02667 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 1728c0266789 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 63915cf62c3a (s390-bios: decouple cio setup from virtio)
3/15 Checking commit fff49d16e3ba (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 01ac92151c72 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 0529825e5d28 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 77c9a181ce7b (s390-bios: Clean up cio.h)
7/15 Checking commit 6ff41ded4c02 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit a2d3802471bd (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit d19e0f1fccd6 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit f6e6c855fbf7 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit f4aa2655fef0 (s390-bios: cio error handling)
12/15 Checking commit abd580c4e82f (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 77d4a6c854b8 (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit d8f0f6a83136 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit ba6e0b49ef25 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
7018a8ad7b s390-bios: Support booting from real dasd device
200a689b7e s390-bios: Add channel command codes/structs needed for dasd-ipl
7165811dd9 s390-bios: Use control unit type to determine boot method
22d46792f3 s390-bios: Refactor virtio to run channel programs via cio
fba5c69205 s390-bios: cio error handling
8a966a9ba5 s390-bios: Support for running format-0/1 channel programs
22fb949e96 s390-bios: ptr2u32 and u32toptr
98063fb57c s390-bios: Map low core memory
3ee204fbd1 s390-bios: Decouple channel i/o logic from virtio
aeeb14a190 s390-bios: Clean up cio.h
050d5c4c94 s390-bios: Factor finding boot device out of virtio code path
674d555def s390-bios: Extend find_dev() for non-virtio devices
7219a107cc s390-bios: decouple common boot logic from virtio
172fe77f27 s390-bios: decouple cio setup from virtio
e2742ea079 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit e2742ea079fd (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit 172fe77f2727 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 7219a107ccbb (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 674d555def47 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 050d5c4c9459 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit aeeb14a1903e (s390-bios: Clean up cio.h)
7/15 Checking commit 3ee204fbd186 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 98063fb57c61 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 22fb949e9618 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 8a966a9ba518 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit fba5c692056d (s390-bios: cio error handling)
12/15 Checking commit 22d46792f354 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 7165811dd935 (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 200a689b7e54 (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 7018a8ad7b07 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
 t [tag update]            patchew/20190313164207.25166-1-marcandre.lureau@redhat.com -> patchew/20190313164207.25166-1-marcandre.lureau@redhat.com
Switched to a new branch 'test'
42f8f67117 s390-bios: Support booting from real dasd device
94859da650 s390-bios: Add channel command codes/structs needed for dasd-ipl
7a3be8562a s390-bios: Use control unit type to determine boot method
27f1c33148 s390-bios: Refactor virtio to run channel programs via cio
c1984f0aa2 s390-bios: cio error handling
4e0664dc7a s390-bios: Support for running format-0/1 channel programs
40642d124e s390-bios: ptr2u32 and u32toptr
53bdd4f1db s390-bios: Map low core memory
19aa773fe0 s390-bios: Decouple channel i/o logic from virtio
5bd50df71f s390-bios: Clean up cio.h
909d0f2350 s390-bios: Factor finding boot device out of virtio code path
bb1a45c33b s390-bios: Extend find_dev() for non-virtio devices
ad9800c00d s390-bios: decouple common boot logic from virtio
db23e99a35 s390-bios: decouple cio setup from virtio
818be0a826 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit 818be0a826a2 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit db23e99a3558 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit ad9800c00db0 (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit bb1a45c33be2 (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit 909d0f235029 (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 5bd50df71f2f (s390-bios: Clean up cio.h)
7/15 Checking commit 19aa773fe0de (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 53bdd4f1db64 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit 40642d124e9c (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 4e0664dc7a05 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit c1984f0aa2a9 (s390-bios: cio error handling)
12/15 Checking commit 27f1c3314879 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 7a3be8562aca (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 94859da650cd (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 42f8f67117c2 (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com

Re: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

Posted by no-reply@patchew.org 9 weeks ago
Patchew URL: https://patchew.org/QEMU/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Subject: [Qemu-devel] [PATCH v5 00/15] s390: vfio-ccw dasd ipl support

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com -> patchew/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com
Switched to a new branch 'test'
3105bfc132 s390-bios: Support booting from real dasd device
5ebb157188 s390-bios: Add channel command codes/structs needed for dasd-ipl
3f2397d90c s390-bios: Use control unit type to determine boot method
ce02ebe933 s390-bios: Refactor virtio to run channel programs via cio
fffce380ea s390-bios: cio error handling
50bb4ae386 s390-bios: Support for running format-0/1 channel programs
c2781a88cb s390-bios: ptr2u32 and u32toptr
595c9603e3 s390-bios: Map low core memory
21a86add15 s390-bios: Decouple channel i/o logic from virtio
8d1d585c08 s390-bios: Clean up cio.h
dfa531ecb5 s390-bios: Factor finding boot device out of virtio code path
98f226b2d5 s390-bios: Extend find_dev() for non-virtio devices
1e88789b79 s390-bios: decouple common boot logic from virtio
feb813bd53 s390-bios: decouple cio setup from virtio
c8d72697b7 s390 vfio-ccw: Add bootindex property and IPLB data

=== OUTPUT BEGIN ===
1/15 Checking commit c8d72697b7e3 (s390 vfio-ccw: Add bootindex property and IPLB data)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#221: 
new file mode 100644

total: 0 errors, 1 warnings, 199 lines checked

Patch 1/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/15 Checking commit feb813bd53d9 (s390-bios: decouple cio setup from virtio)
3/15 Checking commit 1e88789b79fb (s390-bios: decouple common boot logic from virtio)
ERROR: externs should be avoided in .c files
#31: FILE: pc-bios/s390-ccw/main.c:19:
+IplParameterBlock iplb __attribute__((__aligned__(PAGE_SIZE)));

total: 1 errors, 0 warnings, 65 lines checked

Patch 3/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/15 Checking commit 98f226b2d51c (s390-bios: Extend find_dev() for non-virtio devices)
5/15 Checking commit dfa531ecb55c (s390-bios: Factor finding boot device out of virtio code path)
6/15 Checking commit 8d1d585c08b6 (s390-bios: Clean up cio.h)
7/15 Checking commit 21a86add1525 (s390-bios: Decouple channel i/o logic from virtio)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

total: 0 errors, 1 warnings, 123 lines checked

Patch 7/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/15 Checking commit 595c9603e3d2 (s390-bios: Map low core memory)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#36: 
new file mode 100644

total: 0 errors, 1 warnings, 104 lines checked

Patch 8/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/15 Checking commit c2781a88cb27 (s390-bios: ptr2u32 and u32toptr)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 31 lines checked

Patch 9/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/15 Checking commit 50bb4ae386a0 (s390-bios: Support for running format-0/1 channel programs)
ERROR: trailing whitespace
#138: FILE: pc-bios/s390-ccw/cio.c:145:
+ * active (generating i/o interrupts). $

total: 1 errors, 0 warnings, 375 lines checked

Patch 10/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

11/15 Checking commit fffce380ea47 (s390-bios: cio error handling)
12/15 Checking commit ce02ebe93375 (s390-bios: Refactor virtio to run channel programs via cio)
WARNING: line over 80 characters
#104: FILE: pc-bios/s390-ccw/virtio.c:298:
+            run_ccw(vdev, CCW_CMD_READ_VQ_CONF, &config, sizeof(config), false) == 0,

WARNING: line over 80 characters
#117: FILE: pc-bios/s390-ccw/virtio.c:308:
+        run_ccw(vdev, CCW_CMD_WRITE_STATUS, &status, sizeof(status), false) == 0,

total: 0 errors, 2 warnings, 115 lines checked

Patch 12/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/15 Checking commit 3f2397d90c80 (s390-bios: Use control unit type to determine boot method)
14/15 Checking commit 5ebb157188ba (s390-bios: Add channel command codes/structs needed for dasd-ipl)
15/15 Checking commit 3105bfc132ed (s390-bios: Support booting from real dasd device)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#26: 
new file mode 100644

total: 0 errors, 1 warnings, 447 lines checked

Patch 15/15 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/1552494682-16788-1-git-send-email-jjherne@linux.ibm.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com