1. Patchew
  2. QEMU
  3. [Qemu-devel] [PULL 0/7] qtests, clean-ups and macOS CI testing
  4. View patch

[Qemu-devel] [PULL 6/7] tests/bios-tables: Improve portability by searching bash in the $PATH

Thomas Huth posted 7 patches 6 years, 8 months ago
Maintainers: Aurelien Jarno <aurelien@aurel32.net>, BALATON Zoltan <balaton@eik.bme.hu>, Gerd Hoffmann <kraxel@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Michael Walle <michael@walle.cc>, Andrzej Zaborowski <balrogg@gmail.com>, Laurent Vivier <lvivier@redhat.com>, Jason Wang <jasowang@redhat.com>, Helge Deller <deller@gmx.de>, Li-Wen Hsu <lwhsu@freebsd.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Juan Quintela <quintela@redhat.com>, "Dr. David Alan Gilbert" <dgilbert@redhat.com>, Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, Magnus Damm <magnus.damm@gmail.com>, Kevin Wolf <kwolf@redhat.com>, Markus Armbruster <armbru@redhat.com>, David Gibson <david@gibson.dropbear.id.au>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Ed Maste <emaste@freebsd.org>, Thomas Huth <thuth@redhat.com>, Rob Herring <robh@kernel.org>, Joel Stanley <joel@jms.id.au>, Jan Kiszka <jan.kiszka@web.de>, "Michael S. Tsirkin" <mst@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Beniamino Galvani <b.galvani@gmail.com>, Richard Henderson <rth@twiddle.net>
[Qemu-devel] [PULL 6/7] tests/bios-tables: Improve portability by searching bash in the $PATH
Posted by Thomas Huth 6 years, 8 months ago 
From: Philippe Mathieu-Daudé <philmd@redhat.com>

Bash is not always installed as /bin/bash. In particular on OpenBSD,
the package installs it in /usr/local/bin.
Use the 'env' shebang to search bash in the $PATH.

Reviewed-by: Kamil Rytarowski <n54@gmx.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 tests/data/acpi/rebuild-expected-aml.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/data/acpi/rebuild-expected-aml.sh b/tests/data/acpi/rebuild-expected-aml.sh
index bf9ba24..abdff70 100755
--- a/tests/data/acpi/rebuild-expected-aml.sh
+++ b/tests/data/acpi/rebuild-expected-aml.sh
@@ -1,4 +1,4 @@
-#! /bin/bash
+#!/usr/bin/env bash
 
 #
 # Rebuild expected AML files for acpi unit-test
-- 
1.8.3.1

Patchew 2.1-devel-b67e4c2

© 2016 - 2025 Red Hat, Inc.